libvirt

mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-05 03:09:30 +00:00

History

Daniel P. Berrange 2b510e4903 Fix off-by-1 in default SELinux MCS range

For a while we're have random failures of 'securityselinuxtest'
which were not at all reproducible. Fortunately we finally
caught a failure with VIR_TEST_DEBUG=1 enabled. This revealed

TEST: securityselinuxtest
 1) GenLabel "dynamic unconfined, s0, c0.c1023"                       ... OK
 2) GenLabel "dynamic unconfined, s0, c0.c1023"                       ... OK
 3) GenLabel "dynamic unconfined, s0, c0.c1023"                       ... OK
 4) GenLabel "dynamic virtd, s0, c0.c1023"                            ... OK
 5) GenLabel "dynamic virtd, s0, c0.c10"                              ... OK
 6) GenLabel "dynamic virtd, s2-s3, c0.c1023"                         ... OK
 7) GenLabel "dynamic virtd, missing range"                           ... Category two 1024 is out of range 0-1023
FAILED
FAIL: securityselinuxtest

And sure enough we had an off-by-1 in the MCS range code when
the current process has no range set. The test suite randomly
allocates 2 categories from 0->1024 so the chances of hitting
this in the test suite were slim indeed :-)

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>

2013-11-20 13:09:00 +00:00

security_apparmor.c

apparmor: Fix typo in function name in driver struct initialization

2013-10-29 17:01:22 +01:00

security_apparmor.h

maint: fix up copyright notice inconsistencies

2012-09-20 16:30:55 -06:00

security_dac.c

Add '+' to uid/gid printing for label processing

2013-10-29 17:10:15 -04:00

security_dac.h

security: use a single function to set DAC user and group