Laine Stump
9a08168301
util: restructure virNetDevReadNetConfig() to eliminate false error logs ...
virHostdevRestoreNetConfig() calls virNetDevReadNetConfig() to try and
read the "original config" of a netdev, and if that fails, it tries
again with a different directory/netdev name. This achieves the
desired effect (we end up finding the config wherever it may be), but
for each failure, virNetDevReadNetConfig() places a nice error message
in the system logs. Experience has shown that false-positive error
logs like this lead to erroneous bug reports, and can often mislead
those searching for *real* bugs.
This patch changes virNetDevReadNetConfig() to explicitly check if the
file exists before calling virFileReadAll(); if it doesn't exist,
virNetDevReadNetConfig() returns a success, but leaves all the
variables holding the results as NULL. (This makes sense if you define
the purpose of the function as "read a netdev's config from its config
file *if that file exists*).
To take advantage of that change, the caller,
virHostdevRestoreNetConfig() is modified to fail immediately if
virNetDevReadNetConfig() returns an error, and otherwise to try the
different directory/netdev name if adminMAC & vlan & MAC are all NULL
after the preceding attempt.
2017-08-11 19:09:49 -04:00
2017-04-28 14:17:10 +02:00
2017-02-23 10:11:16 +00:00
2016-05-19 16:30:04 -04:00
2016-06-16 06:17:58 -04:00
2017-07-20 16:14:50 +02:00
2017-07-20 16:14:50 +02:00
2017-07-27 09:31:14 +02:00
2017-07-27 09:31:14 +02:00
2017-08-01 11:37:51 +02:00
2017-07-25 17:02:27 +02:00
2017-02-03 19:38:39 -05:00
2017-02-20 15:12:07 +01:00
2017-07-11 10:41:24 +02:00
2017-07-13 13:07:06 +01:00
2017-08-08 12:19:17 +02:00
2017-08-08 12:19:17 +02:00
2017-05-02 17:27:13 +01:00
2017-07-13 13:07:06 +01:00
2016-11-23 12:08:15 -05:00
2016-07-13 13:49:03 +03:00
2016-07-13 13:49:03 +03:00
2016-06-24 13:23:02 -04:00
2016-11-15 15:50:51 +01:00
2016-06-16 13:09:19 -04:00
2017-01-25 09:18:49 +01:00
2017-05-26 20:00:51 +04:00
2017-05-26 10:44:05 -04:00
2017-07-11 08:41:01 +02:00
2017-05-18 07:42:13 +02:00
2017-07-19 09:46:17 +02:00
2017-07-13 13:07:06 +01:00
2017-07-26 15:31:25 +02:00
2017-07-26 15:31:25 +02:00
2017-01-04 11:14:56 +01:00
2017-01-04 12:47:01 +01:00
2016-11-25 13:54:05 +01:00
2016-06-13 14:13:16 -06:00
2017-05-16 16:48:30 +02:00
2017-07-20 14:02:14 +02:00
2017-08-03 09:49:15 +02:00
2017-06-12 19:11:30 -04:00
2017-08-03 09:49:15 +02:00
2016-08-02 14:20:31 +02:00
2016-08-02 14:20:31 +02:00
2017-05-30 10:42:28 +02:00
2017-07-13 13:07:06 +01:00
2017-03-27 13:13:29 +02:00
2017-08-11 19:09:49 -04:00
2017-03-27 12:41:24 -04:00
2017-04-27 14:13:19 +02:00
2016-06-09 18:43:18 +01:00
2016-10-13 17:58:56 +08:00
2017-04-05 15:18:30 +02:00
2016-07-28 08:27:13 -04:00
2017-07-11 14:20:05 +02:00
2017-07-11 14:02:28 +02:00
2017-04-25 21:14:18 +01:00
2016-10-05 08:33:59 +02:00
2017-06-14 15:01:42 +01:00
2016-12-15 10:36:23 +01:00
2017-03-24 00:37:01 -04:00
2017-07-13 13:07:06 +01:00
2017-01-02 13:05:34 +01:00
2016-12-06 13:33:18 +01:00
2017-05-18 12:20:15 +02:00
2017-05-18 12:20:15 +02:00
2017-08-11 19:09:49 -04:00
2017-08-11 18:25:00 -04:00
2017-03-22 13:50:00 -04:00
2017-06-28 15:27:17 +02:00
2017-04-26 18:59:24 +02:00
2017-07-13 13:07:06 +01:00
2017-08-11 19:09:49 -04:00
2017-04-28 09:43:52 -04:00
2017-07-20 15:15:03 +02:00
2017-07-20 15:15:03 +02:00
2017-06-16 10:18:35 +02:00
2017-07-13 13:07:06 +01:00
2016-06-26 19:33:07 -04:00
2017-03-22 13:50:00 -04:00
2017-05-18 07:26:05 -04:00
2017-03-22 09:01:32 +01:00
2017-03-27 13:13:29 +02:00
2017-03-27 13:13:29 +02:00
2016-09-14 08:41:41 +02:00
2017-07-13 13:07:06 +01:00
2017-07-25 10:56:03 +02:00
2017-07-24 15:54:06 +02:00
2017-08-11 19:05:20 -04:00
2017-08-11 19:05:20 -04:00
2017-05-04 16:42:25 +02:00
2017-03-07 13:51:05 -05:00
2016-11-25 13:54:05 +01:00
2017-03-28 10:54:49 +02:00
2017-01-11 18:02:35 +01:00
2017-06-12 12:45:42 +02:00
2017-06-12 12:45:42 +02:00
2016-06-07 10:18:36 -04:00
2017-07-13 13:07:06 +01:00
2017-04-13 08:14:54 -04:00
2017-02-19 06:45:09 -05:00
2017-07-13 13:07:06 +01:00
2017-02-19 06:45:09 -05:00
2017-02-19 06:45:09 -05:00
2016-12-15 09:25:16 +01:00
2017-07-13 13:07:06 +01:00
2016-06-23 12:30:28 -04:00
2016-06-23 12:30:28 -04:00
2017-05-26 12:15:13 +02:00
2017-07-11 13:57:11 +01:00
2016-07-11 14:21:01 +02:00
2017-04-03 16:15:29 -04:00
2017-07-27 09:44:05 +02:00
2017-07-27 09:44:05 +02:00
2017-07-24 10:55:43 +02:00
2017-07-24 10:55:43 +02:00
2017-04-11 13:23:00 +02:00
2017-03-07 10:44:26 +01:00
2017-07-25 17:02:27 +02:00
2017-07-25 17:02:27 +02:00
2017-03-06 15:44:33 +01:00
2017-07-25 10:56:03 +02:00
2017-07-25 10:56:03 +02:00
2017-03-16 09:21:39 +01:00
2017-07-13 13:07:06 +01:00
2016-11-23 12:08:15 -05:00
2017-03-22 13:50:00 -04:00
2016-11-25 13:54:05 +01:00
2017-07-24 10:55:43 +02:00
2017-05-24 12:23:59 -04:00
2016-12-15 09:25:16 +01:00
2017-07-11 13:57:11 +01:00
2017-07-13 13:07:06 +01:00
2017-07-13 13:07:06 +01:00
2017-02-19 15:47:27 +01:00
2017-02-19 06:45:09 -05:00
2016-12-06 13:33:18 +01:00
2016-10-20 18:49:22 +08:00
9a08168301