mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-23 06:05:27 +00:00
857df2fe50
In a few places we declare a variable (which is optionally
followed by a code not touching it) then set the variable to a
value and return the variable immediately. It's obvious that the
variable is needless and the value can be returned directly
instead.
This patch was generated using this semantic patch:
@@
type T;
identifier ret;
expression E;
@@
- T ret;
... when != ret
when strict
- ret = E;
- return ret;
+ return E;
After that I fixed couple of formatting issues because coccinelle
formatted some lines differently than our coding style.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
100 lines
2.3 KiB
C
100 lines
2.3 KiB
C
/*
|
|
* Copyright (C) 2014 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include <sys/types.h>
|
|
#include <sys/stat.h>
|
|
#include <dirent.h>
|
|
#include <dlfcn.h>
|
|
#include <fcntl.h>
|
|
|
|
#include "viralloc.h"
|
|
#include "virfile.h"
|
|
#include "virstring.h"
|
|
#include "virusb.h"
|
|
|
|
#define USB_SYSFS "/sys/bus/usb"
|
|
#define FAKE_USB_SYSFS "virusbtestdata/sys_bus_usb"
|
|
|
|
static int (*realopen)(const char *pathname, int flags, ...);
|
|
static DIR *(*realopendir)(const char *name);
|
|
|
|
static void init_syms(void)
|
|
{
|
|
if (realopen)
|
|
return;
|
|
|
|
realopen = dlsym(RTLD_NEXT, "open");
|
|
realopendir = dlsym(RTLD_NEXT, "opendir");
|
|
if (!realopen || !realopendir) {
|
|
fprintf(stderr, "Error getting symbols");
|
|
abort();
|
|
}
|
|
}
|
|
|
|
static char *get_fake_path(const char *real_path)
|
|
{
|
|
const char *p = NULL;
|
|
char *path = NULL;
|
|
|
|
if ((p = STRSKIP(real_path, USB_SYSFS)))
|
|
path = g_strdup_printf("%s/%s/%s", abs_srcdir, FAKE_USB_SYSFS, p);
|
|
else if (!p)
|
|
path = g_strdup(real_path);
|
|
|
|
return path;
|
|
}
|
|
|
|
DIR *opendir(const char *name)
|
|
{
|
|
g_autofree char *path = NULL;
|
|
|
|
init_syms();
|
|
|
|
path = get_fake_path(name);
|
|
|
|
return realopendir(path);
|
|
}
|
|
|
|
int open(const char *pathname, int flags, ...)
|
|
{
|
|
g_autofree char *path = NULL;
|
|
int ret;
|
|
va_list ap;
|
|
mode_t mode = 0;
|
|
|
|
init_syms();
|
|
|
|
path = get_fake_path(pathname);
|
|
if (!path)
|
|
return -1;
|
|
|
|
/* The mode argument is mandatory when O_CREAT is set in flags,
|
|
* otherwise the argument is ignored.
|
|
*/
|
|
if (flags & O_CREAT) {
|
|
va_start(ap, flags);
|
|
mode = (mode_t) va_arg(ap, int);
|
|
va_end(ap);
|
|
}
|
|
|
|
ret = realopen(path, flags, mode);
|
|
return ret;
|
|
}
|