mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-12 12:55:46 +00:00
3fd64fb0e2
As of v9.4.0-rc2~5 it is possible to specify guest address where a virtio-mem/virtio-pmem memory device is mapped to. What that commit forgot to introduce was a check for overlaps. And yes, this is technically an O(n^2) algorithm, as virDomainMemoryDefValidate() is called over each memory device and after this, virDomainMemoryDefValidate() also iterates over each memory device. But given there's usually only a handful of such devices, and this runs only when parsing domain XML I guess code readability wins over some less obvious solution. Resolves: https://issues.redhat.com/browse/RHEL-4452 Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
51 lines
1.6 KiB
XML
51 lines
1.6 KiB
XML
<domain type='kvm'>
|
|
<name>QEMUGuest1</name>
|
|
<uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
|
|
<maxMemory unit='KiB'>1099511627776</maxMemory>
|
|
<memory unit='KiB'>8388608</memory>
|
|
<currentMemory unit='KiB'>8388608</currentMemory>
|
|
<vcpu placement='static' cpuset='0-1'>2</vcpu>
|
|
<os>
|
|
<type arch='x86_64' machine='pc'>hvm</type>
|
|
<boot dev='hd'/>
|
|
</os>
|
|
<cpu mode='custom' match='exact' check='none'>
|
|
<model fallback='forbid'>qemu64</model>
|
|
<topology sockets='2' dies='1' cores='1' threads='1'/>
|
|
<numa>
|
|
<cell id='0' cpus='0-1' memory='2095104' unit='KiB'/>
|
|
</numa>
|
|
</cpu>
|
|
<clock offset='utc'/>
|
|
<on_poweroff>destroy</on_poweroff>
|
|
<on_reboot>restart</on_reboot>
|
|
<on_crash>destroy</on_crash>
|
|
<devices>
|
|
<emulator>/usr/bin/qemu-system-x86_64</emulator>
|
|
<memory model='virtio-mem'>
|
|
<target>
|
|
<size unit='KiB'>1048576</size>
|
|
<node>0</node>
|
|
<block unit='KiB'>2048</block>
|
|
<requested unit='KiB'>524288</requested>
|
|
<address base='0x140000000'/>
|
|
</target>
|
|
<address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
|
|
</memory>
|
|
<memory model='virtio-mem'>
|
|
<source>
|
|
<nodemask>1-3</nodemask>
|
|
<pagesize unit='KiB'>2048</pagesize>
|
|
</source>
|
|
<target>
|
|
<size unit='KiB'>2097152</size>
|
|
<node>0</node>
|
|
<block unit='KiB'>2048</block>
|
|
<requested unit='KiB'>1048576</requested>
|
|
<address base='0x170000000'/>
|
|
</target>
|
|
<address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'/>
|
|
</memory>
|
|
</devices>
|
|
</domain>
|