libvirt/src/conf
Ján Tomko 66e84b8a95 conf: virDomainDiskSourceFormat: check for srcpool presence correctly
As a guard against programming errors, one part of the condition
only dereferences srcpool if it exists, other one does not.

Move the check up one level so that it actually has a chance to do
something useful.

Fixes: 19b1c0d319
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
2023-11-21 18:04:53 +01:00
..
schemas capabilities: report full external snapshot support 2023-10-09 15:06:59 +02:00
backup_conf.c lib: Replace xmlKeepBlanksDefault() with virXMLParseWithIndent() 2023-11-21 14:43:39 +01:00
backup_conf.h conf: backup: Remove virDomainBackupDefParseNode 2022-10-06 10:54:25 +02:00
capabilities.c capabilities: report full external snapshot support 2023-10-09 15:06:59 +02:00
capabilities.h capabilities: report full external snapshot support 2023-10-09 15:06:59 +02:00
checkpoint_conf.c lib: Replace xmlKeepBlanksDefault() with virXMLParseWithIndent() 2023-11-21 14:43:39 +01:00
checkpoint_conf.h
cpu_conf.c conf: Move error messages onto a single line 2023-09-04 09:35:35 +02:00
cpu_conf.h conf: cpu: add limit for maxphysaddr 2023-04-25 11:19:37 +02:00
device_conf.c virDomainDeviceInfo: Convert 'type' field to proper enum type 2023-09-15 10:35:17 +02:00
device_conf.h virDomainDeviceInfo: Convert 'type' field to proper enum type 2023-09-15 10:35:17 +02:00
domain_addr.c conf: Move error messages onto a single line 2023-09-04 09:35:35 +02:00
domain_addr.h util: refactor virDomainCCWAddressAsString into virccw 2022-05-23 16:31:42 +02:00
domain_audit.c virDomainRNGDef: Convert 'backend' field to proper enum type 2023-09-15 10:35:11 +02:00
domain_audit.h
domain_capabilities.c src: update log/error messages pointing to old mailing list addr 2023-10-31 10:04:25 +00:00
domain_capabilities.h conf: domcaps: Add 'async-teardown' domain capability 2023-07-18 08:49:32 +02:00
domain_conf.c conf: virDomainDiskSourceFormat: check for srcpool presence correctly 2023-11-21 18:04:53 +01:00
domain_conf.h virDomainDiskGetDetectZeroesMode: Return proper type 2023-11-02 15:24:10 +01:00
domain_event.c src: Avoid needless checks before calling g_strdup() 2023-09-18 14:46:24 +02:00
domain_event.h qemu: fix memory leak about virDomainEventTunableNew 2022-09-27 10:04:20 +02:00
domain_nwfilter.c conf: Remove unused includes 2022-06-16 06:43:56 +02:00
domain_nwfilter.h
domain_postparse.c src: Drop needless typecast to virDomainDeviceType 2023-09-15 10:34:48 +02:00
domain_postparse.h conf: Separate domain post parse code into domain_postparse.c 2022-07-07 14:32:21 +02:00
domain_validate.c virDomainMemoryDefValidate: Skip the same device on validation on memory device update 2023-10-16 13:00:52 +02:00
domain_validate.h conf: Export virDomainDefOSValidate() 2023-03-03 13:49:56 +01:00
interface_conf.c conf: Update format strings in translated messages 2023-04-01 11:40:32 +02:00
interface_conf.h conf: interface: Remove virInterfaceDefParseFile 2022-10-06 10:54:25 +02:00
meson.build move files: hypervisor/domain_job -> conf/virdomainjob 2022-09-07 12:06:17 +02:00
moment_conf.c conf: Remove unused includes 2022-06-16 06:43:56 +02:00
moment_conf.h
netdev_bandwidth_conf.c conf: Move error messages onto a single line 2023-09-04 09:35:35 +02:00
netdev_bandwidth_conf.h
netdev_vlan_conf.c conf: Move error messages onto a single line 2023-09-04 09:35:35 +02:00
netdev_vlan_conf.h
netdev_vport_profile_conf.c conf: Update format strings in translated messages 2023-04-01 11:40:32 +02:00
netdev_vport_profile_conf.h
network_conf.c lib: Replace xmlKeepBlanksDefault() with virXMLParseWithIndent() 2023-11-21 14:43:39 +01:00
network_conf.h Add <title> and <description> for Network Objects 2023-08-25 12:36:37 +02:00
network_event.c conf: Add methods to create Metadata change events 2023-09-18 11:24:49 +02:00
network_event.h conf: Add methods to create Metadata change events 2023-09-18 11:24:49 +02:00
networkcommon_conf.c conf: Update format strings in translated messages 2023-04-01 11:40:32 +02:00
networkcommon_conf.h virNetDevIPRouteParseXML: Refactor to use 'virXMLProp*' instead of XPath 2022-11-02 09:20:57 +01:00
node_device_conf.c conf: Move error messages onto a single line 2023-09-04 09:35:35 +02:00
node_device_conf.h conf: node_device: Add 'validate' argument to virNodeDeviceDefParse 2022-11-01 13:07:20 +01:00
node_device_event.c
node_device_event.h conf: Remove unused includes 2022-06-16 06:43:56 +02:00
node_device_util.c conf: Move error messages onto a single line 2023-09-04 09:35:35 +02:00
node_device_util.h
numa_conf.c conf: Move error messages onto a single line 2023-09-04 09:35:35 +02:00
numa_conf.h virDomainNumatuneNodeSpecified: Fix const correctness 2023-05-22 13:49:34 +02:00
nwfilter_conf.c conf/nwfilter: Initialize size_t attr to zero 2023-06-14 12:47:55 +02:00
nwfilter_conf.h virNWFilterRuleDef: Turn 'action' and 'tt' into proper enum types 2023-06-05 13:23:06 +02:00
nwfilter_ipaddrmap.c conf: Remove unused includes 2022-06-16 06:43:56 +02:00
nwfilter_ipaddrmap.h
nwfilter_params.c conf: Move error messages onto a single line 2023-09-04 09:35:35 +02:00
nwfilter_params.h conf: Remove unused includes 2022-06-16 06:43:56 +02:00
object_event_private.h
object_event.c conf: Update format strings in translated messages 2023-04-01 11:40:32 +02:00
object_event.h conf: Remove unused includes 2022-06-16 06:43:56 +02:00
secret_conf.c conf: Update format strings in translated messages 2023-04-01 11:40:32 +02:00
secret_conf.h conf: secret: Provide only virSecretDefParse 2022-10-06 10:54:24 +02:00
secret_event.c
secret_event.h conf: Remove unused includes 2022-06-16 06:43:56 +02:00
snapshot_conf_priv.h
snapshot_conf.c lib: Replace xmlKeepBlanksDefault() with virXMLParseWithIndent() 2023-11-21 14:43:39 +01:00
snapshot_conf.h virDomainSnapshotAlignDisks: Allow overriding user-configured snapshot default 2023-08-22 16:06:08 +02:00
storage_adapter_conf.c conf: Move error messages onto a single line 2023-09-04 09:35:35 +02:00
storage_adapter_conf.h
storage_capabilities.c conf: Remove unused includes 2022-06-16 06:43:56 +02:00
storage_capabilities.h
storage_conf.c conf: storage: remove redundant condition 2023-04-20 17:28:34 +02:00
storage_conf.h conf: storage: Add support for validating storage vol XML to virStorageVolDefParse 2022-11-01 13:07:20 +01:00
storage_encryption_conf.c conf: Update format strings in translated messages 2023-04-01 11:40:32 +02:00
storage_encryption_conf.h qemu: add luks-any encryption support for RBD images 2023-03-16 15:19:36 +01:00
storage_event.c
storage_event.h conf: Remove unused includes 2022-06-16 06:43:56 +02:00
storage_source_conf.c conf: Rename 'nodeformat' field of virStorageSource to 'nodenameformat' 2023-10-17 14:16:18 +02:00
storage_source_conf.h virStorageSource: Use proper type for shadow copies of iomode/cachemode/discard/detect_zeroes 2023-10-26 09:02:23 +02:00
virchrdev.c conf: Update format strings in translated messages 2023-04-01 11:40:32 +02:00
virchrdev.h
virconftypes.h conf: Move definition of some disk type enums to a common header 2023-10-26 09:02:23 +02:00
virdomaincheckpointobjlist.c conf: Remove unused includes 2022-06-16 06:43:56 +02:00
virdomaincheckpointobjlist.h conf: Remove unused includes 2022-06-16 06:43:56 +02:00
virdomainjob.c conf: Move error messages onto a single line 2023-09-04 09:35:35 +02:00
virdomainjob.h qemu: Remember failed post-copy migration in job 2023-01-06 16:17:38 +01:00
virdomainmomentobjlist.c virdomainmomentobjlist: introduce virDomainMomentIsAncestor 2023-08-22 16:06:32 +02:00
virdomainmomentobjlist.h virdomainmomentobjlist: introduce virDomainMomentIsAncestor 2023-08-22 16:06:32 +02:00
virdomainobjlist.c conf: Save translated disk definition for disk type='volume' to status XML 2023-10-17 14:16:15 +02:00
virdomainobjlist.h conf: virdomainobjlist: Remove return value from virDomainObjListCollect 2023-01-06 15:27:52 +01:00
virdomainsnapshotobjlist.c conf: Remove unused includes 2022-06-16 06:43:56 +02:00
virdomainsnapshotobjlist.h conf: Remove unused includes 2022-06-16 06:43:56 +02:00
virinterfaceobj.c util: remove virObjectUnref() adapters 2022-07-15 16:44:39 -05:00
virinterfaceobj.h virInterfaceObjListAssignDef: Transfer definition ownership 2021-11-24 13:12:20 +01:00
virnetworkobj.c Add virNetworkObj Get and Set Methods for Metadata 2023-08-25 12:36:37 +02:00
virnetworkobj.h Add virNetworkObj Get and Set Methods for Metadata 2023-08-25 12:36:37 +02:00
virnetworkportdef.c conf: Update format strings in translated messages 2023-04-01 11:40:32 +02:00
virnetworkportdef.h conf: networkportdef: Provide only virNetworkPortDefParse 2022-10-06 10:54:24 +02:00
virnodedeviceobj.c conf: Update format strings in translated messages 2023-04-01 11:40:32 +02:00
virnodedeviceobj.h virnodedeviceobj: export virNodeDeviceObjHasCap 2022-03-17 10:57:17 +01:00
virnwfilterbindingdef.c conf: Update format strings in translated messages 2023-04-01 11:40:32 +02:00
virnwfilterbindingdef.h conf: nwfilterbinding: Provide only virNWFilterBindingDefParse 2022-10-06 10:54:24 +02:00
virnwfilterbindingobj.c conf: Update format strings in translated messages 2023-04-01 11:40:32 +02:00
virnwfilterbindingobj.h virNWFilterBindingObjParse: Refactor XML parsing code 2022-10-06 10:54:24 +02:00
virnwfilterbindingobjlist.c conf: Update format strings in translated messages 2023-04-01 11:40:32 +02:00
virnwfilterbindingobjlist.h
virnwfilterobj.c conf: Update format strings in translated messages 2023-04-01 11:40:32 +02:00
virnwfilterobj.h virNWFilterDriverState: Destroy mutex safely 2022-04-08 16:43:16 +02:00
virsavecookie.c conf: savecookie: Remove virSaveCookieParseNode 2022-10-06 10:54:25 +02:00
virsavecookie.h
virsecretobj.c virSecretLoad: Simplify cleanup path 2023-10-17 08:32:24 +02:00
virsecretobj.h conf: Remove unused includes 2022-06-16 06:43:56 +02:00
virstorageobj.c storage: Fix returning of locked objects from 'virStoragePoolObjListSearch' 2023-07-20 15:24:02 +02:00
virstorageobj.h conf: Remove unused includes 2022-06-16 06:43:56 +02:00