mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-09-24 00:20:53 +00:00
3e2c3d8f6d
No thanks to 64-bit windows, with 64-bit pid_t, we have to avoid constructs like 'int pid'. Our API in libvirt-qemu cannot be changed without breaking ABI; but then again, libvirt-qemu can only be used on systems that support UNIX sockets, which rules out Windows (even if qemu could be compiled there) - so for all points on the call chain that interact with this API decision, we require a different variable name to make it clear that we audited the use for safety. Adding a syntax-check rule only solves half the battle; anywhere that uses printf on a pid_t still needs to be converted, but that will be a separate patch. * cfg.mk (sc_correct_id_types): New syntax check. * src/libvirt-qemu.c (virDomainQemuAttach): Document why we didn't use pid_t for pid, and validate for overflow. * include/libvirt/libvirt-qemu.h (virDomainQemuAttach): Tweak name for syntax check. * src/vmware/vmware_conf.c (vmwareExtractPid): Likewise. * src/driver.h (virDrvDomainQemuAttach): Likewise. * tools/virsh.c (cmdQemuAttach): Likewise. * src/remote/qemu_protocol.x (qemu_domain_attach_args): Likewise. * src/qemu_protocol-structs (qemu_domain_attach_args): Likewise. * src/util/cgroup.c (virCgroupPidCode, virCgroupKillInternal): Likewise. * src/qemu/qemu_command.c(qemuParseProcFileStrings): Likewise. (qemuParseCommandLinePid): Use pid_t for pid. * daemon/libvirtd.c (daemonForkIntoBackground): Likewise. * src/conf/domain_conf.h (_virDomainObj): Likewise. * src/probes.d (rpc_socket_new): Likewise. * src/qemu/qemu_command.h (qemuParseCommandLinePid): Likewise. * src/qemu/qemu_driver.c (qemudGetProcessInfo, qemuDomainAttach): Likewise. * src/qemu/qemu_process.c (qemuProcessAttach): Likewise. * src/qemu/qemu_process.h (qemuProcessAttach): Likewise. * src/uml/uml_driver.c (umlGetProcessInfo): Likewise. * src/util/virnetdev.h (virNetDevSetNamespace): Likewise. * src/util/virnetdev.c (virNetDevSetNamespace): Likewise. * tests/testutils.c (virtTestCaptureProgramOutput): Likewise. * src/conf/storage_conf.h (_virStoragePerms): Use mode_t, uid_t, and gid_t rather than int. * src/security/security_dac.c (virSecurityDACSetOwnership): Likewise. * src/conf/storage_conf.c (virStorageDefParsePerms): Avoid compiler warning.
66 lines
2.3 KiB
C
66 lines
2.3 KiB
C
/* -*- c -*-
|
|
* qemu_protocol.x: private protocol for communicating between
|
|
* remote_internal driver and libvirtd. This protocol is
|
|
* internal and may change at any time.
|
|
*
|
|
* Copyright (C) 2010-2012 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*
|
|
* Author: Chris Lalancette <clalance@redhat.com>
|
|
*/
|
|
|
|
%#include "internal.h"
|
|
%#include "remote_protocol.h"
|
|
%#include <arpa/inet.h>
|
|
|
|
/*----- Protocol. -----*/
|
|
struct qemu_monitor_command_args {
|
|
remote_nonnull_domain dom;
|
|
remote_nonnull_string cmd;
|
|
unsigned int flags;
|
|
};
|
|
|
|
struct qemu_monitor_command_ret {
|
|
remote_nonnull_string result;
|
|
};
|
|
|
|
|
|
struct qemu_domain_attach_args {
|
|
unsigned int pid_value;
|
|
unsigned int flags;
|
|
};
|
|
|
|
struct qemu_domain_attach_ret {
|
|
remote_nonnull_domain dom;
|
|
};
|
|
|
|
/* Define the program number, protocol version and procedure numbers here. */
|
|
const QEMU_PROGRAM = 0x20008087;
|
|
const QEMU_PROTOCOL_VERSION = 1;
|
|
|
|
enum qemu_procedure {
|
|
/* Each function must have a three-word comment. The first word is
|
|
* whether gendispatch.pl handles daemon, the second whether
|
|
* it handles src/remote.
|
|
* The last argument describes priority of API. There are two accepted
|
|
* values: low, high; Each API that might eventually access hypervisor's
|
|
* monitor (and thus block) MUST fall into low priority. However, there
|
|
* are some exceptions to this rule, e.g. domainDestroy. Other APIs MAY
|
|
* be marked as high priority. If in doubt, it's safe to choose low. */
|
|
QEMU_PROC_MONITOR_COMMAND = 1, /* skipgen skipgen priority:low */
|
|
QEMU_PROC_DOMAIN_ATTACH = 2 /* autogen autogen priority:low */
|
|
};
|