libvirt/src/storage/parthelper.c
Osier Yang df1011ca8e storage: Allow to delete device mapper disk partition
The name convention of device mapper disk is different, and 'parted'
can't be used to delete a device mapper disk partition. e.g.

Name                 Path
-----------------------------------------
3600a0b80005ad1d7000093604cae912fp1 /dev/mapper/3600a0b80005ad1d7000093604cae912fp1

Error: Expecting a partition number.

This patch introduces 'dmsetup' to fix it.

Changes:
  - New function "virIsDevMapperDevice" in "src/utils/utils.c"
  - remove "is_dm_device" in "src/storage/parthelper.c", use
    "virIsDevMapperDevice" instead.
  - Requires "device-mapper" for 'with-storage-disk" in "libvirt.spec.in"
  - Check "dmsetup" in 'configure.ac' for "with-storage-disk"
  - Changes on "src/Makefile.am" to link against libdevmapper
  - New entry for "virIsDevMapperDevice" in "src/libvirt_private.syms"

Changes from v1 to v3:
  - s/virIsDeviceMapperDevice/virIsDevMapperDevice/g
  - replace "virRun" with "virCommand"
  - sort the list of util functions in "libvirt_private.syms"
  - ATTRIBUTE_NONNULL(1) for virIsDevMapperDevice declaration.

e.g.

Name                 Path
-----------------------------------------
3600a0b80005ad1d7000093604cae912fp1 /dev/mapper/3600a0b80005ad1d7000093604cae912fp1

Vol /dev/mapper/3600a0b80005ad1d7000093604cae912fp1 deleted

Name                 Path
-----------------------------------------
2011-02-17 15:29:07 +08:00

177 lines
5.6 KiB
C

/*
* parthelper.c: Helper program to talk to parted with.
*
* This helper exists because parted is GPLv3+, while libvirt is LGPLv2+.
* Thus we can't link to parted in libvirt.so without the combined work
* being GPLv3+. Thus we separate via an external command. NB, this source
* code is still LGPLv2+, but the binary helper is effectively GPLv3+
*
* The existing 'parted' command line tool is also incredibly hard to parse
* in a reliable fashion if merely after a list of partitions & sizes,
* though it is fine for creating partitions.
*
* Copyright (C) 2007-2008, 2010 Red Hat, Inc.
* Copyright (C) 2007-2008 Daniel P. Berrange
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*
* Author: Daniel P. Berrange <berrange@redhat.com>
*/
#include <config.h>
#include <parted/parted.h>
#include <stdio.h>
#include <string.h>
#include <libdevmapper.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <unistd.h>
#include <locale.h>
#include "util.h"
#include "c-ctype.h"
#include "configmake.h"
/* we don't need to include the full internal.h just for this */
#define STREQ(a,b) (strcmp(a,b) == 0)
/* Make the comparisons below fail if your parted headers
are so old that they lack the definition. */
#ifndef PED_PARTITION_PROTECTED
# define PED_PARTITION_PROTECTED 0
#endif
enum diskCommand {
DISK_LAYOUT = 0,
DISK_GEOMETRY
};
int main(int argc, char **argv)
{
PedDevice *dev;
PedDisk *disk;
PedPartition *part;
int cmd = DISK_LAYOUT;
const char *path;
char *canonical_path;
const char *partsep;
if (setlocale(LC_ALL, "") == NULL ||
bindtextdomain(PACKAGE, LOCALEDIR) == NULL ||
textdomain(PACKAGE) == NULL) {
fprintf(stderr, _("%s: initialization failed\n"), argv[0]);
exit(EXIT_FAILURE);
}
if (argc == 3 && STREQ(argv[2], "-g")) {
cmd = DISK_GEOMETRY;
} else if (argc != 2) {
fprintf(stderr, _("syntax: %s DEVICE [-g]\n"), argv[0]);
return 1;
}
path = argv[1];
if (virIsDevMapperDevice(path)) {
partsep = "p";
canonical_path = strdup(path);
if (canonical_path == NULL) {
return 2;
}
} else {
if (virFileResolveLink(path, &canonical_path) != 0) {
return 2;
}
partsep = *canonical_path &&
c_isdigit(canonical_path[strlen(canonical_path)-1]) ? "p" : "";
}
if ((dev = ped_device_get(path)) == NULL) {
fprintf(stderr, _("unable to access device %s\n"), path);
return 2;
}
/* return the geometry of the disk and then exit */
if(cmd == DISK_GEOMETRY) {
printf("%d%c%d%c%d%c",
dev->hw_geom.cylinders, '\0',
dev->hw_geom.heads, '\0',
dev->hw_geom.sectors, '\0');
return 0;
}
if ((disk = ped_disk_new(dev)) == NULL) {
fprintf(stderr, _("unable to access disk %s\n"), argv[1]);
return 2;
}
/* Get the first partition, and then iterate over all */
part = ped_disk_next_partition(disk, NULL);
while (part) {
const char *type;
const char *content;
if (part->type & PED_PARTITION_LOGICAL) {
type = "logical";
if (part->type & PED_PARTITION_FREESPACE)
content = "free";
else if (part->type & PED_PARTITION_METADATA)
content = "metadata";
else if (part->type & PED_PARTITION_PROTECTED)
content = "protected";
else
content = "data";
} else if (part->type == PED_PARTITION_EXTENDED) {
type = "extended";
content = "metadata";
} else {
type = "normal";
if (part->type & PED_PARTITION_FREESPACE)
content = "free";
else if (part->type & PED_PARTITION_METADATA)
content = "metadata";
else if (part->type & PED_PARTITION_PROTECTED)
content = "protected";
else
content = "data";
}
/* We do +1 on geom.end, because we want end of the last sector
* in bytes, not the last sector number
*/
if (part->num != -1) {
printf("%s%s%d%c%s%c%s%c%llu%c%llu%c%llu%c",
canonical_path, partsep,
part->num, '\0',
type, '\0',
content, '\0',
part->geom.start * 512llu, '\0',
(part->geom.end + 1 ) * 512llu, '\0',
part->geom.length * 512llu, '\0');
} else {
printf("%s%c%s%c%s%c%llu%c%llu%c%llu%c",
"-", '\0',
type, '\0',
content, '\0',
part->geom.start * 512llu, '\0',
(part->geom.end + 1 ) * 512llu, '\0',
part->geom.length * 512llu, '\0');
}
part = ped_disk_next_partition(disk, part);
}
return 0;
}