External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-27 16:15:23 +00:00
Code Issues Packages Projects Releases Wiki Activity
aaf2992d90
libvirt/src/qemu
History
Nikolay Shirokovskiy aaf2992d90 qemu: agent: fix unsafe agent access 
qemuDomainObjExitAgent is unsafe.

First it accesses domain object without domain lock.
Second it uses outdated logic that goes back to commit 79533da1 of
year 2009 when code was quite different. (unref function
instead of unreferencing only unlocked and disposed object
in case of last reference and leaved unlocking to the caller otherwise).
Nowadays this logic may lead to disposing locked object
i guess.

Another problem is that the callers of qemuDomainObjEnterAgent
use domain object again (namely priv->agent) without domain lock.

This patch address these two problems.

qemuDomainGetAgent is dropped as unused.
2016-11-23 11:31:28 +03:00
..
EVENTHANDLERS.txt qemu: add short document on qemu event handlers 2014-10-06 13:50:57 -04:00
libvirtd_qemu.aug qemu: conf: add option for tuning debug logging level 2016-11-09 16:52:40 +01:00
MIGRATION.txt
qemu_agent.c qemu: agent: give better error messages whe agent monitor is down 2016-09-20 16:27:58 +02:00
qemu_agent.h qemu: agent: Make setting of vcpus more robust 2016-06-22 09:26:08 +02:00
qemu_alias.c qemu: Generate memory device aliases according to slot number 2016-11-10 17:36:55 +01:00
qemu_alias.h qemu: Generate memory device aliases according to slot number 2016-11-10 17:36:55 +01:00
qemu_blockjob.c conf: add caps to virDomainObjFormat/SaveStatus 2016-02-05 10:57:08 +00:00
qemu_blockjob.h qemu: Use domain condition for synchronous block jobs 2015-06-19 15:15:10 +02:00
qemu_capabilities.c cpu: Rename cpuGetModels 2016-11-15 15:49:15 +01:00
qemu_capabilities.h qemu: Remove erroneously placed comments for numerical ordering 2016-11-10 10:55:31 -05:00
qemu_capspriv.h qemu: Store loaded QEMU binary ctime in qemuCaps 2016-11-04 09:25:58 +01:00
qemu_cgroup.c Cleanup switch statements on the hostdev subsystem type 2016-11-11 16:58:56 -05:00
qemu_cgroup.h qemu: Add missing 'p' to qemuCgrouEmulatorAllNodesRestore 2016-09-13 12:24:02 +02:00
qemu_command.c Refactoring: Use virHostdevIsSCSIDevice() 2016-11-22 14:37:36 +01:00
qemu_command.h qemu: command: Add debug option for gluster volumes 2016-11-09 16:52:40 +01:00
qemu_conf.c Refactoring: Use virHostdevIsSCSIDevice() 2016-11-22 14:37:36 +01:00
qemu_conf.h qemu: conf: add option for tuning debug logging level 2016-11-09 16:52:40 +01:00
qemu_domain_address.c qemu: initially reserve one open pcie-root-port for hotplug 2016-11-14 14:23:48 -05:00
qemu_domain_address.h qemu: set/use proper pciConnectFlags during hotplug 2016-11-14 14:09:10 -05:00
qemu_domain.c qemu: agent: fix unsafe agent access 2016-11-23 11:31:28 +03:00
qemu_domain.h qemu: agent: fix unsafe agent access 2016-11-23 11:31:28 +03:00
qemu_driver.c qemu: agent: fix unsafe agent access 2016-11-23 11:31:28 +03:00
qemu_driver.h Change file names in comments to match the files they are in 2014-03-10 14:26:04 +01:00
qemu_hostdev.c Use virDirOpenQuiet 2016-06-24 14:20:57 +02:00
qemu_hostdev.h qemu: hostdev: Introduce qemuHostdevUpdateActiveDomainDevices() 2015-10-26 13:50:35 +01:00
qemu_hotplug.c qemu: set/use proper pciConnectFlags during hotplug 2016-11-14 14:09:10 -05:00
qemu_hotplug.h qemu: Add support for hot/cold-(un)plug of shmem devices 2016-11-02 17:36:50 +01:00
qemu_hotplugpriv.h qemu: Let tests override waiting time for device unplug 2013-08-26 16:09:55 +02:00
qemu_interface.c qemu: set tap device online for type='ethernet' 2016-08-25 18:54:01 -04:00
qemu_interface.h autocreate tap device for ethernet network type 2016-03-23 11:37:59 +00:00
qemu_migration.c qemu: agent: handle agent connection errors in one place 2016-11-23 11:14:11 +03:00
qemu_migration.h qemu: Implement auto convergence migration parameters 2016-06-22 15:54:21 +02:00
qemu_monitor_json.c qemu: monitor: Extract qemu cpu id along with other data 2016-11-21 17:19:48 +01:00
qemu_monitor_json.h qemu: monitor: Add code to retrieve and store QMP schema data 2016-11-09 16:50:32 +01:00
qemu_monitor_text.c qemu: monitor: Extract qemu cpu id along with other data 2016-11-21 17:19:48 +01:00
qemu_monitor_text.h qemu: monitor: Return struct from qemuMonitor(Text|Json)QueryCPUs 2016-08-24 15:44:47 -04:00
qemu_monitor.c qemu: monitor: Properly propagate the 'qemu_id' field through the matcher 2016-11-22 10:44:17 +01:00
qemu_monitor.h qemu: monitor: Extract halted state to a bitmap indexed by cpu id 2016-11-21 17:19:48 +01:00
qemu_parse_command.c qemu: process: Set current vcpu count to maximum if it was not specified 2016-11-21 14:35:20 +01:00
qemu_parse_command.h qemu: parse: rename qemuCaps->caps 2016-02-19 09:45:23 -05:00
qemu_process.c qemu: drop write-only agentStart 2016-11-23 11:31:14 +03:00
qemu_process.h qemu: Use proper async job to refresh virtio channels 2016-06-30 09:41:39 +02:00
qemu_processpriv.h qemu: Export qemuProcessHandleDeviceDeleted for tests 2013-08-26 16:09:55 +02:00
qemu.conf tests: Adapt to gluster_debug_level in qemu.conf 2016-11-21 10:50:48 +01:00
test_libvirtd_qemu.aug.in tests: Adapt to gluster_debug_level in qemu.conf 2016-11-21 10:50:48 +01:00
THREADS.txt There is no virDomainFindBy{ID, Name, UUID} anymore 2015-08-03 13:08:00 +02:00