libvirt/tests
Daniel Henrique Barboza bbbf774fb2 tests/qemuxml2*/graphics-spice-timeout: skip CPU model check
Commit 65b0b746b5 changed spice tests to use latest caps. Before this
change, "FLAG_REAL_CAPS" wasn't being set in testQemuInfoInitArgs(). The
absence of this flag triggered the code path inside
testCompareXMLToArgv() that executed testUpdateQEMUCaps(). This function
will update the host CPU via virQEMUCapsUpdateHostCPUModel() into
virQEMUCapsInitHostCPUModel(). In this function,
virQEMUCapsInitCPUModel() would end up updating the hostCPU inside the
qemuCaps (via virQEMUCapsProbeHostCPU()). Before the forementioned
commit, the host CPU was being defaulted to x86_64, vendor Intel, for
the 'graphics-spice-timeout' test that is using the 'pc' machine type
and 'accel=kvm'.

Today, "FLAG_REAL_CAPS" is being set because we're using the latest caps
from x86_64. This means that the whole code path mentioned above is
skipped. qemuCaps are now being loaded via virQEMUCapsLoadCache()
directly. Without the handling being done by testUpdateQEMUCaps(), the
host CPU is being retrieved later on, down below
qemuProcessCreatePretendCmdPrepare() into qemuProcessUpdateGuestCPU().
The latter will attempt to update the domain cpu and executing a
virCPUCompare with the hostCPU and def->cpu.

All this logic ended up causing a failure of the
'graphics-spice-timeout' test in ppc64 and s390x hosts. This test is
being run with KVM acceleration, and the KVM driver for ppc64 and s390x
will return a default x86_64 CPU with vendor "AMD", making
virCPUCompare() fail with the following message:

"QEMU XML-2-ARGV graphics-spice-timeout.x86_64-latest   ... libvirt: CPU
Driver error : the CPU is incompatible with host CPU: host CPU vendor does
not match required CPU vendor Intel"

Fix this test by setting cpu check='none' and avoid the virCPUCompare()
that causes the problem for ppc64 and s390x hosts.

Note that this is a build fix. A more adequate fix would be to mock the
getHost() interface of the cpuDriverX86 for non-x86 hosts, allowing
'fullCPU' to be retrieved in qemuProcessUpdateGuestCPU(), and a proper
x86 CPU to be retrieved in the scenario described above.

Reported-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
2021-11-17 22:47:21 -03:00
..
bhyveargv2xmldata
bhyvefirmwaredata
bhyvexml2argvdata
bhyvexml2xmloutdata
capabilityschemadata
commanddata
cputestdata
domainbackupxml2xmlin
domainbackupxml2xmlout
domaincapsdata tests: update QEMU and domain ppc64 capabilities for qemu 6.2 2021-11-12 13:44:42 -03:00
domainconfdata
domainschemadata
fchostdata/fc_host
genericxml2xmlindata
genericxml2xmloutdata
interfaceschemadata
libxlxml2domconfigdata
lxcconf2xmldata
lxcxml2xmldata
lxcxml2xmloutdata
networkxml2confdata
networkxml2firewalldata
networkxml2xmlin
networkxml2xmlout
networkxml2xmlupdatein
networkxml2xmlupdateout
nodedevmdevctldata
nodedevschemadata Add PCI VPD Capability Support 2021-10-21 17:34:04 +01:00
nodedevxml2xmlout Add PCI VPD Capability Support 2021-10-21 17:34:04 +01:00
nssdata
nwfilterxml2firewalldata
nwfilterxml2xmlin
nwfilterxml2xmlout
qemuagentdata
qemublocktestdata qemublocktest: Add test for creating a qcow2 on top of an luks-encrypted qcow2 2021-08-20 15:43:17 +02:00
qemucapabilitiesdata tests: update QEMU and domain ppc64 capabilities for qemu 6.2 2021-11-12 13:44:42 -03:00
qemucaps2xmloutdata
qemudomaincheckpointxml2xmlin
qemudomaincheckpointxml2xmlout
qemudomainsnapshotxml2xmlin
qemudomainsnapshotxml2xmlout
qemufirmwaredata
qemuhotplugtestcpus qemuhotplugtest: Remove tests for legacy cpu hotplug on x86 2021-11-01 16:14:53 +01:00
qemuhotplugtestdevices
qemuhotplugtestdomains
qemumemlockdata
qemumigparamsdata qemumigparamstest: Drop "unsupported" test case 2021-10-22 07:00:44 +02:00
qemumigrationcookiexmldata
qemumonitorjsondata
qemusecuritydata
qemustatusxml2xmldata qemustatusxml2xmldata: backup-pull: Add private data for scratch image 2021-11-04 10:55:28 +01:00
qemuvhostuserdata
qemuxml2argvdata tests/qemuxml2*/graphics-spice-timeout: skip CPU model check 2021-11-17 22:47:21 -03:00
qemuxml2xmloutdata tests/qemuxml2*/graphics-spice-timeout: skip CPU model check 2021-11-17 22:47:21 -03:00
secretxml2xmlin
securityselinuxhelperdata
securityselinuxlabeldata
storagepoolcapsschemadata
storagepoolschemadata
storagepoolxml2argvdata
storagepoolxml2xmlin
storagepoolxml2xmlout
storagevolschemadata
storagevolxml2argvdata
storagevolxml2xmlin
storagevolxml2xmlout
sysinfodata
vboxsnapshotxmldata
vircaps2xmldata
vircgroupdata
virconfdata Add suggestions for virt-pki-query-dn usage 2021-11-12 12:37:29 +01:00
virfilecachedata
virfiledata
virhostcpudata
virjsondata
virmacmaptestdata
virnetdaemondata
virnetdevopenvswitchdata
virnetdevtestdata/sys/class/net
virnetworkportxml2xmldata
virnwfilterbindingxml2xmldata
virpcitestdata
virresctrldata
virscsidata
virstoragetestdata
virstorageutildata
virusbtestdata/sys_bus_usb/devices
vmwareverdata
vmx2xmldata
xlconfigdata
xmconfigdata
xml2vmxdata
.valgrind.supp
bhyveargv2xmlmock.c
bhyveargv2xmltest.c
bhyvexml2argvmock.c lib: Drop intermediary return variables 2021-10-25 12:48:46 +02:00
bhyvexml2argvtest.c
bhyvexml2xmltest.c
commandhelper.c
commandtest.c
cputest.c
domaincapsmock.c virhostmem: Introduce virHostMemGetTHPSize() 2021-10-01 10:58:27 +02:00
domaincapstest.c fillXenCaps: Cleanup 2021-11-08 14:32:32 +01:00
domainconftest.c
esxutilstest.c
eventtest.c
fchosttest.c
fdstreamtest.c
genericxml2xmltest.c virDomainBackupDefFormat: Propagate private data callbacks 2021-11-04 10:55:28 +01:00
interfacexml2xmltest.c lib: Introduce and use g_autoptr() for virInterfaceDef 2021-11-02 10:52:18 +01:00
libvirtd-fail
libvirtd-pool
libxlmock.c
libxlxml2domconfigtest.c
lxcconf2xmltest.c
lxcxml2xmltest.c
meson.build Add a PCI/PCIe device VPD Parser 2021-10-21 17:34:04 +01:00
metadatatest.c
networkxml2conftest.c
networkxml2firewalltest.c
networkxml2xmltest.c
networkxml2xmlupdatetest.c
nodedevmdevctltest.c
nodedevxml2xmltest.c Add PCI VPD Capability Support 2021-10-21 17:34:04 +01:00
nsslinktest.c
nssmock.c
nsstest.c
nwfilterebiptablestest.c
nwfilterxml2firewalltest.c
nwfilterxml2xmltest.c
objecteventtest.c objecteventtest: Don't overwrite @ret on failure 2021-10-18 12:09:33 +02:00
openvzutilstest.c
openvzutilstest.conf
permitted_file_access.txt
pkix_asn1_tab.c
qemuagenttest.c tests: Drop cleanup/error labels 2021-11-11 16:16:30 +01:00
qemublocktest.c qemublocktest: Replace virJSONValueObjectCreate by virJSONValueObjectAdd 2021-11-17 12:04:11 +01:00
qemucapabilitiestest.c tests: Drop cleanup/error labels 2021-11-11 16:16:30 +01:00
qemucaps2xmlmock.c
qemucaps2xmltest.c
qemucapsfixreplies
qemucapsprobe.c qemu: Invalidate capabilities cache on host cpuid mismatch 2021-11-05 17:12:25 +01:00
qemucapsprobemock.c
qemucommandutiltest.c
qemucpumock.c
qemudomaincheckpointxml2xmltest.c
qemudomainsnapshotxml2xmltest.c
qemufirmwaretest.c
qemuhotplugmock.c
qemuhotplugtest.c tests: Use g_autoptr(qemuMonitorTest) 2021-11-11 16:16:26 +01:00
qemumemlocktest.c
qemumigparamstest.c tests: Drop cleanup/error labels 2021-11-11 16:16:30 +01:00
qemumigrationcookiexmltest.c testQEMUSchemaValidateCommand: Add possibility for partial QMP validation 2021-10-18 14:00:58 +02:00
qemumonitorjsontest.c tests: Drop cleanup/error labels 2021-11-11 16:16:30 +01:00
qemumonitortestutils.c tests: Drop cleanup/error labels 2021-11-11 16:16:30 +01:00
qemumonitortestutils.h
qemusecuritymock.c lib: Drop intermediary return variables 2021-10-25 12:48:46 +02:00
qemusecuritytest.c
qemusecuritytest.h
qemustatusxml2xmltest.c
qemuvhostusertest.c
qemuxml2argvmock.c lib: Drop intermediary return variables 2021-10-25 12:48:46 +02:00
qemuxml2argvtest.c qemu_command: do not use host-nodes for system memory 2021-11-10 11:17:44 +01:00
qemuxml2xmltest.c tests: qemuxml2xml: use latest caps for spice tests 2021-11-04 14:37:15 +01:00
scsihosttest.c
seclabeltest.c
secretxml2xmltest.c
securityselinuxhelper.c
securityselinuxlabeltest.c
securityselinuxtest.c
shunloadhelper.c
shunloadtest.c
sockettest.c
ssh.c
storagebackendsheepdogtest.c tests: Use g_strdup_printf() instead of virAsprintf() 2019-11-12 16:15:59 +01:00
storagepoolcapstest.c
storagepoolxml2argvtest.c
storagepoolxml2xmltest.c
storagevolxml2argvtest.c
storagevolxml2xmltest.c
sysinfotest.c
test-lib.sh
testutils.c lib: Don't check for virCapabilitiesAddGuestDomain() retval 2021-11-01 16:08:26 +01:00
testutils.h Add a PCI/PCIe device VPD Parser 2021-10-21 17:34:04 +01:00
testutilshostcpus.h
testutilslxc.c testLXCCapsInit: Cleanup 2021-11-08 14:32:32 +01:00
testutilslxc.h
testutilsqemu.c lib: Don't check for virCapabilitiesAddGuestDomain() retval 2021-11-01 16:08:26 +01:00
testutilsqemu.h
testutilsqemuschema.c testQEMUSchemaValidateEnum: Validate deprecated members 2021-11-01 17:37:15 +01:00
testutilsqemuschema.h testQEMUSchemaValidateCommand: Add possibility for partial QMP validation 2021-10-18 14:00:58 +02:00
testutilsxen.c lib: Don't check for virCapabilitiesAddGuestDomain() retval 2021-11-01 16:08:26 +01:00
testutilsxen.h
utiltest.c
vboxsnapshotxmltest.c Prefer g_auto(GStrv) over g_strfreev() 2021-11-11 16:16:17 +01:00
viralloctest.c
virauthconfigtest.c
virbitmaptest.c
virbuftest.c
vircaps2xmltest.c
vircapstest.c
vircgroupmock.c
vircgrouptest.c
virconftest.c Prefer g_auto(GStrv) over g_strfreev() 2021-11-11 16:16:17 +01:00
vircryptotest.c
virdriverconnvalidatetest.c
virdrivermoduletest.c
virendiantest.c
virerrortest.c
virfilecachemock.c
virfilecachetest.c
virfilemock.c
virfiletest.c Prefer g_auto(GStrv) over g_strfreev() 2021-11-11 16:16:17 +01:00
virfilewrapper.c
virfilewrapper.h
virfirewallmock.c
virfirewalltest.c
virgdbusmock.c
virhostcpumock.c
virhostcputest.c
virhostdevmock.c
virhostdevtest.c
virhostidmock.c
viridentitytest.c
viriscsitest.c
virjsontest.c virjsontest: Replace virJSONValueObjectCreate by virJSONValueObjectAdd 2021-11-17 12:04:11 +01:00
virkeycodetest.c
virkmodtest.c tests: vir: remove pointless labels 2021-09-09 18:06:13 +02:00
virlockspacetest.c
virlogtest.c
virmacmaptest.c
virmigtest.c
virmock.h
virmockstathelpers.c
virnetdaemonmock.c
virnetdaemontest.c
virnetdevbandwidthmock.c
virnetdevbandwidthtest.c
virnetdevmock.c
virnetdevopenvswitchtest.c virnetdevopenvswitch: unify calculation of ovs and tc 2021-11-01 15:56:47 +01:00
virnetdevtest.c tests: remove unneeded cleanup labels 2019-11-19 15:22:43 +01:00
virnetmessagetest.c
virnetserverclientmock.c
virnetserverclienttest.c lib: Drop intermediary return variables 2021-10-25 12:48:46 +02:00
virnetsockettest.c virnetsocket: Don't free virCommand in virNetSocketNewConnectCommand() 2021-10-15 16:03:22 +02:00
virnettlscontexttest.c
virnettlshelpers.c
virnettlshelpers.h
virnettlssessiontest.c
virnetworkportxml2xmltest.c
virnumamock.c
virnwfilterbindingxml2xmltest.c
virpcimock.c lib: Use G_N_ELEMENTS instead of sizeof()/sizeof() 2021-11-03 14:46:54 +01:00
virpcitest.c Add PCI VPD-related helper functions to virpci 2021-10-21 17:34:04 +01:00
virpcivpdtest.c lib: Use G_N_ELEMENTS instead of sizeof()/sizeof() 2021-11-03 14:46:54 +01:00
virpolkittest.c
virportallocatormock.c
virportallocatortest.c
virprocessmock.c
virrandommock.c
virresctrltest.c
virrotatingfiletest.c
virschematest.c
virscsitest.c
virsh-auth
virsh-auth.xml
virsh-checkpoint
virsh-cpuset
virsh-define-dev-segfault
virsh-int-overflow tests: consistently source test-lib.sh in scripts 2016-04-23 15:41:40 -04:00
virsh-optparse
virsh-output
virsh-output-commands
virsh-output.out
virsh-read-bufsiz
virsh-read-non-seekable
virsh-schedinfo
virsh-self-test
virsh-snapshot
virsh-start
virsh-undefine
virsh-uriprecedence tests: Avoid writing into $HOME during virsh-snapshot 2019-04-04 09:35:40 -05:00
virsh-vcpupin
virshtest.c
virstoragetest.c
virstorageutiltest.c
virstringtest.c Prefer g_auto(GStrv) over g_strfreev() 2021-11-11 16:16:17 +01:00
virsystemdtest.c
virt-aa-helper-test
virt-admin-self-test
virtestmock.c
virtimetest.c
virtypedparamtest.c
viruritest.c
virusbmock.c lib: Drop intermediary return variables 2021-10-25 12:48:46 +02:00
virusbtest.c
vmwarevertest.c
vmx2xmltest.c lib: Don't check for virCapabilitiesAddGuestDomain() retval 2021-11-01 16:08:26 +01:00
vshtabletest.c testVshTableHeader: Cleanup 2021-11-08 14:32:32 +01:00
xlconfigtest.c
xmconfigtest.c
xml2vmxtest.c lib: Don't check for virCapabilitiesAddGuestDomain() retval 2021-11-01 16:08:26 +01:00