libvirt/src/util
Eric Blake b43efdaa13 maint: avoid 'const fooPtr' in hashes
'const fooPtr' is the same as 'foo * const' (the pointer won't
change, but it's contents can).  But in general, if an interface
is trying to be const-correct, it should be using 'const foo *'
(the pointer is to data that can't be changed).

Fix up virhash to provide a const-correct interface: all actions
that don't modify the table take a const table.  Note that in
one case (virHashSearch), we actually strip const away - we aren't
modifying the contents of the table, so much as associated data
for ensuring that the code uses the table correctly (if this were
C++, it would be a case for the 'mutable' keyword).

* src/util/virhash.h (virHashKeyComparator, virHashEqual): Use
intended type.
(virHashSize, virHashTableSize, virHashLookup, virHashSearch):
Make const-correct.
* src/util/virhash.c (virHashEqualData, virHashEqual)
(virHashLookup, virHashSize, virHashTableSize, virHashSearch)
(virHashComputeKey): Fix fallout.
* src/conf/nwfilter_params.c
(virNWFilterFormatParameterNameSorter): Likewise.
* src/nwfilter/nwfilter_ebiptables_driver.c
(ebiptablesFilterOrderSort): Likewise.
* tests/virhashtest.c (testHashGetItemsCompKey)
(testHashGetItemsCompValue): Likewise.

Signed-off-by: Eric Blake <eblake@redhat.com>
2013-10-14 11:40:24 -06:00
..
iohelper.c Adapt to VIR_ALLOC and virAsprintf in src/util/* 2013-07-10 11:07:33 +02:00
keymaps.csv
viralloc.c Fix reporting of errors in OOM injection code 2013-09-24 10:52:26 +01:00
viralloc.h viralloc: Report OOM error on failure 2013-07-10 11:07:31 +02:00
virarch.c Add ARM v7 big-endian architecture (armv7b) 2013-09-09 10:39:28 +01:00
virarch.h Add ARM v7 big-endian architecture (armv7b) 2013-09-09 10:39:28 +01:00
viratomic.c
viratomic.h
viraudit.c virutil: Move string related functions to virstring.c 2013-05-02 16:56:55 +02:00
viraudit.h
virauth.c virAuth: Don't require virConnectPtr to retrieve authentication creds 2013-07-12 09:22:38 +02:00
virauth.h virAuth: Don't require virConnectPtr to retrieve authentication creds 2013-07-12 09:22:38 +02:00
virauthconfig.c Adapt to VIR_ALLOC and virAsprintf in src/util/* 2013-07-10 11:07:33 +02:00
virauthconfig.h
virbitmap.c virBitmapParse: Fix behavior in case of error and fix up callers 2013-08-22 11:38:36 +02:00
virbitmap.h util: Add a helper to check if all bits of a bitmap are clear 2013-04-06 10:14:21 +08:00
virbuffer.c viralloc: Report OOM error on failure 2013-07-10 11:07:31 +02:00
virbuffer.h util: switch virBufferTrim to void 2013-06-19 09:21:09 +02:00
vircgroup.c cgroup: fix a comment typo in vircgroup.c 2013-10-09 17:16:58 +02:00
vircgroup.h cgroup: Move [qemu|lxc]GetCpuBWStatus to vicgroup.c and refactor it 2013-09-16 11:32:49 +02:00
vircgrouppriv.h Track symlinks for co-mounted cgroup controllers 2013-04-15 17:35:32 +01:00
virclosecallbacks.c lxc: switch to virCloseCallbacks API 2013-07-18 14:16:54 +02:00
virclosecallbacks.h lxc: switch to virCloseCallbacks API 2013-07-18 14:16:54 +02:00
vircommand.c Don't ignore allocation failure in virCommandAddEnvPassCommon 2013-09-24 10:52:58 +01:00
vircommand.h Merge virCommandPreserveFD / virCommandTransferFD 2013-07-18 12:18:24 +01:00
virconf.c Fix leak of comment string if virConfAddEntry fails on OOM 2013-09-25 18:12:09 +01:00
virconf.h Rename conf.{c,h} to virconf.{c,h} 2012-12-21 11:17:13 +00:00
virdbus.c Don't ignore all dbus connection errors 2013-10-14 10:33:10 +01:00
virdbus.h Add a method for closing the dbus system bus connection 2013-10-14 10:31:01 +01:00
virdbuspriv.h Introduce virDBusCallMethod & virDBusMessageRead methods 2013-07-22 13:09:58 +01:00
virdnsmasq.c Convert 'int i' to 'size_t i' in src/util/ files 2013-07-10 17:40:13 +01:00
virdnsmasq.h use client id for IPv6 DHCP host definition 2013-02-25 02:49:06 -05:00
virebtables.c Convert 'int i' to 'size_t i' in src/util/ files 2013-07-10 17:40:13 +01:00
virebtables.h Adapt to VIR_STRDUP and VIR_STRNDUP in src/util/* 2013-05-24 10:10:03 +02:00
virendian.h util: add virendian.h macros 2013-02-12 09:00:15 -07:00
virerror.c virerror: s/VIR_ERR_STORAGE_VOL_EXISTS/VIR_ERR_STORAGE_VOL_EXISTS/ 2013-10-07 19:21:47 +02:00
virerror.h Add helpers for dealing with system errors 2013-07-22 13:09:58 +01:00
virevent.c docs: fix virEventAddHandle return details 2013-09-18 13:06:13 -06:00
virevent.h Rename event.{c,h} to virevent.{c,h} 2012-12-21 11:17:13 +00:00
vireventpoll.c event: Make debug message match function comments 2013-09-27 11:16:35 -05:00
vireventpoll.h Rename event_poll.{c,h} to vireventpoll.{c,h} 2012-12-21 11:17:13 +00:00
virfile.c virfile: safezero: fix buffer allocation max size 2013-10-04 16:10:27 +02:00
virfile.h Introduce virFilePrintf() as a portable fprintf() 2013-05-31 10:51:33 -06:00
virhash.c maint: avoid 'const fooPtr' in hashes 2013-10-14 11:40:24 -06:00
virhash.h maint: avoid 'const fooPtr' in hashes 2013-10-14 11:40:24 -06:00
virhashcode.c
virhashcode.h
virhook.c Convert 'int i' to 'size_t i' in src/util/ files 2013-07-10 17:40:13 +01:00
virhook.h virutil: Move string related functions to virstring.c 2013-05-02 16:56:55 +02:00
viridentity.c Ensure system identity includes process start time 2013-09-18 15:04:27 +01:00
viridentity.h Also store user & group ID values in virIdentity 2013-09-18 15:04:27 +01:00
virinitctl.c Adapt to VIR_ALLOC and virAsprintf in src/util/* 2013-07-10 11:07:33 +02:00
virinitctl.h
viriptables.c util/viriptables: add/remove rules that short-circuit masquerading 2013-09-25 08:24:09 -04:00
viriptables.h util/viriptables: add/remove rules that short-circuit masquerading 2013-09-25 08:24:09 -04:00
virjson.c Fix leak of parser state in virJSONValueFromString 2013-09-25 18:12:09 +01:00
virjson.h json: support removing a value from an object 2013-05-13 15:15:54 -06:00
virkeycode-mapgen.py Rewrite keycode map to avoid a struct 2013-04-08 10:03:20 +01:00
virkeycode.c Convert 'int i' to 'size_t i' in src/util/ files 2013-07-10 17:40:13 +01:00
virkeycode.h cleanup: Don't include libvirt/libvirt.h 2013-04-17 15:50:53 +08:00
virkeyfile.c Adapt to VIR_ALLOC and virAsprintf in src/util/* 2013-07-10 11:07:33 +02:00
virkeyfile.h
virlockspace.c Fix leak in virLockSpaceResourceFree 2013-09-25 18:12:09 +01:00
virlockspace.h Rename json.{c,h} to virjson.{c,h} 2012-12-21 11:17:13 +00:00
virlog.c Initialize threading & error layer in LXC controller 2013-10-14 12:16:23 +01:00
virlog.h Convert 'int i' to 'size_t i' in src/util/ files 2013-07-10 17:40:13 +01:00
virmacaddr.c Convert 'int i' to 'size_t i' in src/util/ files 2013-07-10 17:40:13 +01:00
virmacaddr.h
virnetdev.c BSD: implement virNetDev(Set|Clear)IPv4Address 2013-08-21 15:49:40 -06:00
virnetdev.h netdev: accept NULL in virNetDevSetupControl 2013-06-21 20:22:07 +02:00
virnetdevbandwidth.c virNetDevBandwidthEqual: Make it more robust 2013-10-02 10:47:22 +02:00
virnetdevbandwidth.h
virnetdevbridge.c build: fix build with latest rawhide kernel headers 2013-09-16 09:24:12 -06:00
virnetdevbridge.h
virnetdevmacvlan.c Convert 'int i' to 'size_t i' in src/util/ files 2013-07-10 17:40:13 +01:00
virnetdevmacvlan.h
virnetdevopenvswitch.c Convert 'int i' to 'size_t i' in src/util/ files 2013-07-10 17:40:13 +01:00
virnetdevopenvswitch.h virutil: Move string related functions to virstring.c 2013-05-02 16:56:55 +02:00
virnetdevtap.c qemu: Handle huge number of queues correctly 2013-09-03 13:38:35 +02:00
virnetdevtap.h qemu: Adapt qemuBuildInterfaceCommandLine to to multiqueue net 2013-05-22 17:24:27 +02:00
virnetdevveth.c Free cmd in virNetDevVethCreate 2013-10-04 12:03:19 +01:00
virnetdevveth.h
virnetdevvlan.c Adapt to VIR_ALLOC and virAsprintf in src/util/* 2013-07-10 11:07:33 +02:00
virnetdevvlan.h Configure native vlan modes on Open vSwitch ports 2013-06-25 00:22:36 -04:00
virnetdevvportprofile.c Move virNetDevVPort enum impl into virnetdevvportprofile.c 2013-10-11 11:45:54 +01:00
virnetdevvportprofile.h Rename uuid.{c,h} to viruuid.{c,h} 2012-12-21 11:19:49 +00:00
virnetlink.c Convert 'int i' to 'size_t i' in src/util/ files 2013-07-10 17:40:13 +01:00
virnetlink.h maint: don't use config.h in .h files 2013-06-05 05:53:25 -06:00
virnodesuspend.c Separate internal node suspend APIs from public API 2013-05-08 10:47:47 +01:00
virnodesuspend.h Separate internal node suspend APIs from public API 2013-05-08 10:47:47 +01:00
virnuma.c Convert 'int i' to 'size_t i' in src/util/ files 2013-07-10 17:40:13 +01:00
virnuma.h NUMA: cleanup for numa related codes 2013-03-20 19:37:00 +08:00
virobject.c Adapt to VIR_ALLOC and virAsprintf in src/util/* 2013-07-10 11:07:33 +02:00
virobject.h build: allow virObject to have no parent 2013-01-22 13:45:38 -07:00
virpci.c cleanup: Kill usage of access(PATH, F_OK) in favor of virFileExists() 2013-09-16 10:37:39 +02:00
virpci.h pci: new iommu_group functions 2013-06-26 14:10:09 -04:00
virpidfile.c virutil: Move string related functions to virstring.c 2013-05-02 16:56:55 +02:00
virpidfile.h
virportallocator.c Convert 'int i' to 'size_t i' in src/util/ files 2013-07-10 17:40:13 +01:00
virportallocator.h Add a port allocator class 2013-01-16 11:02:58 +00:00
virprocess.c Convert 'int i' to 'size_t i' in src/util/ files 2013-07-10 17:40:13 +01:00
virprocess.h Include process start time when doing polkit checks 2013-05-08 10:47:45 +01:00
virrandom.c random: don't mix RAND_MAX with random_r 2013-08-30 06:24:28 -06:00
virrandom.h
virscsi.c virscsi: hostdev SCSI AdapterId retrieval fix 2013-09-30 15:04:46 +02:00
virscsi.h utils: Add a helper to get the device name that sg device mapped to 2013-05-16 23:50:00 +08:00
virsexpr.c Adapt to VIR_ALLOC and virAsprintf in src/util/* 2013-07-10 11:07:33 +02:00
virsexpr.h Rename sexpr.{c,h} to virsexpr.{c,h} 2012-12-21 11:19:48 +00:00
virsocketaddr.c virsocket: Introduce virSocketAddrIsWildcard 2013-10-11 11:05:06 +02:00
virsocketaddr.h virsocket: Introduce virSocketAddrIsWildcard 2013-10-11 11:05:06 +02:00
virstatslinux.c virutil: Move string related functions to virstring.c 2013-05-02 16:56:55 +02:00
virstatslinux.h Rename stats_linux.{c,h} to virstatslinux.{c,h} 2012-12-21 11:19:48 +00:00
virstoragefile.c util: recognize SMB/CIFS filesystems as shared 2013-10-01 05:45:05 -04:00
virstoragefile.h util: recognize SMB/CIFS filesystems as shared 2013-10-01 05:45:05 -04:00
virstring.c util: Non-existent string array does not contain any string 2013-07-19 17:59:47 +02:00
virstring.h virAsprintf: correctly check return value 2013-07-18 14:05:46 +02:00
virsysinfo.c Convert 'int i' to 'size_t i' in src/util/ files 2013-07-10 17:40:13 +01:00
virsysinfo.h Rename util.{c,h} to virutil.{c,h} 2012-12-21 11:19:49 +00:00
virsystemd.c Don't ignore all dbus connection errors 2013-10-14 10:33:10 +01:00
virsystemd.h LXC: workaround machined uncleaned data with containers running systemd. 2013-09-30 16:47:23 +01:00
virthread.c Rename threads.{c,h} to virthread.{c,h} 2012-12-21 11:19:49 +00:00
virthread.h build: avoid non-portable cast of pthread_t 2013-05-03 06:30:22 -06:00
virthreadpool.c Adapt to VIR_ALLOC and virAsprintf in src/util/* 2013-07-10 11:07:33 +02:00
virthreadpool.h Rename threadpool.{c,h} to virthreadpool.{c,h} 2012-12-21 11:19:48 +00:00
virthreadpthread.c viralloc: Report OOM error on failure 2013-07-10 11:07:31 +02:00
virthreadpthread.h Rename threads.{c,h} to virthread.{c,h} 2012-12-21 11:19:49 +00:00
virthreadwin32.c build: fix virthread build on mingw 2013-07-29 08:56:48 -06:00
virthreadwin32.h Convert 'int i' to 'size_t i' in src/util/ files 2013-07-10 17:40:13 +01:00
virtime.c Adapt to VIR_ALLOC and virAsprintf in src/util/* 2013-07-10 11:07:33 +02:00
virtime.h
virtpm.c Adapt to VIR_ALLOC and virAsprintf in src/util/* 2013-07-10 11:07:33 +02:00
virtpm.h Helper functions for host TPM support 2013-04-12 16:55:45 -04:00
virtypedparam.c Convert 'int i' to 'size_t i' in src/util/ files 2013-07-10 17:40:13 +01:00
virtypedparam.h Introduce virTypedParamsCopy internal API 2013-06-25 00:38:25 +02:00
viruri.c Convert 'int i' to 'size_t i' in src/util/ files 2013-07-10 17:40:13 +01:00
viruri.h
virusb.c util: add rebase fix that was accidentally omitted from previous patch 2013-07-10 23:06:43 -04:00
virusb.h Convert virPCIDeviceList and virUSBDeviceList into virObjectLockable 2013-02-05 19:22:26 +00:00
virutil.c util: fix two virCompareLimitUlong bugs 2013-10-11 06:34:18 -06:00
virutil.h util: fix two virCompareLimitUlong bugs 2013-10-11 06:34:18 -06:00
viruuid.c Convert 'int i' to 'size_t i' in src/util/ files 2013-07-10 17:40:13 +01:00
viruuid.h Rename uuid.{c,h} to viruuid.{c,h} 2012-12-21 11:19:49 +00:00
virxml.c conf: allow to add XML metadata using the virDomainSetMetadata api 2013-09-17 09:42:49 +02:00
virxml.h conf: allow to add XML metadata using the virDomainSetMetadata api 2013-09-17 09:42:49 +02:00