mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-11-03 20:01:16 +00:00
94bbbcee1f
There is a race between virNetServerProcessClients (main thread) and
remoteDispatchAuthList/remoteDispatchAuthPolkit/remoteSASLFinish (worker
thread) that can lead to decrementing srv->nclients_unauth when it's
zero. Since virNetServerCheckLimits relies on the value
srv->nclients_unauth the underrun causes libvirtd to stop accepting
new connections forever.
Example race scenario (assuming libvirtd is using policykit and the
client is privileged):
1. The client calls the RPC remoteDispatchAuthList =>
remoteDispatchAuthList is executed on a worker thread (Thread
T1). We're assuming now the execution stops for some time before
the line 'virNetServerClientSetAuth(client, 0)'
2. The client closes the connection irregularly. This causes the
event loop to wake up and virNetServerProcessClient to be
called (on the main thread T0). During the
virNetServerProcessClients the srv lock is hold. The condition
virNetServerClientNeedAuth(client) will be checked and as the
authentication is not finished right now
virNetServerTrackCompletedAuthLocked(srv) will be called =>
--srv->nclients_unauth => 0
3. The Thread T1 continues, marks the client as authenticated, and
calls virNetServerTrackCompletedAuthLocked(srv) =>
--srv->nclients_unauth => --0 => wrap around as nclient_unauth is
unsigned
4. virNetServerCheckLimits(srv) will disable the services forever
To fix it, add an auth_pending field to the client struct so that it
is now possible to determine if the authentication process has already
been handled for this client.
Setting the authentication method to none for the client in
virNetServerProcessClients is not a proper way to indicate that the
counter has been decremented, as this would imply that the client is
authenticated.
Additionally, adjust the existing test cases for this new field.
Signed-off-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
71 lines
1.4 KiB
JSON
71 lines
1.4 KiB
JSON
{
|
|
"servers": {
|
|
"testServer0": {
|
|
"min_workers": 10,
|
|
"max_workers": 50,
|
|
"priority_workers": 5,
|
|
"max_clients": 100,
|
|
"max_anonymous_clients": 10,
|
|
"keepaliveInterval": 120,
|
|
"keepaliveCount": 5,
|
|
"next_client_id": 5,
|
|
"services": [
|
|
{
|
|
"auth": 0,
|
|
"readonly": true,
|
|
"nrequests_client_max": 2,
|
|
"socks": [
|
|
{
|
|
"fd": 100,
|
|
"errfd": -1,
|
|
"pid": 0,
|
|
"isClient": false
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"auth": 2,
|
|
"readonly": false,
|
|
"nrequests_client_max": 5,
|
|
"socks": [
|
|
{
|
|
"fd": 101,
|
|
"errfd": -1,
|
|
"pid": 0,
|
|
"isClient": false
|
|
}
|
|
]
|
|
}
|
|
],
|
|
"clients": [
|
|
{
|
|
"id": 2,
|
|
"auth": 1,
|
|
"auth_pending": true,
|
|
"readonly": true,
|
|
"nrequests_max": 15,
|
|
"sock": {
|
|
"fd": 102,
|
|
"errfd": -1,
|
|
"pid": -1,
|
|
"isClient": true
|
|
}
|
|
},
|
|
{
|
|
"id": 3,
|
|
"auth": 2,
|
|
"auth_pending": true,
|
|
"readonly": true,
|
|
"nrequests_max": 66,
|
|
"sock": {
|
|
"fd": 103,
|
|
"errfd": -1,
|
|
"pid": -1,
|
|
"isClient": true
|
|
}
|
|
}
|
|
]
|
|
}
|
|
}
|
|
}
|