mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-24 06:35:24 +00:00
b59d9c85f1
Also add "make syntax-check" rules to ensure no new uses sneak in.
There are many uses of write like this:
if (write (fd, xml, towrite) != towrite)
return -1;
The problem is that the syscall can succeed, yet write less than
the requested number of bytes, so the caller should retry
rather than simply failing.
This patch changes most of them to use util.c's safewrite wrapper,
which encapsulates the process. Also, there were a few cases in
which the retry loop was open-coded, and I replaced those, too.
* Makefile.maint (sc_avoid_write): New rule, to avoid recurrence.
* .x-sc_avoid_write: New file. Record two legitimate exemptions.
* qemud/qemud.c (sig_handler, qemudClientWriteBuf): Use safewrite, not write.
* src/conf.c (__virConfWriteFile): Likewise.
* src/qemu_conf.c (qemudSaveConfig, qemudSaveNetworkConfig): Likewise.
* src/qemu_driver.c (qemudWaitForMonitor, qemudStartVMDaemon)
(qemudVMData, PROC_IP_FORWARD): Likewise.
* proxy/libvirt_proxy.c: Include "util.h".
(proxyWriteClientSocket): Use safewrite.
* src/test.c (testDomainSave, testDomainCoreDump): Likewise.
* src/proxy_internal.c (virProxyWriteClientSocket): Likewise.
* src/virsh.c: Include "util-lib.h".
(vshOutputLogFile): Use safewrite.
* src/console.c: Include "util-lib.h".
(vshRunConsole): Use safewrite.
|
||
|---|---|---|
| .. | ||
| .cvsignore | ||
| default-network.xml | ||
| event.c | ||
| event.h | ||
| internal.h | ||
| libvirtd.conf | ||
| libvirtd.init.in | ||
| libvirtd.policy | ||
| libvirtd.sasl | ||
| libvirtd.sysconf | ||
| Makefile.am | ||
| mdns.c | ||
| mdns.h | ||
| qemud.c | ||
| remote_dispatch_localvars.h | ||
| remote_dispatch_proc_switch.h | ||
| remote_dispatch_prototypes.h | ||
| remote_generate_stubs.pl | ||
| remote_protocol.c | ||
| remote_protocol.h | ||
| remote_protocol.x | ||
| remote.c | ||
| rpcgen_fix.pl | ||