mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-11-03 11:51:11 +00:00
8242ce4f45
The AM_CPPFLAGS setting includes the gnulib headers, which means we can get some replacement functions defined. Since virt-login-shell and the NSS module intentionally don't link to gnulib, these replacement functions causes link failures. This was seen cross-compiling on Debian for example: virt-login-shell.o: In function `main': /builds/libvirt/libvirt/build/tools/../../tools/virt-login-shell.c:81: undefined reference to `rpl_strerror' /builds/libvirt/libvirt/build/tools/../../tools/virt-login-shell.c:66: undefined reference to `rpl_strerror' /builds/libvirt/libvirt/build/tools/../../tools/virt-login-shell.c:75: undefined reference to `rpl_strerror' The only way to avoid these replacement gnulib headers is to drop the -Ignulib/lib flags. We do still want to use gnulib for configmake.h and intprops.h, but those can be included via their full path. We must also stop using internal.h, since that expects -Ignulib/lib to be on the include path in order to resolve the verify.h header. Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
89 lines
2.6 KiB
C
89 lines
2.6 KiB
C
/*
|
|
* virt-login-shell.c: a setuid shell to connect to a container
|
|
*
|
|
* Copyright (C) 2019 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include <unistd.h>
|
|
#include <sys/types.h>
|
|
#include <assert.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <errno.h>
|
|
#include <string.h>
|
|
|
|
/*
|
|
* These gnulib files are used for their macros only,
|
|
* so don't introduce a link time dep, which we must avoid
|
|
*/
|
|
#include "gnulib/lib/configmake.h"
|
|
#include "gnulib/lib/intprops.h"
|
|
|
|
int main(int argc, char **argv) {
|
|
char uidstr[INT_BUFSIZE_BOUND(uid_t)];
|
|
char gidstr[INT_BUFSIZE_BOUND(gid_t)];
|
|
const char *const newargv[] = {
|
|
LIBEXECDIR "/virt-login-shell-helper",
|
|
uidstr,
|
|
gidstr,
|
|
NULL,
|
|
};
|
|
char *newenv[] = {
|
|
NULL,
|
|
NULL,
|
|
};
|
|
char *term = getenv("TERM");
|
|
|
|
if (getuid() == 0 || getgid() == 0) {
|
|
fprintf(stderr, "%s: must not be run as root\n", argv[0]);
|
|
exit(EXIT_FAILURE);
|
|
}
|
|
|
|
if (geteuid() != 0) {
|
|
fprintf(stderr, "%s: must be run as setuid root\n", argv[0]);
|
|
exit(EXIT_FAILURE);
|
|
}
|
|
|
|
if (argc != 1) {
|
|
fprintf(stderr, "%s: no arguments expected\n", argv[0]);
|
|
exit(EXIT_FAILURE);
|
|
}
|
|
|
|
if (term &&
|
|
asprintf(&(newenv[0]), "TERM=%s", term) < 0) {
|
|
fprintf(stderr, "%s: cannot set TERM env variable: %s\n",
|
|
argv[0], strerror(errno));
|
|
exit(EXIT_FAILURE);
|
|
}
|
|
|
|
assert(snprintf(uidstr, sizeof(uidstr), "%d", getuid()) < sizeof(uidstr));
|
|
assert(snprintf(gidstr, sizeof(gidstr), "%d", getgid()) < sizeof(gidstr));
|
|
|
|
if (setuid(0) < 0) {
|
|
fprintf(stderr, "%s: unable to set real UID to root: %s\n",
|
|
argv[0], strerror(errno));
|
|
exit(EXIT_FAILURE);
|
|
}
|
|
|
|
execve(newargv[0], (char *const*)newargv, newenv);
|
|
fprintf(stderr, "%s: failed to run %s/virt-login-shell-helper: %s\n",
|
|
argv[0], LIBEXECDIR, strerror(errno));
|
|
exit(EXIT_FAILURE);
|
|
}
|