mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-09 15:55:47 +00:00
33188c9fcb
https://bugzilla.redhat.com/show_bug.cgi?id=1078126 Using 'virsh attach-device --config' (or --persistent) to attach a file backed lun device will succeed; however, subsequent domain restarts will result in failure because the configuration of a file backed lun is not supported. Although allowing 'illegal configurations' is something that can be allowed, it may not be practical in this case. Generally, when attaching a device to a domain means the domain must be running. A way around this is using the --config (or --persistent) option. When an attach is done to a running domain, a temporary configuration is modified first followed by the live update. The live update will make a number of disk validity checks when building the qemu command to attach the disk. If any fail, then change is rejected. Rather than allow a potentially illegal combination, adjust the code in the configuration path to make the same checks as the running path will make with respect to disk validity checks. This way we avoid having the potential for some subsequent start/reboot to fail because an illegal combination was allowed. NB: The live path still checks the configuration since it is possible to just do --live guest modification...
277 lines
11 KiB
C
277 lines
11 KiB
C
/*
|
|
* qemu_command.h: QEMU command generation
|
|
*
|
|
* Copyright (C) 2006-2014 Red Hat, Inc.
|
|
* Copyright (C) 2006 Daniel P. Berrange
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
* Author: Daniel P. Berrange <berrange@redhat.com>
|
|
*/
|
|
|
|
#ifndef __QEMU_COMMAND_H__
|
|
# define __QEMU_COMMAND_H__
|
|
|
|
# include "domain_addr.h"
|
|
# include "domain_conf.h"
|
|
# include "vircommand.h"
|
|
# include "capabilities.h"
|
|
# include "qemu_conf.h"
|
|
# include "qemu_domain.h"
|
|
# include "qemu_capabilities.h"
|
|
|
|
/* Config type for XML import/export conversions */
|
|
# define QEMU_CONFIG_FORMAT_ARGV "qemu-argv"
|
|
|
|
# define QEMU_DRIVE_HOST_PREFIX "drive-"
|
|
# define QEMU_VIRTIO_SERIAL_PREFIX "virtio-serial"
|
|
# define QEMU_FSDEV_HOST_PREFIX "fsdev-"
|
|
|
|
/* These are only defaults, they can be changed now in qemu.conf and
|
|
* explicitly specified port is checked against these two (makes
|
|
* sense to limit the values).
|
|
*
|
|
* This limitation is mentioned in qemu.conf, so bear in mind that the
|
|
* configuration file should reflect any changes made to these values.
|
|
*/
|
|
# define QEMU_REMOTE_PORT_MIN 5900
|
|
# define QEMU_REMOTE_PORT_MAX 65535
|
|
|
|
# define QEMU_WEBSOCKET_PORT_MIN 5700
|
|
# define QEMU_WEBSOCKET_PORT_MAX 65535
|
|
|
|
# define QEMU_MIGRATION_PORT_MIN 49152
|
|
# define QEMU_MIGRATION_PORT_MAX 49215
|
|
|
|
typedef struct _qemuBuildCommandLineCallbacks qemuBuildCommandLineCallbacks;
|
|
typedef qemuBuildCommandLineCallbacks *qemuBuildCommandLineCallbacksPtr;
|
|
struct _qemuBuildCommandLineCallbacks {
|
|
char *(*qemuGetSCSIDeviceSgName) (const char *sysfs_prefix,
|
|
const char *adapter,
|
|
unsigned int bus,
|
|
unsigned int target,
|
|
unsigned int unit);
|
|
};
|
|
|
|
extern qemuBuildCommandLineCallbacks buildCommandLineCallbacks;
|
|
|
|
virCommandPtr qemuBuildCommandLine(virConnectPtr conn,
|
|
virQEMUDriverPtr driver,
|
|
virDomainDefPtr def,
|
|
virDomainChrSourceDefPtr monitor_chr,
|
|
bool monitor_json,
|
|
virQEMUCapsPtr qemuCaps,
|
|
const char *migrateFrom,
|
|
int migrateFd,
|
|
virDomainSnapshotObjPtr current_snapshot,
|
|
virNetDevVPortProfileOp vmop,
|
|
qemuBuildCommandLineCallbacksPtr callbacks,
|
|
bool forXMLToArgv)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(11);
|
|
|
|
/* Generate '-device' string for chardev device */
|
|
int
|
|
qemuBuildChrDeviceStr(char **deviceStr,
|
|
virDomainDefPtr vmdef,
|
|
virDomainChrDefPtr chr,
|
|
virQEMUCapsPtr qemuCaps);
|
|
|
|
/* With vlan == -1, use netdev syntax, else old hostnet */
|
|
char *qemuBuildHostNetStr(virDomainNetDefPtr net,
|
|
virQEMUDriverPtr driver,
|
|
char type_sep,
|
|
int vlan,
|
|
char **tapfd,
|
|
int tapfdSize,
|
|
char **vhostfd,
|
|
int vhostfdSize);
|
|
|
|
/* Legacy, pre device support */
|
|
char *qemuBuildNicStr(virDomainNetDefPtr net,
|
|
const char *prefix,
|
|
int vlan);
|
|
|
|
/* Current, best practice */
|
|
char *qemuBuildNicDevStr(virDomainDefPtr def,
|
|
virDomainNetDefPtr net,
|
|
int vlan,
|
|
int bootindex,
|
|
int vhostfdSize,
|
|
virQEMUCapsPtr qemuCaps);
|
|
|
|
char *qemuDeviceDriveHostAlias(virDomainDiskDefPtr disk,
|
|
virQEMUCapsPtr qemuCaps);
|
|
|
|
/* Both legacy & current support */
|
|
char *qemuBuildDriveStr(virConnectPtr conn,
|
|
virDomainDiskDefPtr disk,
|
|
bool bootable,
|
|
virQEMUCapsPtr qemuCaps);
|
|
char *qemuBuildFSStr(virDomainFSDefPtr fs,
|
|
virQEMUCapsPtr qemuCaps);
|
|
|
|
/* Current, best practice */
|
|
char *qemuBuildDriveDevStr(virDomainDefPtr def,
|
|
virDomainDiskDefPtr disk,
|
|
int bootindex,
|
|
virQEMUCapsPtr qemuCaps);
|
|
char *qemuBuildFSDevStr(virDomainDefPtr domainDef,
|
|
virDomainFSDefPtr fs,
|
|
virQEMUCapsPtr qemuCaps);
|
|
/* Current, best practice */
|
|
char *qemuBuildControllerDevStr(virDomainDefPtr domainDef,
|
|
virDomainControllerDefPtr def,
|
|
virQEMUCapsPtr qemuCaps,
|
|
int *nusbcontroller);
|
|
|
|
char *qemuBuildWatchdogDevStr(virDomainDefPtr domainDef,
|
|
virDomainWatchdogDefPtr dev,
|
|
virQEMUCapsPtr qemuCaps);
|
|
|
|
char *qemuBuildMemballoonDevStr(virDomainDefPtr domainDef,
|
|
virDomainMemballoonDefPtr dev,
|
|
virQEMUCapsPtr qemuCaps);
|
|
|
|
char *qemuBuildUSBInputDevStr(virDomainDefPtr domainDef,
|
|
virDomainInputDefPtr dev,
|
|
virQEMUCapsPtr qemuCaps);
|
|
|
|
char *qemuBuildSoundDevStr(virDomainDefPtr domainDef,
|
|
virDomainSoundDefPtr sound,
|
|
virQEMUCapsPtr qemuCaps);
|
|
|
|
/* Legacy, pre device support */
|
|
char *qemuBuildPCIHostdevPCIDevStr(virDomainHostdevDefPtr dev,
|
|
virQEMUCapsPtr qemuCaps);
|
|
/* Current, best practice */
|
|
char *qemuBuildPCIHostdevDevStr(virDomainDefPtr def,
|
|
virDomainHostdevDefPtr dev,
|
|
const char *configfd,
|
|
virQEMUCapsPtr qemuCaps);
|
|
|
|
int qemuOpenPCIConfig(virDomainHostdevDefPtr dev);
|
|
|
|
/* Legacy, pre device support */
|
|
char *qemuBuildUSBHostdevUSBDevStr(virDomainHostdevDefPtr dev);
|
|
/* Current, best practice */
|
|
char *qemuBuildUSBHostdevDevStr(virDomainDefPtr def,
|
|
virDomainHostdevDefPtr dev,
|
|
virQEMUCapsPtr qemuCaps);
|
|
|
|
char *qemuBuildSCSIHostdevDrvStr(virConnectPtr conn,
|
|
virDomainHostdevDefPtr dev,
|
|
virQEMUCapsPtr qemuCaps,
|
|
qemuBuildCommandLineCallbacksPtr callbacks)
|
|
ATTRIBUTE_NONNULL(4);
|
|
char *qemuBuildSCSIHostdevDevStr(virDomainDefPtr def,
|
|
virDomainHostdevDefPtr dev,
|
|
virQEMUCapsPtr qemuCaps);
|
|
|
|
char *qemuBuildHubDevStr(virDomainDefPtr def,
|
|
virDomainHubDefPtr dev,
|
|
virQEMUCapsPtr qemuCaps);
|
|
char *qemuBuildRedirdevDevStr(virDomainDefPtr def,
|
|
virDomainRedirdevDefPtr dev,
|
|
virQEMUCapsPtr qemuCaps);
|
|
int qemuNetworkIfaceConnect(virDomainDefPtr def,
|
|
virConnectPtr conn,
|
|
virQEMUDriverPtr driver,
|
|
virDomainNetDefPtr net,
|
|
virQEMUCapsPtr qemuCaps,
|
|
int *tapfd,
|
|
int *tapfdSize)
|
|
ATTRIBUTE_NONNULL(2);
|
|
|
|
int qemuPhysIfaceConnect(virDomainDefPtr def,
|
|
virQEMUDriverPtr driver,
|
|
virDomainNetDefPtr net,
|
|
virQEMUCapsPtr qemuCaps,
|
|
virNetDevVPortProfileOp vmop);
|
|
|
|
int qemuOpenVhostNet(virDomainDefPtr def,
|
|
virDomainNetDefPtr net,
|
|
virQEMUCapsPtr qemuCaps,
|
|
int *vhostfd,
|
|
int *vhostfdSize);
|
|
|
|
int qemuNetworkPrepareDevices(virDomainDefPtr def);
|
|
|
|
/*
|
|
* NB: def->name can be NULL upon return and the caller
|
|
* *must* decide how to fill in a name in this case
|
|
*/
|
|
virDomainDefPtr qemuParseCommandLineString(virCapsPtr qemuCaps,
|
|
virDomainXMLOptionPtr xmlopt,
|
|
const char *args,
|
|
char **pidfile,
|
|
virDomainChrSourceDefPtr *monConfig,
|
|
bool *monJSON);
|
|
virDomainDefPtr qemuParseCommandLinePid(virCapsPtr qemuCaps,
|
|
virDomainXMLOptionPtr xmlopt,
|
|
pid_t pid,
|
|
char **pidfile,
|
|
virDomainChrSourceDefPtr *monConfig,
|
|
bool *monJSON);
|
|
|
|
int qemuDomainAssignAddresses(virDomainDefPtr def,
|
|
virQEMUCapsPtr qemuCaps,
|
|
virDomainObjPtr obj)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
|
|
int qemuDomainAssignSpaprVIOAddresses(virDomainDefPtr def,
|
|
virQEMUCapsPtr qemuCaps);
|
|
|
|
void qemuDomainReleaseDeviceAddress(virDomainObjPtr vm,
|
|
virDomainDeviceInfoPtr info,
|
|
const char *devstr);
|
|
|
|
|
|
int qemuDomainAssignPCIAddresses(virDomainDefPtr def,
|
|
virQEMUCapsPtr qemuCaps,
|
|
virDomainObjPtr obj);
|
|
virDomainPCIAddressSetPtr qemuDomainPCIAddressSetCreate(virDomainDefPtr def,
|
|
unsigned int nbuses,
|
|
bool dryRun);
|
|
|
|
int qemuAssignDevicePCISlots(virDomainDefPtr def,
|
|
virQEMUCapsPtr qemuCaps,
|
|
virDomainPCIAddressSetPtr addrs);
|
|
|
|
int qemuAssignDeviceAliases(virDomainDefPtr def, virQEMUCapsPtr qemuCaps);
|
|
int qemuDomainNetVLAN(virDomainNetDefPtr def);
|
|
int qemuAssignDeviceNetAlias(virDomainDefPtr def, virDomainNetDefPtr net, int idx);
|
|
int qemuAssignDeviceDiskAlias(virDomainDefPtr vmdef,
|
|
virDomainDiskDefPtr def,
|
|
virQEMUCapsPtr qemuCaps);
|
|
int qemuAssignDeviceHostdevAlias(virDomainDefPtr def, virDomainHostdevDefPtr hostdev, int idx);
|
|
int qemuAssignDeviceControllerAlias(virDomainControllerDefPtr controller);
|
|
int qemuAssignDeviceRedirdevAlias(virDomainDefPtr def, virDomainRedirdevDefPtr redirdev, int idx);
|
|
int qemuAssignDeviceChrAlias(virDomainDefPtr def,
|
|
virDomainChrDefPtr chr,
|
|
ssize_t idx);
|
|
|
|
int
|
|
qemuParseKeywords(const char *str,
|
|
char ***retkeywords,
|
|
char ***retvalues,
|
|
int *retnkeywords,
|
|
int allowEmptyValue);
|
|
|
|
int qemuGetDriveSourceString(virStorageSourcePtr src,
|
|
virConnectPtr conn,
|
|
char **source);
|
|
|
|
int qemuCheckDiskConfig(virDomainDiskDefPtr disk);
|
|
#endif /* __QEMU_COMMAND_H__*/
|