mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-03 16:42:37 +00:00
40935b395c
When using nbdkit to serve a network disk source, the nbdkit process
will start and wait for an nbd connection before actually attempting to
connect to the (remote) disk location. Because of this, nbdkit will not
report an error until after qemu is launched and tries to read from the
disk. This results in a fairly user-unfriendly error saying that qemu
was unable to start because "Requested export not available".
Ideally we'd like to be able to tell the user *why* the export is not
available, but this sort of information is only available to nbdkit, not
qemu. It could be because the url was incorrect, or because of an
authentication failure, or one of many other possibilities.
To make this friendlier for users and easier to detect
misconfigurations, try to connect to nbdkit immediately after starting
nbdkit and before we try to start qemu. This requires adding a
dependency on libnbd. If an error occurs when connecting to nbdkit, read
back from the nbdkit error log and provide that information in the error
report from qemuNbdkitProcessStart().
User-visible change demonstrated below:
Previous error:
$ virsh start nbdkit-test
2023-01-18 19:47:45.778+0000: 30895: error : virNetClientProgramDispatchError:172 : internal
error: process exited while connecting to monitor: 2023-01-18T19:47:45.704658Z
qemu-system-x86_64: -blockdev {"driver":"nbd","server":{"type":"unix",
"path":"/var/lib/libvirt/qemu/domain-1-nbdkit-test/nbdkit-libvirt-1-storage.socket"},
"node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}: Requested export not
available
error: Failed to start domain 'nbdkit-test'
error: internal error: process exited while connecting to monitor: 2023-01-18T19:47:45.704658Z
qemu-system-x86_64: -blockdev {"driver":"nbd","server":{"type":"unix",
"path":"/var/lib/libvirt/qemu/domain-1-nbdkit-test/nbdkit-libvirt-1-storage.socket"},
"node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}: Requested export not
available
After this change:
$ virsh start nbdkit-test
2023-01-18 19:44:36.242+0000: 30895: error : virNetClientProgramDispatchError:172 : internal
error: Failed to connect to nbdkit for 'http://localhost:8888/nonexistent.iso': nbdkit: curl[1]:
error: problem doing HEAD request to fetch size of URL [http://localhost:8888/nonexistent.iso]:
HTTP response code said error: The requested URL returned error: 404
error: Failed to start domain 'nbdkit-test'
error: internal error: Failed to connect to nbdkit for 'http://localhost:8888/nonexistent.iso]:
error: problem doing HEAD request to fetch size of URL [http://localhost:8888/nonexistent.iso]:
HTTP response code said error: The requested URL returned error: 404
Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
111 lines
9.5 KiB
Meson
111 lines
9.5 KiB
Meson
option('no_git', type: 'boolean', value: false, description: 'Disable git submodule update')
|
|
option('packager', type: 'string', value: '', description: 'Extra packager name')
|
|
option('packager_version', type: 'string', value: '', description: 'Extra packager version')
|
|
option('system', type: 'boolean', value: false, description: 'Set install paths to system ones')
|
|
option('runstatedir', type: 'string', value: '', description: 'State directory for temporary sockets, pid files, etc')
|
|
option('initconfdir', type: 'string', value: '', description: 'directory for init script configuration files')
|
|
option('expensive_tests', type: 'feature', value: 'auto', description: 'set the default for enabling expensive tests (long timeouts)')
|
|
option('test_coverage', type: 'boolean', value: false, description: 'turn on code coverage instrumentation')
|
|
option('git_werror', type: 'feature', value: 'auto', description: 'use -Werror if building from GIT')
|
|
option('rpath', type: 'feature', value: 'auto', description: 'whether to include rpath information in installed binaries and libraries')
|
|
option('docdir', type: 'string', value: '', description: 'documentation installation directory')
|
|
option('docs', type: 'feature', value: 'auto', description: 'whether to generate documentation')
|
|
option('tests', type: 'feature', value: 'auto', description: 'whether to build tests')
|
|
|
|
|
|
# build dependencies options
|
|
option('apparmor', type: 'feature', value: 'auto', description: 'apparmor support')
|
|
option('attr', type: 'feature', value: 'auto', description: 'attr support')
|
|
option('audit', type: 'feature', value: 'auto', description: 'audit support')
|
|
option('bash_completion', type: 'feature', value: 'auto', description: 'bash-completion support')
|
|
option('bash_completion_dir', type: 'string', value: '', description: 'directory containing bash completion scripts')
|
|
option('blkid', type: 'feature', value: 'auto', description: 'blkid support')
|
|
option('capng', type: 'feature', value: 'auto', description: 'cap-ng support')
|
|
option('curl', type: 'feature', value: 'auto', description: 'curl support')
|
|
option('fuse', type: 'feature', value: 'auto', description: 'fuse support')
|
|
option('glusterfs', type: 'feature', value: 'auto', description: 'glusterfs support')
|
|
option('libiscsi', type: 'feature', value: 'auto', description: 'libiscsi support')
|
|
option('libnbd', type: 'feature', value: 'auto', description: 'libnbd support')
|
|
option('libnl', type: 'feature', value: 'auto', description: 'libnl support')
|
|
option('libpcap', type: 'feature', value: 'auto', description: 'libpcap support')
|
|
option('libssh', type: 'feature', value: 'auto', description: 'libssh support')
|
|
option('libssh2', type: 'feature', value: 'auto', description: 'libssh2 support')
|
|
option('netcf', type: 'feature', value: 'auto', description: 'netcf support')
|
|
option('nls', type: 'feature', value: 'auto', description: 'nls support')
|
|
option('numactl', type: 'feature', value: 'auto', description: 'numactl support')
|
|
option('openwsman', type: 'feature', value: 'auto', description: 'openwsman support')
|
|
option('pciaccess', type: 'feature', value: 'auto', description: 'pciaccess support')
|
|
option('polkit', type: 'feature', value: 'auto', description: 'use PolicyKit for UNIX socket access checks')
|
|
option('readline', type: 'feature', value: 'auto', description: 'readline support')
|
|
option('sanlock', type: 'feature', value: 'auto', description: 'sanlock support')
|
|
option('sasl', type: 'feature', value: 'auto', description: 'sasl support')
|
|
option('selinux', type: 'feature', value: 'auto', description: 'selinux support')
|
|
option('selinux_mount', type: 'string', value: '', description: 'set SELinux mount point')
|
|
option('udev', type: 'feature', value: 'auto', description: 'udev support')
|
|
option('wireshark_dissector', type: 'feature', value: 'auto', description: 'wireshark support')
|
|
option('wireshark_plugindir', type: 'string', value: '', description: 'wireshark plugins directory for use when installing wireshark plugin')
|
|
option('yajl', type: 'feature', value: 'auto', description: 'yajl support')
|
|
|
|
|
|
# build driver options
|
|
option('driver_bhyve', type: 'feature', value: 'auto', description: 'bhyve driver')
|
|
option('driver_esx', type: 'feature', value: 'auto', description: 'esx driver')
|
|
option('driver_hyperv', type: 'feature', value: 'auto', description: 'Hyper-V driver')
|
|
option('driver_interface', type: 'feature', value: 'auto', description: 'host interface driver')
|
|
option('driver_libvirtd', type: 'feature', value: 'auto', description: 'libvirtd driver')
|
|
option('driver_libxl', type: 'feature', value: 'auto', description: 'libxenlight driver')
|
|
option('driver_lxc', type: 'feature', value: 'auto', description: 'Linux Container driver')
|
|
option('driver_ch', type: 'feature', value: 'auto', description: 'Cloud-Hypervisor driver')
|
|
option('ch_user', type: 'string', value: '', description: 'username to run Cloud-Hypervisor system instance as')
|
|
option('ch_group', type: 'string', value: '', description: 'groupname to run Cloud-Hypervisor system instance as')
|
|
option('driver_network', type: 'feature', value: 'auto', description: 'virtual network driver')
|
|
option('driver_openvz', type: 'feature', value: 'auto', description: 'OpenVZ driver')
|
|
option('driver_qemu', type: 'feature', value: 'auto', description: 'QEMU/KVM driver')
|
|
option('qemu_user', type: 'string', value: '', description: 'username to run QEMU system instance as')
|
|
option('qemu_group', type: 'string', value: '', description: 'groupname to run QEMU system instance as')
|
|
option('qemu_moddir', type: 'string', value: '', description: 'set the directory where QEMU modules are located')
|
|
option('qemu_datadir', type: 'string', value: '', description: 'set the directory where QEMU shared data is located')
|
|
option('driver_remote', type: 'feature', value: 'auto', description: 'remote driver')
|
|
option('remote_default_mode', type: 'combo', choices: ['legacy', 'direct'], value: 'direct', description: 'remote driver default mode')
|
|
option('driver_secrets', type: 'feature', value: 'auto', description: 'local secrets management driver')
|
|
option('driver_test', type: 'feature', value: 'auto', description: 'test driver')
|
|
option('driver_vbox', type: 'feature', value: 'auto', description: 'VirtualBox XPCOMC driver')
|
|
option('vbox_xpcomc_dir', type: 'string', value: '', description: 'Location of directory containing VirtualBox XPCOMC library')
|
|
option('driver_vmware', type: 'feature', value: 'auto', description: 'VMware driver')
|
|
option('driver_vz', type: 'feature', value: 'auto', description: 'Virtuozzo driver')
|
|
|
|
option('secdriver_apparmor', type: 'feature', value: 'auto', description: 'use AppArmor security driver')
|
|
option('apparmor_profiles', type: 'feature', value: 'auto', description: 'install apparmor profiles')
|
|
option('secdriver_selinux', type: 'feature', value: 'auto', description: 'use SELinux security driver')
|
|
|
|
|
|
# storage driver options
|
|
option('storage_dir', type: 'feature', value: 'auto', description: 'directory backend for the storage driver')
|
|
option('storage_disk', type: 'feature', value: 'auto', description: 'GPartd Disk backend for the storage driver')
|
|
option('storage_fs', type: 'feature', value: 'auto', description: 'FileSystem backend for the storage driver')
|
|
option('storage_gluster', type: 'feature', value: 'auto', description: 'Gluster backend for the storage driver')
|
|
option('storage_iscsi', type: 'feature', value: 'auto', description: 'iscsi backend for the storage driver')
|
|
option('storage_iscsi_direct', type: 'feature', value: 'auto', description: 'iscsi-direct backend for the storage driver')
|
|
option('storage_lvm', type: 'feature', value: 'auto', description: 'LVM backend for the storage driver')
|
|
option('storage_mpath', type: 'feature', value: 'auto', description: 'mpath backend for the storage driver')
|
|
option('storage_rbd', type: 'feature', value: 'auto', description: 'RADOS Block Device backend for the storage driver')
|
|
option('storage_scsi', type: 'feature', value: 'auto', description: 'SCSI backend for the storage driver')
|
|
option('storage_vstorage', type: 'feature', value: 'auto', description: 'Virtuozzo storage backend for the storage driver')
|
|
option('storage_zfs', type: 'feature', value: 'auto', description: 'ZFS backend for the storage driver')
|
|
|
|
|
|
# build feature options
|
|
option('chrdev_lock_files', type: 'string', value: '', description: 'location for UUCP style lock files for character devices (leave empty for default paths on some platforms)')
|
|
option('dtrace', type: 'feature', value: 'auto', description: 'use dtrace for static probing')
|
|
option('firewalld', type: 'feature', value: 'auto', description: 'firewalld support')
|
|
option('firewalld_zone', type: 'feature', value: 'auto', description: 'whether to install firewalld libvirt zone')
|
|
option('host_validate', type: 'feature', value: 'auto', description: 'build virt-host-validate')
|
|
option('init_script', type: 'combo', choices: ['systemd', 'openrc', 'check', 'none'], value: 'check', description: 'Style of init script to install')
|
|
option('loader_nvram', type: 'string', value: '', description: 'Pass list of pairs of <loader>:<nvram> paths. Both pairs and list items are separated by a colon.')
|
|
option('login_shell', type: 'feature', value: 'auto', description: 'build virt-login-shell')
|
|
option('nss', type: 'feature', value: 'auto', description: 'enable Name Service Switch plugin for resolving guest IP addresses')
|
|
option('numad', type: 'feature', value: 'auto', description: 'use numad to manage CPU placement dynamically')
|
|
option('pm_utils', type: 'feature', value: 'auto', description: 'use pm-utils for power management')
|
|
option('sysctl_config', type: 'feature', value: 'auto', description: 'Whether to install sysctl configs')
|
|
option('tls_priority', type: 'string', value: 'NORMAL', description: 'set the default TLS session priority string')
|