mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-27 08:05:24 +00:00
93ab4da5f4
Since threadpool increments the current number of threads according to current load, i.e. how many jobs are waiting in the queue. The count however, is constrained by max and min limits of workers. The logic of this new API works like this: 1) setting the minimum a) When the limit is increased, depending on the current number of threads, new threads are possibly spawned if the current number of threads is less than the new minimum limit b) Decreasing the minimum limit has no possible effect on the current number of threads 2) setting the maximum a) Icreasing the maximum limit has no immediate effect on the current number of threads, it only allows the threadpool to spawn more threads when new jobs, that would otherwise end up queued, arrive. b) Decreasing the maximum limit may affect the current number of threads, if the current number of threads is less than the new maximum limit. Since there may be some ongoing time-consuming jobs that would effectively block this API from killing any threads. Therefore, this API is asynchronous with best-effort execution, i.e. the necessary number of workers will be terminated once they finish their previous job, unless other workers had already terminated, decreasing the limit to the requested value. 3) setting priority workers - both increase and decrease in count of these workers have an immediate impact on the current number of workers, new ones will be spawned or some of them get terminated respectively. Signed-off-by: Erik Skultety <eskultet@redhat.com>
476 lines
12 KiB
C
476 lines
12 KiB
C
/*
|
|
* virthreadpool.c: a generic thread pool implementation
|
|
*
|
|
* Copyright (C) 2014 Red Hat, Inc.
|
|
* Copyright (C) 2010 Hu Tao
|
|
* Copyright (C) 2010 Daniel P. Berrange
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
* Authors:
|
|
* Hu Tao <hutao@cn.fujitsu.com>
|
|
* Daniel P. Berrange <berrange@redhat.com>
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include "virthreadpool.h"
|
|
#include "viralloc.h"
|
|
#include "virthread.h"
|
|
#include "virerror.h"
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_NONE
|
|
|
|
typedef struct _virThreadPoolJob virThreadPoolJob;
|
|
typedef virThreadPoolJob *virThreadPoolJobPtr;
|
|
|
|
struct _virThreadPoolJob {
|
|
virThreadPoolJobPtr prev;
|
|
virThreadPoolJobPtr next;
|
|
unsigned int priority;
|
|
|
|
void *data;
|
|
};
|
|
|
|
typedef struct _virThreadPoolJobList virThreadPoolJobList;
|
|
typedef virThreadPoolJobList *virThreadPoolJobListPtr;
|
|
|
|
struct _virThreadPoolJobList {
|
|
virThreadPoolJobPtr head;
|
|
virThreadPoolJobPtr tail;
|
|
virThreadPoolJobPtr firstPrio;
|
|
};
|
|
|
|
|
|
struct _virThreadPool {
|
|
bool quit;
|
|
|
|
virThreadPoolJobFunc jobFunc;
|
|
const char *jobFuncName;
|
|
void *jobOpaque;
|
|
virThreadPoolJobList jobList;
|
|
size_t jobQueueDepth;
|
|
|
|
virMutex mutex;
|
|
virCond cond;
|
|
virCond quit_cond;
|
|
|
|
size_t maxWorkers;
|
|
size_t minWorkers;
|
|
size_t freeWorkers;
|
|
size_t nWorkers;
|
|
virThreadPtr workers;
|
|
|
|
size_t maxPrioWorkers;
|
|
size_t nPrioWorkers;
|
|
virThreadPtr prioWorkers;
|
|
virCond prioCond;
|
|
};
|
|
|
|
struct virThreadPoolWorkerData {
|
|
virThreadPoolPtr pool;
|
|
virCondPtr cond;
|
|
bool priority;
|
|
};
|
|
|
|
/* Test whether the worker needs to quit if the current number of workers @count
|
|
* is greater than @limit actually allows.
|
|
*/
|
|
static inline bool virThreadPoolWorkerQuitHelper(size_t count, size_t limit)
|
|
{
|
|
return count > limit;
|
|
}
|
|
|
|
static void virThreadPoolWorker(void *opaque)
|
|
{
|
|
struct virThreadPoolWorkerData *data = opaque;
|
|
virThreadPoolPtr pool = data->pool;
|
|
virCondPtr cond = data->cond;
|
|
bool priority = data->priority;
|
|
size_t *curWorkers = priority ? &pool->nPrioWorkers : &pool->nWorkers;
|
|
size_t *maxLimit = priority ? &pool->maxPrioWorkers : &pool->maxWorkers;
|
|
virThreadPoolJobPtr job = NULL;
|
|
|
|
VIR_FREE(data);
|
|
|
|
virMutexLock(&pool->mutex);
|
|
|
|
while (1) {
|
|
/* In order to support async worker termination, we need ensure that
|
|
* both busy and free workers know if they need to terminated. Thus,
|
|
* busy workers need to check for this fact before they start waiting for
|
|
* another job (and before taking another one from the queue); and
|
|
* free workers need to check for this right after waking up.
|
|
*/
|
|
if (virThreadPoolWorkerQuitHelper(*curWorkers, *maxLimit))
|
|
goto out;
|
|
while (!pool->quit &&
|
|
((!priority && !pool->jobList.head) ||
|
|
(priority && !pool->jobList.firstPrio))) {
|
|
if (!priority)
|
|
pool->freeWorkers++;
|
|
if (virCondWait(cond, &pool->mutex) < 0) {
|
|
if (!priority)
|
|
pool->freeWorkers--;
|
|
goto out;
|
|
}
|
|
if (!priority)
|
|
pool->freeWorkers--;
|
|
|
|
if (virThreadPoolWorkerQuitHelper(*curWorkers, *maxLimit))
|
|
goto out;
|
|
}
|
|
|
|
if (pool->quit)
|
|
break;
|
|
|
|
if (priority) {
|
|
job = pool->jobList.firstPrio;
|
|
} else {
|
|
job = pool->jobList.head;
|
|
}
|
|
|
|
if (job == pool->jobList.firstPrio) {
|
|
virThreadPoolJobPtr tmp = job->next;
|
|
while (tmp) {
|
|
if (tmp->priority)
|
|
break;
|
|
tmp = tmp->next;
|
|
}
|
|
pool->jobList.firstPrio = tmp;
|
|
}
|
|
|
|
if (job->prev)
|
|
job->prev->next = job->next;
|
|
else
|
|
pool->jobList.head = job->next;
|
|
if (job->next)
|
|
job->next->prev = job->prev;
|
|
else
|
|
pool->jobList.tail = job->prev;
|
|
|
|
pool->jobQueueDepth--;
|
|
|
|
virMutexUnlock(&pool->mutex);
|
|
(pool->jobFunc)(job->data, pool->jobOpaque);
|
|
VIR_FREE(job);
|
|
virMutexLock(&pool->mutex);
|
|
}
|
|
|
|
out:
|
|
if (priority)
|
|
pool->nPrioWorkers--;
|
|
else
|
|
pool->nWorkers--;
|
|
if (pool->nWorkers == 0 && pool->nPrioWorkers == 0)
|
|
virCondSignal(&pool->quit_cond);
|
|
virMutexUnlock(&pool->mutex);
|
|
}
|
|
|
|
static int
|
|
virThreadPoolExpand(virThreadPoolPtr pool, size_t gain, bool priority)
|
|
{
|
|
virThreadPtr *workers = priority ? &pool->prioWorkers : &pool->workers;
|
|
size_t *curWorkers = priority ? &pool->nPrioWorkers : &pool->nWorkers;
|
|
size_t i = 0;
|
|
struct virThreadPoolWorkerData *data = NULL;
|
|
|
|
if (VIR_EXPAND_N(*workers, *curWorkers, gain) < 0)
|
|
return -1;
|
|
|
|
for (i = 0; i < gain; i++) {
|
|
if (VIR_ALLOC(data) < 0)
|
|
goto error;
|
|
|
|
data->pool = pool;
|
|
data->cond = priority ? &pool->prioCond : &pool->cond;
|
|
data->priority = priority;
|
|
|
|
if (virThreadCreateFull(&(*workers)[i],
|
|
false,
|
|
virThreadPoolWorker,
|
|
pool->jobFuncName,
|
|
true,
|
|
data) < 0) {
|
|
VIR_FREE(data);
|
|
virReportSystemError(errno, "%s", _("Failed to create thread"));
|
|
goto error;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
|
|
error:
|
|
*curWorkers -= gain - i;
|
|
return -1;
|
|
}
|
|
|
|
virThreadPoolPtr
|
|
virThreadPoolNewFull(size_t minWorkers,
|
|
size_t maxWorkers,
|
|
size_t prioWorkers,
|
|
virThreadPoolJobFunc func,
|
|
const char *funcName,
|
|
void *opaque)
|
|
{
|
|
virThreadPoolPtr pool;
|
|
|
|
if (minWorkers > maxWorkers)
|
|
minWorkers = maxWorkers;
|
|
|
|
if (VIR_ALLOC(pool) < 0)
|
|
return NULL;
|
|
|
|
pool->jobList.tail = pool->jobList.head = NULL;
|
|
|
|
pool->jobFunc = func;
|
|
pool->jobFuncName = funcName;
|
|
pool->jobOpaque = opaque;
|
|
|
|
if (virMutexInit(&pool->mutex) < 0)
|
|
goto error;
|
|
if (virCondInit(&pool->cond) < 0)
|
|
goto error;
|
|
if (virCondInit(&pool->quit_cond) < 0)
|
|
goto error;
|
|
|
|
pool->minWorkers = minWorkers;
|
|
pool->maxWorkers = maxWorkers;
|
|
pool->maxPrioWorkers = prioWorkers;
|
|
|
|
if (virThreadPoolExpand(pool, minWorkers, false) < 0)
|
|
goto error;
|
|
|
|
if (prioWorkers) {
|
|
if (virCondInit(&pool->prioCond) < 0)
|
|
goto error;
|
|
|
|
if (virThreadPoolExpand(pool, prioWorkers, true) < 0)
|
|
goto error;
|
|
}
|
|
|
|
return pool;
|
|
|
|
error:
|
|
virThreadPoolFree(pool);
|
|
return NULL;
|
|
|
|
}
|
|
|
|
void virThreadPoolFree(virThreadPoolPtr pool)
|
|
{
|
|
virThreadPoolJobPtr job;
|
|
bool priority = false;
|
|
|
|
if (!pool)
|
|
return;
|
|
|
|
virMutexLock(&pool->mutex);
|
|
pool->quit = true;
|
|
if (pool->nWorkers > 0)
|
|
virCondBroadcast(&pool->cond);
|
|
if (pool->nPrioWorkers > 0) {
|
|
priority = true;
|
|
virCondBroadcast(&pool->prioCond);
|
|
}
|
|
|
|
while (pool->nWorkers > 0 || pool->nPrioWorkers > 0)
|
|
ignore_value(virCondWait(&pool->quit_cond, &pool->mutex));
|
|
|
|
while ((job = pool->jobList.head)) {
|
|
pool->jobList.head = pool->jobList.head->next;
|
|
VIR_FREE(job);
|
|
}
|
|
|
|
VIR_FREE(pool->workers);
|
|
virMutexUnlock(&pool->mutex);
|
|
virMutexDestroy(&pool->mutex);
|
|
virCondDestroy(&pool->quit_cond);
|
|
virCondDestroy(&pool->cond);
|
|
if (priority) {
|
|
VIR_FREE(pool->prioWorkers);
|
|
virCondDestroy(&pool->prioCond);
|
|
}
|
|
VIR_FREE(pool);
|
|
}
|
|
|
|
|
|
size_t virThreadPoolGetMinWorkers(virThreadPoolPtr pool)
|
|
{
|
|
size_t ret;
|
|
|
|
virMutexLock(&pool->mutex);
|
|
ret = pool->minWorkers;
|
|
virMutexUnlock(&pool->mutex);
|
|
|
|
return ret;
|
|
}
|
|
|
|
size_t virThreadPoolGetMaxWorkers(virThreadPoolPtr pool)
|
|
{
|
|
size_t ret;
|
|
|
|
virMutexLock(&pool->mutex);
|
|
ret = pool->maxWorkers;
|
|
virMutexUnlock(&pool->mutex);
|
|
|
|
return ret;
|
|
}
|
|
|
|
size_t virThreadPoolGetPriorityWorkers(virThreadPoolPtr pool)
|
|
{
|
|
size_t ret;
|
|
|
|
virMutexLock(&pool->mutex);
|
|
ret = pool->nPrioWorkers;
|
|
virMutexUnlock(&pool->mutex);
|
|
|
|
return ret;
|
|
}
|
|
|
|
size_t virThreadPoolGetCurrentWorkers(virThreadPoolPtr pool)
|
|
{
|
|
size_t ret;
|
|
|
|
virMutexLock(&pool->mutex);
|
|
ret = pool->nWorkers;
|
|
virMutexUnlock(&pool->mutex);
|
|
|
|
return ret;
|
|
}
|
|
|
|
size_t virThreadPoolGetFreeWorkers(virThreadPoolPtr pool)
|
|
{
|
|
size_t ret;
|
|
|
|
virMutexLock(&pool->mutex);
|
|
ret = pool->freeWorkers;
|
|
virMutexUnlock(&pool->mutex);
|
|
|
|
return ret;
|
|
}
|
|
|
|
size_t virThreadPoolGetJobQueueDepth(virThreadPoolPtr pool)
|
|
{
|
|
size_t ret;
|
|
|
|
virMutexLock(&pool->mutex);
|
|
ret = pool->jobQueueDepth;
|
|
virMutexUnlock(&pool->mutex);
|
|
|
|
return ret;
|
|
}
|
|
|
|
/*
|
|
* @priority - job priority
|
|
* Return: 0 on success, -1 otherwise
|
|
*/
|
|
int virThreadPoolSendJob(virThreadPoolPtr pool,
|
|
unsigned int priority,
|
|
void *jobData)
|
|
{
|
|
virThreadPoolJobPtr job;
|
|
|
|
virMutexLock(&pool->mutex);
|
|
if (pool->quit)
|
|
goto error;
|
|
|
|
if (pool->freeWorkers - pool->jobQueueDepth <= 0 &&
|
|
pool->nWorkers < pool->maxWorkers &&
|
|
virThreadPoolExpand(pool, 1, false) < 0)
|
|
goto error;
|
|
|
|
if (VIR_ALLOC(job) < 0)
|
|
goto error;
|
|
|
|
job->data = jobData;
|
|
job->priority = priority;
|
|
|
|
job->prev = pool->jobList.tail;
|
|
if (pool->jobList.tail)
|
|
pool->jobList.tail->next = job;
|
|
pool->jobList.tail = job;
|
|
|
|
if (!pool->jobList.head)
|
|
pool->jobList.head = job;
|
|
|
|
if (priority && !pool->jobList.firstPrio)
|
|
pool->jobList.firstPrio = job;
|
|
|
|
pool->jobQueueDepth++;
|
|
|
|
virCondSignal(&pool->cond);
|
|
if (priority)
|
|
virCondSignal(&pool->prioCond);
|
|
|
|
virMutexUnlock(&pool->mutex);
|
|
return 0;
|
|
|
|
error:
|
|
virMutexUnlock(&pool->mutex);
|
|
return -1;
|
|
}
|
|
|
|
int
|
|
virThreadPoolSetParameters(virThreadPoolPtr pool,
|
|
long long int minWorkers,
|
|
long long int maxWorkers,
|
|
long long int prioWorkers)
|
|
{
|
|
size_t max;
|
|
size_t min;
|
|
|
|
virMutexLock(&pool->mutex);
|
|
|
|
max = maxWorkers >= 0 ? maxWorkers : pool->maxWorkers;
|
|
min = minWorkers >= 0 ? minWorkers : pool->minWorkers;
|
|
if (min > max) {
|
|
virReportError(VIR_ERR_INVALID_ARG, "%s",
|
|
_("minWorkers cannot be larger than maxWorkers"));
|
|
goto error;
|
|
}
|
|
|
|
if (minWorkers >= 0) {
|
|
if ((size_t) minWorkers > pool->nWorkers &&
|
|
virThreadPoolExpand(pool, minWorkers - pool->nWorkers,
|
|
false) < 0)
|
|
goto error;
|
|
pool->minWorkers = minWorkers;
|
|
}
|
|
|
|
if (maxWorkers >= 0) {
|
|
pool->maxWorkers = maxWorkers;
|
|
virCondBroadcast(&pool->cond);
|
|
}
|
|
|
|
if (prioWorkers >= 0) {
|
|
if (prioWorkers < pool->nPrioWorkers) {
|
|
virCondBroadcast(&pool->prioCond);
|
|
} else if ((size_t) prioWorkers > pool->nPrioWorkers &&
|
|
virThreadPoolExpand(pool, prioWorkers - pool->nPrioWorkers,
|
|
true) < 0) {
|
|
goto error;
|
|
}
|
|
pool->maxPrioWorkers = prioWorkers;
|
|
}
|
|
|
|
virMutexUnlock(&pool->mutex);
|
|
return 0;
|
|
|
|
error:
|
|
virMutexUnlock(&pool->mutex);
|
|
return -1;
|
|
}
|