mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-23 14:15:28 +00:00
acf522e85a
Commit0c6ad476updated gnulib, which rearranged some of the conditions in gnulib wrapper headers such that compilation started failing on BSD systems when the normal system <unistd.h> tried to include another system header but instead got a gnulib wrapper header in an incomplete state; this is because gnulib headers only work if <config.h> is included first. Commitb6f78259papered over the symptoms of that by including <config.h> in all the examples. But this logic is backwards - if our examples are truly meant to be stand-alone, they should NOT depend on how libvirt was configured, and should NOT depend on the gnulib fixes for system quirks. In particular, if an example does not need to link against libgnulib.la, then it also does not need to use -Ignulib in its compile flags, and likewise does not need to include <config.h> since none of the gnulib wrapper headers should be interfering. So, revert (most of)b6f78259(except for the bogus pre-patch use of "config.h" in admin/logging.c: if config.h is included, it should be via <> rather than "", and must be before any system headers); then additionally nuke all mention of <config.h>, -Ignulib, and -llibgnu.la, making all of the examples truly standalone. Signed-off-by: Eric Blake <eblake@redhat.com> Acked-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
74 lines
2.0 KiB
C
74 lines
2.0 KiB
C
/*
|
|
* rename.c
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <libvirt/libvirt.h>
|
|
|
|
int main(int argc, char **argv)
|
|
{
|
|
virConnectPtr conn = NULL; /* the hypervisor connection */
|
|
virDomainPtr dom = NULL; /* the domain being checked */
|
|
int ret = EXIT_FAILURE;
|
|
|
|
if (argc != 3) {
|
|
fprintf(stderr, "Usage: %s <current_domname> <temporary_domname>\n",
|
|
argv[0]);
|
|
goto error;
|
|
}
|
|
|
|
conn = virConnectOpen(NULL);
|
|
if (conn == NULL) {
|
|
fprintf(stderr, "Failed to connect to hypervisor\n");
|
|
goto error;
|
|
}
|
|
|
|
dom = virDomainLookupByName(conn, argv[1]);
|
|
if (dom == NULL) {
|
|
fprintf(stderr, "Failed to find domain\n");
|
|
goto error;
|
|
}
|
|
|
|
printf("Before first rename: %s\n", virDomainGetName(dom));
|
|
|
|
/* Get the information */
|
|
ret = virDomainRename(dom, argv[2], 0);
|
|
if (ret < 0) {
|
|
fprintf(stderr, "Failed to rename domain\n");
|
|
goto error;
|
|
}
|
|
|
|
printf("After first rename: %s\n", virDomainGetName(dom));
|
|
|
|
/* Get the information */
|
|
ret = virDomainRename(dom, argv[1], 0);
|
|
if (ret < 0) {
|
|
fprintf(stderr, "Failed to rename domain\n");
|
|
goto error;
|
|
}
|
|
|
|
printf("After second rename: %s\n", virDomainGetName(dom));
|
|
|
|
error:
|
|
if (dom != NULL)
|
|
virDomainFree(dom);
|
|
if (conn != NULL)
|
|
virConnectClose(conn);
|
|
return ret;
|
|
}
|