mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-03 04:45:46 +00:00
baebb34120
Coverity complained about unused variable that contains the shutdown mode. The original intention was to check it against the requested mode. Also the fixed check revealed a mistake in the expected shutdown mode. Reported by John Ferlan.
488 lines
13 KiB
C
488 lines
13 KiB
C
/*
|
|
* Copyright (C) 2013 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include "testutils.h"
|
|
#include "testutilsqemu.h"
|
|
#include "qemumonitortestutils.h"
|
|
#include "qemu/qemu_conf.h"
|
|
#include "qemu/qemu_agent.h"
|
|
#include "virthread.h"
|
|
#include "virerror.h"
|
|
#include "virstring.h"
|
|
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_NONE
|
|
|
|
static int
|
|
testQemuAgentFSFreeze(const void *data)
|
|
{
|
|
virDomainXMLOptionPtr xmlopt = (virDomainXMLOptionPtr)data;
|
|
qemuMonitorTestPtr test = qemuMonitorTestNewAgent(xmlopt);
|
|
int ret = -1;
|
|
|
|
if (!test)
|
|
return -1;
|
|
|
|
if (qemuMonitorTestAddAgentSyncResponse(test) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuMonitorTestAddItem(test, "guest-fsfreeze-freeze",
|
|
"{ \"return\" : 5 }") < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuMonitorTestAddAgentSyncResponse(test) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuMonitorTestAddItem(test, "guest-fsfreeze-freeze",
|
|
"{ \"return\" : 7 }") < 0)
|
|
goto cleanup;
|
|
|
|
if ((ret = qemuAgentFSFreeze(qemuMonitorTestGetAgent(test))) < 0)
|
|
goto cleanup;
|
|
|
|
if (ret != 5) {
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
"expected 5 frozen filesystems, got %d", ret);
|
|
goto cleanup;
|
|
}
|
|
|
|
if ((ret = qemuAgentFSFreeze(qemuMonitorTestGetAgent(test))) < 0)
|
|
goto cleanup;
|
|
|
|
if (ret != 7) {
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
"expected 7 frozen filesystems, got %d", ret);
|
|
goto cleanup;
|
|
}
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
qemuMonitorTestFree(test);
|
|
return ret;
|
|
}
|
|
|
|
|
|
static int
|
|
testQemuAgentFSThaw(const void *data)
|
|
{
|
|
virDomainXMLOptionPtr xmlopt = (virDomainXMLOptionPtr)data;
|
|
qemuMonitorTestPtr test = qemuMonitorTestNewAgent(xmlopt);
|
|
int ret = -1;
|
|
|
|
if (!test)
|
|
return -1;
|
|
|
|
if (qemuMonitorTestAddAgentSyncResponse(test) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuMonitorTestAddItem(test, "guest-fsfreeze-thaw",
|
|
"{ \"return\" : 5 }") < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuMonitorTestAddAgentSyncResponse(test) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuMonitorTestAddItem(test, "guest-fsfreeze-thaw",
|
|
"{ \"return\" : 7 }") < 0)
|
|
goto cleanup;
|
|
|
|
if ((ret = qemuAgentFSThaw(qemuMonitorTestGetAgent(test))) < 0)
|
|
goto cleanup;
|
|
|
|
if (ret != 5) {
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
"expected 5 thawed filesystems, got %d", ret);
|
|
goto cleanup;
|
|
}
|
|
|
|
if ((ret = qemuAgentFSThaw(qemuMonitorTestGetAgent(test))) < 0)
|
|
goto cleanup;
|
|
|
|
if (ret != 7) {
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
"expected 7 thawed filesystems, got %d", ret);
|
|
goto cleanup;
|
|
}
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
qemuMonitorTestFree(test);
|
|
return ret;
|
|
}
|
|
|
|
|
|
static int
|
|
testQemuAgentFSTrim(const void *data)
|
|
{
|
|
virDomainXMLOptionPtr xmlopt = (virDomainXMLOptionPtr)data;
|
|
qemuMonitorTestPtr test = qemuMonitorTestNewAgent(xmlopt);
|
|
int ret = -1;
|
|
|
|
if (!test)
|
|
return -1;
|
|
|
|
if (qemuMonitorTestAddAgentSyncResponse(test) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuMonitorTestAddItemParams(test, "guest-fstrim",
|
|
"{ \"return\" : {} }",
|
|
"minimum", "1337",
|
|
NULL) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuAgentFSTrim(qemuMonitorTestGetAgent(test), 1337) < 0)
|
|
goto cleanup;
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
qemuMonitorTestFree(test);
|
|
return ret;
|
|
}
|
|
|
|
|
|
static int
|
|
testQemuAgentSuspend(const void *data)
|
|
{
|
|
virDomainXMLOptionPtr xmlopt = (virDomainXMLOptionPtr)data;
|
|
qemuMonitorTestPtr test = qemuMonitorTestNewAgent(xmlopt);
|
|
int ret = -1;
|
|
size_t i;
|
|
|
|
if (!test)
|
|
return -1;
|
|
|
|
if (qemuMonitorTestAddAgentSyncResponse(test) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuMonitorTestAddItem(test, "guest-suspend-ram",
|
|
"{ \"return\" : {} }") < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuMonitorTestAddAgentSyncResponse(test) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuMonitorTestAddItem(test, "guest-suspend-disk",
|
|
"{ \"return\" : {} }") < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuMonitorTestAddAgentSyncResponse(test) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuMonitorTestAddItem(test, "guest-suspend-hybrid",
|
|
"{ \"return\" : {} }") < 0)
|
|
goto cleanup;
|
|
|
|
/* try the commands - fail if ordering changes */
|
|
for (i = 0; i < VIR_NODE_SUSPEND_TARGET_LAST; i++) {
|
|
if (qemuAgentSuspend(qemuMonitorTestGetAgent(test), i) < 0)
|
|
goto cleanup;
|
|
}
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
qemuMonitorTestFree(test);
|
|
return ret;
|
|
}
|
|
|
|
|
|
struct qemuAgentShutdownTestData {
|
|
const char *mode;
|
|
qemuAgentEvent event;
|
|
};
|
|
|
|
|
|
static int
|
|
qemuAgentShutdownTestMonitorHandler(qemuMonitorTestPtr test,
|
|
qemuMonitorTestItemPtr item,
|
|
const char *cmdstr)
|
|
{
|
|
struct qemuAgentShutdownTestData *data;
|
|
virJSONValuePtr val = NULL;
|
|
virJSONValuePtr args;
|
|
const char *cmdname;
|
|
const char *mode;
|
|
int ret = -1;
|
|
|
|
data = qemuMonitorTestItemGetPrivateData(item);
|
|
|
|
if (!(val = virJSONValueFromString(cmdstr)))
|
|
return -1;
|
|
|
|
if (!(cmdname = virJSONValueObjectGetString(val, "execute"))) {
|
|
ret = qemuMonitorReportError(test, "Missing command name in %s", cmdstr);
|
|
goto cleanup;
|
|
}
|
|
|
|
if (STRNEQ(cmdname, "guest-shutdown")) {
|
|
ret = qemuMonitorTestAddUnexpectedErrorResponse(test);
|
|
goto cleanup;
|
|
}
|
|
|
|
if (!(args = virJSONValueObjectGet(val, "arguments"))) {
|
|
ret = qemuMonitorReportError(test,
|
|
"Missing arguments section");
|
|
goto cleanup;
|
|
}
|
|
|
|
if (!(mode = virJSONValueObjectGetString(args, "mode"))) {
|
|
ret = qemuMonitorReportError(test, "Missing shutdown mode");
|
|
goto cleanup;
|
|
}
|
|
|
|
if (STRNEQ(mode, data->mode)) {
|
|
ret = qemuMonitorReportError(test,
|
|
"expected shutdown mode '%s' got '%s'",
|
|
data->mode, mode);
|
|
goto cleanup;
|
|
}
|
|
|
|
/* now don't reply but return a qemu agent event */
|
|
qemuAgentNotifyEvent(qemuMonitorTestGetAgent(test),
|
|
data->event);
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
virJSONValueFree(val);
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
static int
|
|
testQemuAgentShutdown(const void *data)
|
|
{
|
|
virDomainXMLOptionPtr xmlopt = (virDomainXMLOptionPtr)data;
|
|
qemuMonitorTestPtr test = qemuMonitorTestNewAgent(xmlopt);
|
|
struct qemuAgentShutdownTestData priv;
|
|
int ret = -1;
|
|
|
|
if (!test)
|
|
return -1;
|
|
|
|
if (qemuMonitorTestAddAgentSyncResponse(test) < 0)
|
|
goto cleanup;
|
|
|
|
priv.event = QEMU_AGENT_EVENT_SHUTDOWN;
|
|
priv.mode = "halt";
|
|
|
|
if (qemuMonitorTestAddHandler(test, qemuAgentShutdownTestMonitorHandler,
|
|
&priv, NULL) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuAgentShutdown(qemuMonitorTestGetAgent(test),
|
|
QEMU_AGENT_SHUTDOWN_HALT) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuMonitorTestAddAgentSyncResponse(test) < 0)
|
|
goto cleanup;
|
|
|
|
priv.event = QEMU_AGENT_EVENT_SHUTDOWN;
|
|
priv.mode = "powerdown";
|
|
|
|
if (qemuMonitorTestAddHandler(test, qemuAgentShutdownTestMonitorHandler,
|
|
&priv, NULL) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuAgentShutdown(qemuMonitorTestGetAgent(test),
|
|
QEMU_AGENT_SHUTDOWN_POWERDOWN) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuMonitorTestAddAgentSyncResponse(test) < 0)
|
|
goto cleanup;
|
|
|
|
priv.event = QEMU_AGENT_EVENT_RESET;
|
|
priv.mode = "reboot";
|
|
|
|
if (qemuMonitorTestAddHandler(test, qemuAgentShutdownTestMonitorHandler,
|
|
&priv, NULL) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuAgentShutdown(qemuMonitorTestGetAgent(test),
|
|
QEMU_AGENT_SHUTDOWN_REBOOT) < 0)
|
|
goto cleanup;
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
qemuMonitorTestFree(test);
|
|
return ret;
|
|
}
|
|
|
|
|
|
static const char testQemuAgentCPUResponse[] =
|
|
"{\"return\": "
|
|
" ["
|
|
" {\"online\": true,"
|
|
" \"can-offline\": false,"
|
|
" \"logical-id\": 0"
|
|
" },"
|
|
" {\"online\": true,"
|
|
" \"can-offline\": true,"
|
|
" \"logical-id\": 1"
|
|
" },"
|
|
" {\"online\": true,"
|
|
" \"can-offline\": true,"
|
|
" \"logical-id\": 2"
|
|
" },"
|
|
" {\"online\": false,"
|
|
" \"can-offline\": true,"
|
|
" \"logical-id\": 3"
|
|
" }"
|
|
" ]"
|
|
"}";
|
|
|
|
static const char testQemuAgentCPUArguments1[] =
|
|
"[{\"logical-id\":0,\"online\":true},"
|
|
"{\"logical-id\":1,\"online\":false},"
|
|
"{\"logical-id\":2,\"online\":true},"
|
|
"{\"logical-id\":3,\"online\":false}]";
|
|
|
|
static const char testQemuAgentCPUArguments2[] =
|
|
"[{\"logical-id\":0,\"online\":true},"
|
|
"{\"logical-id\":1,\"online\":true},"
|
|
"{\"logical-id\":2,\"online\":true},"
|
|
"{\"logical-id\":3,\"online\":true}]";
|
|
|
|
static int
|
|
testQemuAgentCPU(const void *data)
|
|
{
|
|
virDomainXMLOptionPtr xmlopt = (virDomainXMLOptionPtr)data;
|
|
qemuMonitorTestPtr test = qemuMonitorTestNewAgent(xmlopt);
|
|
qemuAgentCPUInfoPtr cpuinfo = NULL;
|
|
int nvcpus;
|
|
int ret = -1;
|
|
|
|
if (!test)
|
|
return -1;
|
|
|
|
if (qemuMonitorTestAddAgentSyncResponse(test) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuMonitorTestAddItem(test, "guest-get-vcpus",
|
|
testQemuAgentCPUResponse) < 0)
|
|
goto cleanup;
|
|
|
|
/* get cpus */
|
|
if ((nvcpus = qemuAgentGetVCPUs(qemuMonitorTestGetAgent(test),
|
|
&cpuinfo)) < 0)
|
|
goto cleanup;
|
|
|
|
if (nvcpus != 4) {
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
"Expected '4' cpus, got '%d'", nvcpus);
|
|
goto cleanup;
|
|
}
|
|
|
|
/* try to unplug one */
|
|
if (qemuAgentUpdateCPUInfo(2, cpuinfo, nvcpus) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuMonitorTestAddAgentSyncResponse(test) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuMonitorTestAddItemParams(test, "guest-set-vcpus",
|
|
"{ \"return\" : 4 }",
|
|
"vcpus", testQemuAgentCPUArguments1,
|
|
NULL) < 0)
|
|
goto cleanup;
|
|
|
|
if ((nvcpus = qemuAgentSetVCPUs(qemuMonitorTestGetAgent(test),
|
|
cpuinfo, nvcpus)) < 0)
|
|
goto cleanup;
|
|
|
|
if (nvcpus != 4) {
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
"Expected '4' cpus updated , got '%d'", nvcpus);
|
|
goto cleanup;
|
|
}
|
|
|
|
/* try to hotplug two */
|
|
if (qemuMonitorTestAddAgentSyncResponse(test) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuMonitorTestAddItemParams(test, "guest-set-vcpus",
|
|
"{ \"return\" : 4 }",
|
|
"vcpus", testQemuAgentCPUArguments2,
|
|
NULL) < 0)
|
|
goto cleanup;
|
|
|
|
if (qemuAgentUpdateCPUInfo(4, cpuinfo, nvcpus) < 0)
|
|
goto cleanup;
|
|
|
|
if ((nvcpus = qemuAgentSetVCPUs(qemuMonitorTestGetAgent(test),
|
|
cpuinfo, nvcpus)) < 0)
|
|
goto cleanup;
|
|
|
|
if (nvcpus != 4) {
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
"Expected '4' cpus updated , got '%d'", nvcpus);
|
|
goto cleanup;
|
|
}
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
VIR_FREE(cpuinfo);
|
|
qemuMonitorTestFree(test);
|
|
return ret;
|
|
}
|
|
|
|
|
|
static int
|
|
mymain(void)
|
|
{
|
|
int ret = 0;
|
|
virDomainXMLOptionPtr xmlopt;
|
|
|
|
#if !WITH_YAJL
|
|
fputs("libvirt not compiled with yajl, skipping this test\n", stderr);
|
|
return EXIT_AM_SKIP;
|
|
#endif
|
|
|
|
if (virThreadInitialize() < 0 ||
|
|
!(xmlopt = virQEMUDriverCreateXMLConf(NULL)))
|
|
return EXIT_FAILURE;
|
|
|
|
virEventRegisterDefaultImpl();
|
|
|
|
#define DO_TEST(name) \
|
|
if (virtTestRun(# name, 1, testQemuAgent ## name, xmlopt) < 0) \
|
|
ret = -1
|
|
|
|
DO_TEST(FSFreeze);
|
|
DO_TEST(FSThaw);
|
|
DO_TEST(FSTrim);
|
|
DO_TEST(Suspend);
|
|
DO_TEST(Shutdown);
|
|
DO_TEST(CPU);
|
|
|
|
virObjectUnref(xmlopt);
|
|
|
|
return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE;
|
|
}
|
|
|
|
VIRT_TEST_MAIN(mymain)
|