mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-08-28 03:21:19 +00:00
702713af5a
When getting a list of servers registered for a daemon, it's returned as a dynamically allocated array filled in with pointers to constant strings. Because the array is dynamic, it should be freed when no longer needed (but not the strings!). Even the function that creates the array suggests that. ==19446== 48 bytes in 3 blocks are definitely lost in loss record 821 of 1,034 ==19446== at 0x4C2C28E: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==19446== by 0x54BAFC8: virReallocN (viralloc.c:245) ==19446== by 0x54BB0BE: virExpandN (viralloc.c:294) ==19446== by 0x54BB391: virInsertElementsN (viralloc.c:436) ==19446== by 0x164E3D: virNetDaemonGetServerNames (virnetdaemon.c:217) ==19446== by 0x15616F: adminDaemonListServers (admin_server.c:52) ==19446== by 0x155B8C: adminDispatchConnectListServers (admin.c:151) ==19446== by 0x155FD8: adminDispatchConnectListServersHelper (admin_dispatch.h:101) ==19446== by 0x568E862: virNetServerProgramDispatchCall (virnetserverprogram.c:437) ==19446== by 0x568E3C3: virNetServerProgramDispatch (virnetserverprogram.c:307) ==19446== by 0x5687B5B: virNetServerProcessMsg (virnetserver.c:135) ==19446== by 0x5687C1B: virNetServerHandleJob (virnetserver.c:156) Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
75 lines
1.9 KiB
C
75 lines
1.9 KiB
C
/*
|
|
* admin_server.c: admin methods to manage daemons and clients
|
|
*
|
|
* Copyright (C) 2016 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
* Authors: Erik Skultety <eskultet@redhat.com>
|
|
* Martin Kletzander <mkletzan@redhat.com>
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include "admin_server.h"
|
|
#include "datatypes.h"
|
|
#include "viralloc.h"
|
|
#include "virerror.h"
|
|
#include "virlog.h"
|
|
#include "virnetdaemon.h"
|
|
#include "virnetserver.h"
|
|
#include "virstring.h"
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_ADMIN
|
|
|
|
VIR_LOG_INIT("daemon.admin_server");
|
|
|
|
int
|
|
adminDaemonListServers(virNetDaemonPtr dmn,
|
|
virAdmServerPtr **servers,
|
|
unsigned int flags)
|
|
{
|
|
int ret = -1;
|
|
const char **srv_names = NULL;
|
|
virAdmServerPtr *srvs = NULL;
|
|
size_t i;
|
|
ssize_t nsrvs = 0;
|
|
|
|
virCheckFlags(0, -1);
|
|
|
|
if ((nsrvs = virNetDaemonGetServerNames(dmn, &srv_names)) < 0)
|
|
goto cleanup;
|
|
|
|
if (servers) {
|
|
if (VIR_ALLOC_N(srvs, nsrvs) < 0)
|
|
goto cleanup;
|
|
|
|
for (i = 0; i < nsrvs; i++) {
|
|
if (!(srvs[i] = virAdmGetServer(NULL, srv_names[i])))
|
|
goto cleanup;
|
|
}
|
|
|
|
*servers = srvs;
|
|
srvs = NULL;
|
|
}
|
|
|
|
ret = nsrvs;
|
|
|
|
cleanup:
|
|
VIR_FREE(srv_names);
|
|
virObjectListFree(srvs);
|
|
return ret;
|
|
}
|