External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-09-19 14:10:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
bb9bb55211
libvirt/tools
History
Peter Krempa bb9bb55211 vsh: Fix 'stdin' closing in 'cmdComplete' 
While the 'complete' command is meant to be hidden and used only for
the completion script, there's nothing preventing it being used in all
virsh modes.

This poses a problem as the command tries to close 'stdin' to avoid the
possibility that an auth callback would want to read the password.

In interactive mode this immediately terminates virsh and in
non-interactive mode it attempts to close it multiple times if you use
virsh in batch mode.

Fix the issues by using virOnce() to close it exactly once and do so
only in non-interactive mode.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2024-04-25 14:13:19 +02:00
..
bash-completion
nss libvirt_nss: Fix ERROR() macro 2024-04-18 14:57:30 +02:00
wireshark
libvirt_recover_xattrs.sh
libvirt_win_icon_16x16.ico
libvirt_win_icon_32x32.ico
libvirt_win_icon_48x48.ico
libvirt_win_icon_64x64.ico
libvirt-guests.service.in systemd: More tweaks to Description and Documentation lines 2023-11-06 23:45:04 +01:00
libvirt-guests.sh.in Extend libvirt-guests to shutdown only persistent VMs 2024-04-04 09:10:00 +02:00
meson.build tests: Re-implement '(virsh|virt-admin)-self-test' directly in meson 2024-04-02 14:24:30 +02:00
virsh_win_icon.rc
virsh-backup.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virsh-backup.h backup: Implement virsh support for backup 2019-12-10 12:41:56 +01:00
virsh-checkpoint.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virsh-checkpoint.h
virsh-completer-checkpoint.c
virsh-completer-checkpoint.h
virsh-completer-domain.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virsh-completer-domain.h
virsh-completer-host.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virsh-completer-host.h
virsh-completer-interface.c
virsh-completer-interface.h
virsh-completer-network.c
virsh-completer-network.h
virsh-completer-nodedev.c conf: move/rename hostdev PCI driver type enum to device_conf.h 2024-01-07 23:57:09 -05:00
virsh-completer-nodedev.h
virsh-completer-nwfilter.c
virsh-completer-nwfilter.h
virsh-completer-pool.c virsh-completer: modify and fix bug in virshPoolTypeCompleter, now used for more commands 2024-02-20 12:08:22 +01:00
virsh-completer-pool.h virsh-completer: modify and fix bug in virshPoolTypeCompleter, now used for more commands 2024-02-20 12:08:22 +01:00
virsh-completer-secret.c
virsh-completer-secret.h
virsh-completer-snapshot.c
virsh-completer-snapshot.h
virsh-completer-volume.c
virsh-completer-volume.h
virsh-completer.c
virsh-completer.h
virsh-console.c virsh: Show 'connected to console' message later 2024-04-02 18:26:35 +02:00
virsh-console.h virsh: add console --resume support 2023-10-24 13:51:32 +02:00
virsh-domain-event.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virsh-domain-event.h
virsh-domain-monitor.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virsh-domain-monitor.h
virsh-domain.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virsh-domain.h
virsh-edit.c tools: Update format strings in translated messages (part 1) 2023-04-01 11:40:35 +02:00
virsh-host.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virsh-host.h
virsh-interface.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virsh-interface.h
virsh-network.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virsh-network.h
virsh-nodedev.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virsh-nodedev.h
virsh-nwfilter.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virsh-nwfilter.h
virsh-pool.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virsh-pool.h
virsh-secret.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virsh-secret.h
virsh-snapshot.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virsh-snapshot.h
virsh-util.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virsh-util.h virsh exposure of Network Metadata APIs 2023-08-25 12:36:37 +02:00
virsh-volume.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virsh-volume.h
virsh.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virsh.h virsh: Inline VIRSH_COMMON_OPT_FILE_FULL macro 2024-04-02 14:24:29 +02:00
virt-admin-completer.c
virt-admin-completer.h
virt-admin.c tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00
virt-admin.h
virt-host-validate-bhyve.c virHostValidateBhyve: Heap allocate massive 'struct kld_file_stat' 2023-09-04 10:31:53 +02:00
virt-host-validate-bhyve.h
virt-host-validate-ch.c tools: Move error messages onto a single line 2023-09-04 09:35:36 +02:00
virt-host-validate-ch.h
virt-host-validate-common.c virt-host-validate: Detect SMMU presence on ARMs by parsing IORT table 2023-04-06 12:48:22 +02:00
virt-host-validate-common.h
virt-host-validate-lxc.c
virt-host-validate-lxc.h
virt-host-validate-qemu.c tools: Move error messages onto a single line 2023-09-04 09:35:36 +02:00
virt-host-validate-qemu.h
virt-host-validate.c tools: Update format strings in translated messages (part 2) 2023-04-01 11:40:36 +02:00
virt-login-shell-helper.c tools: Update format strings in translated messages (part 2) 2023-04-01 11:40:36 +02:00
virt-login-shell.c Use G_N_ELEMENTS() more 2023-03-13 13:29:07 +01:00
virt-login-shell.conf
virt-pki-query-dn.c tools: Update format strings in translated messages (part 2) 2023-04-01 11:40:36 +02:00
virt-pki-validate.in meson: Use initconfdir 2023-05-05 15:08:25 +02:00
virt-qemu-qmp-proxy scripts: Fix the flake8 syntax-check failures 2023-06-29 11:51:27 +02:00
virt-qemu-sev-validate vir-qemu-sev-validate: Use string() method in xpath 2023-12-05 12:21:38 +01:00
virt-sanlock-cleanup.in
virt-xml-validate.in
vsh-table.c lib: use struct zero initializer instead of memset 2023-08-03 16:41:19 +02:00
vsh-table.h
vsh.c vsh: Fix 'stdin' closing in 'cmdComplete' 2024-04-25 14:13:19 +02:00
vsh.h tools: Rename vshCommandOptStringReq to vshCommandOptString 2024-04-25 14:13:19 +02:00