mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-22 14:09:22 +00:00
bd3d00babc
When -device is configured via JSON a bug [1] is triggered in qemu were the DEVICE_DELETED event for the removal of the device frontend is no longer delivered to libvirt. Without the DEVICE_DELETED event we don't remove the corresponding entries in the VM XML. Until qemu will be fixed we must stop using the JSON syntax for -device. This patch removes the detection of the capability. The capability is used only during startup of a fresh VM so we don't need to consider any compaitibility steps for existing VMs. For users who wish to use 'libvirt-7.9' and 'libvirt-7.10' with 'qemu-6.2' there are two possible workarounds: - filter out the 'device.json' qemu capability '/etc/libvirt/qemu.conf': capability_filters = [ "device.json" ] - filter out the 'device.json' qemu capability via qemu namespace XML: <domain type='kvm' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'> [...] <qemu:capabilities> <qemu:del capability='device.json'/> </qemu:capabilities> </domain> We must never again use the same capability name as we are now instructing users to filter it as a workaround so once qemu is fixed we'll need to pick a new capability value for it. [1] https://bugzilla.redhat.com/show_bug.cgi?id=2036669 Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2035237 Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ani Sinha <ani@anisinha.ca> Reviewed-by: Ján Tomko <jtomko@redhat.com>
38 lines
1.5 KiB
Plaintext
38 lines
1.5 KiB
Plaintext
LC_ALL=C \
|
|
PATH=/bin \
|
|
HOME=/tmp/lib/domain--1-guest \
|
|
USER=test \
|
|
LOGNAME=test \
|
|
XDG_DATA_HOME=/tmp/lib/domain--1-guest/.local/share \
|
|
XDG_CACHE_HOME=/tmp/lib/domain--1-guest/.cache \
|
|
XDG_CONFIG_HOME=/tmp/lib/domain--1-guest/.config \
|
|
/usr/bin/qemu-system-ppc64 \
|
|
-name guest=guest,debug-threads=on \
|
|
-S \
|
|
-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/tmp/lib/domain--1-guest/master-key.aes"}' \
|
|
-machine pseries-4.2,usb=off,dump-guest-core=off,memory-backend=ppc_spapr.ram \
|
|
-accel kvm \
|
|
-cpu POWER9 \
|
|
-m 4096 \
|
|
-object '{"qom-type":"memory-backend-ram","id":"ppc_spapr.ram","size":4294967296}' \
|
|
-overcommit mem-lock=off \
|
|
-smp 4,sockets=4,cores=1,threads=1 \
|
|
-uuid 1ccfd97d-5eb4-478a-bbe6-88d254c16db7 \
|
|
-display none \
|
|
-no-user-config \
|
|
-nodefaults \
|
|
-chardev socket,id=charmonitor,fd=1729,server=on,wait=off \
|
|
-mon chardev=charmonitor,id=monitor,mode=control \
|
|
-rtc base=utc \
|
|
-no-shutdown \
|
|
-boot strict=on \
|
|
-device pci-ohci,id=usb,bus=pci.0,addr=0x1 \
|
|
-blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/guest.qcow2","node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}' \
|
|
-blockdev '{"node-name":"libvirt-1-format","read-only":false,"driver":"qcow2","file":"libvirt-1-storage"}' \
|
|
-device virtio-blk-pci,bus=pci.0,addr=0x2,drive=libvirt-1-format,id=virtio-disk0,bootindex=1 \
|
|
-chardev pty,id=charserial0 \
|
|
-device spapr-vty,chardev=charserial0,id=serial0,reg=805306368 \
|
|
-audiodev '{"id":"audio1","driver":"none"}' \
|
|
-device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3 \
|
|
-msg timestamp=on
|