libvirt/src
Michal Privoznik c14bd64f3e leaseshelper: Report errors on failure
If leasehelper fails all that we are left with is a simple error
message produced by dnsmasq:

  lease-init script returned exit code 1

This is because the leasehelper did not write any message to
stderr. According to dnsmasq's manpage, whenever it's invoking
leasehelper the stderr is kept open:

  All file descriptors are closed except stdin, which is open to
  /dev/null, and stdout and stderr which capture output for
  logging by dnsmasq.

As debugging leasehelper is not trivial (because dnsmasq invokes
it with plenty of env vars set - that's how data is passed onto
helper), let's print an error into stderr if exiting with an
error. And since we are not calling public APIs, we have to call
virDispatchError() explicitly and since we don't have any
connection open, we have to pass NULL.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
2021-01-04 15:33:30 +01:00
..
access meson: drop use of .path() for python args 2020-11-09 16:32:55 +00:00
admin meson: drop use of .path() for python args 2020-11-09 16:32:55 +00:00
bhyve bhyve: remove redundant code that adds "template" netdev name 2020-12-16 21:31:51 -05:00
conf domain_conf: Allow to look up scsi disks when controller uses a CCW address 2020-12-22 14:16:31 +01:00
cpu lib: Replace VIR_AUTOSTRINGLIST with GStrv 2020-12-02 15:43:07 +01:00
cpu_map cpu_map: sync_qemu_cpu_i386: Detect features missing in libvirt 2020-12-07 15:09:57 +01:00
esx meson: drop use of .path() for python args 2020-11-09 16:32:55 +00:00
hyperv hyperv: remove duplicit addr check 2020-12-10 12:58:54 +01:00
hypervisor util: hash: Retire 'virHashTable' in favor of 'GHashTable' 2020-11-06 10:40:51 +01:00
interface util: Introduce helper functions for generating unique netdev name 2020-12-15 13:35:21 -05:00
keycodemapdb@27acf0ef82
libxl netdevmacvlan: Use helper function to create unique macvlan/macvtap name 2020-12-15 13:35:33 -05:00
locking locking: Resolve mem leak in virLockDaemonPreExecRestart 2020-12-02 16:15:43 +01:00
logging logging: Resolve mem leak in virLogDaemonPreExecRestart 2020-12-02 16:15:43 +01:00
lxc lxd_domain: Require that VIR_LXC_DOMAIN_NAMESPACE_SOURCE_NONE is zero 2020-12-17 09:42:37 +01:00
network leaseshelper: Report errors on failure 2021-01-04 15:33:30 +01:00
node_device node_device: pacify grumpy coverity due to addr override 2020-12-14 12:12:08 +01:00
nwfilter util: hash: Retire 'virHashTable' in favor of 'GHashTable' 2020-11-06 10:40:51 +01:00
openvz openvzDomainMigratePrepare3Params: use g_auto 2020-11-19 15:21:59 +01:00
qemu qemu: Drop has_ccw_address from _qemuAgentDiskAddress 2021-01-04 14:53:08 +01:00
remote remote: make ssh-helper massively faster 2020-11-26 10:14:18 +00:00
rpc lib: Replace VIR_AUTOSTRINGLIST with GStrv 2020-12-02 15:43:07 +01:00
secret secret: use g_new0 instead of VIR_ALLOC* 2020-10-01 12:34:13 +02:00
security apparmor: Drop needless check in AppArmorSetMemoryLabel() 2020-12-04 17:01:42 +01:00
storage lib: Replace VIR_AUTOSTRINGLIST with GStrv 2020-12-02 15:43:07 +01:00
test virDomainCheckpointRedefineCommit: Don't check ABI of definition in checkpoint 2020-12-04 16:15:03 +01:00
util virnetdevopenvswitch: Try to unescape ovs-vsctl reply in one specific case 2020-12-17 09:27:51 +01:00
vbox conf: add support for ESP SCSI controller family 2020-11-20 12:09:51 +00:00
vmware vmware: use g_new0 instead of VIR_ALLOC 2020-10-05 13:07:13 +02:00
vmx lib: Replace VIR_AUTOSTRINGLIST with GStrv 2020-12-02 15:43:07 +01:00
vz virDomainDefValidate: Add per-run 'opaque' data 2020-12-09 09:33:47 +01:00
admin_protocol-structs
datatypes.c
datatypes.h define g_autoptr cleanup function for virNetworkDHCPLease 2020-07-20 19:08:07 -04:00
driver-hypervisor.h virDomainAuthorizedSSHKeysSet: Use uint for @nkeys 2020-11-23 13:35:16 +01:00
driver-interface.h
driver-network.h
driver-nodedev.h
driver-nwfilter.h
driver-secret.h
driver-state.h libvirt: add stateShutdownPrepare/stateShutdownWait to drivers 2020-09-07 09:33:58 +03:00
driver-storage.h
driver-stream.h
driver.c util: use host module suffix when loading drivers 2020-08-26 10:30:18 +02:00
driver.h
internal.h internal.h: Introduce and use VIR_IS_POW2() 2020-12-04 16:24:19 +01:00
libvirt_driver_modules.syms
libvirt_esx.syms
libvirt_internal.h libvirt: add stateShutdownPrepare/stateShutdownWait to drivers 2020-09-07 09:33:58 +03:00
libvirt_libssh2.syms
libvirt_libssh.syms
libvirt_linux.syms
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms virnetdevopenvswitch: Try to unescape ovs-vsctl reply in one specific case 2020-12-17 09:27:51 +01:00
libvirt_probes.d drop libdbus from libvirt 2020-09-17 18:20:33 +02:00
libvirt_public.syms Introduce OpenSSH authorized key file mgmt APIs 2020-11-18 16:18:25 +01:00
libvirt_qemu.syms
libvirt_remote.syms virnetdaemon: Wait for "daemon-stop" thread to finish before quitting 2020-11-24 17:52:54 +01:00
libvirt_sasl.syms
libvirt_vmware.syms
libvirt_vmx.syms vmx: hide private helpers 2020-10-14 11:23:18 +02:00
libvirt-domain-checkpoint.c Fix name prefix of VIR_DOMAIN_CHECKPOINT_REDEFINE_VALIDATE 2020-11-09 16:29:06 +00:00
libvirt-domain-snapshot.c
libvirt-domain.c virDomainGetBlockJobInfo: Reword docs for fallback values 2020-12-07 10:15:00 +01:00
libvirt-host.c Reduce scope of some variables 2020-09-24 11:19:06 +02:00
libvirt-interface.c
libvirt-lxc.c libvirt-lxc: use g_autoptr for virCgroup 2020-10-09 16:24:40 +02:00
libvirt-lxc.pc.in meson: remove '.libs' from all relevant paths 2020-08-03 09:27:00 +02:00
libvirt-network.c
libvirt-nodedev.c virsh: nodedev: filter by AP Matrix capability 2020-12-09 14:03:05 +01:00
libvirt-nwfilter.c
libvirt-qemu.c
libvirt-qemu.pc.in meson: remove '.libs' from all relevant paths 2020-08-03 09:27:00 +02:00
libvirt-secret.c
libvirt-storage.c libvirt-storage: Document volume upload/download stream format 2020-08-24 13:32:53 +02:00
libvirt-stream.c src: libvirt-stream: use g_new0 instead of VIR_ALLOC* 2020-10-01 12:34:13 +02:00
libvirt.c libvirt: ensure defresult is used in virConnectAuthCallbackDefault 2020-09-22 16:43:47 +01:00
libvirt.conf
libvirt.pc.in meson: remove '.libs' from all relevant paths 2020-08-03 09:27:00 +02:00
lock_protocol-structs
lxc_monitor_protocol-structs
lxc_protocol-structs
meson.build meson: drop use of .path() for python args 2020-11-09 16:32:55 +00:00
qemu_protocol-structs
README
remote_protocol-structs remote: Implement OpenSSH authorized key file mgmt APIs 2020-11-18 16:18:25 +01:00
virkeepaliveprotocol-structs
virnetprotocol-structs

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * bhyve         - bhyve - The BSD Hypervisor
 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU and Xen drivers.
The ESX, Hyper-V, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories