mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-30 01:43:23 +00:00
a8743c3938
Since its introduction in 2011 (particularly in commit f4324e3292),
the option doesn't work. It just effectively disables all incoming
connections. That's because the client private data that contain the
'keepalive_supported' boolean, are initialized to zeroes so the bool is
false and the only other place where the bool is used is when checking
whether the client supports keepalive. Thus, according to the server,
no client supports keepalive.
Removing this instead of fixing it is better because a) apparently
nobody ever tried it since 2011 (4 years without one month) and b) we
cannot know whether the client supports keepalive until we get a ping or
pong keepalive packet. And that won't happen until after we dispatched
the ConnectOpen call.
Another two reasons would be c) the keepalive_required was tracked on
the server level, but keepalive_supported was in private data of the
client as well as the check that was made in the remote layer, thus
making all other instances of virNetServer miss this feature unless they
all implemented it for themselves and d) we can always add it back in
case there is a request and a use-case for it.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
107 lines
2.7 KiB
C
107 lines
2.7 KiB
C
/*
|
|
* libvirtd-config.h: daemon start of day, guest process & i/o management
|
|
*
|
|
* Copyright (C) 2006-2012, 2015 Red Hat, Inc.
|
|
* Copyright (C) 2006 Daniel P. Berrange
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
* Author: Daniel P. Berrange <berrange@redhat.com>
|
|
*/
|
|
|
|
#ifndef __LIBVIRTD_CONFIG_H__
|
|
# define __LIBVIRTD_CONFIG_H__
|
|
|
|
# include "internal.h"
|
|
|
|
struct daemonConfig {
|
|
char *host_uuid;
|
|
|
|
int listen_tls;
|
|
int listen_tcp;
|
|
char *listen_addr;
|
|
char *tls_port;
|
|
char *tcp_port;
|
|
|
|
char *unix_sock_admin_perms;
|
|
char *unix_sock_ro_perms;
|
|
char *unix_sock_rw_perms;
|
|
char *unix_sock_group;
|
|
char *unix_sock_dir;
|
|
|
|
int auth_unix_rw;
|
|
int auth_unix_ro;
|
|
int auth_tcp;
|
|
int auth_tls;
|
|
|
|
char **access_drivers;
|
|
|
|
int mdns_adv;
|
|
char *mdns_name;
|
|
|
|
int tls_no_verify_certificate;
|
|
int tls_no_sanity_certificate;
|
|
char **tls_allowed_dn_list;
|
|
char **sasl_allowed_username_list;
|
|
|
|
char *key_file;
|
|
char *cert_file;
|
|
char *ca_file;
|
|
char *crl_file;
|
|
|
|
int min_workers;
|
|
int max_workers;
|
|
int max_clients;
|
|
int max_queued_clients;
|
|
int max_anonymous_clients;
|
|
|
|
int prio_workers;
|
|
|
|
int max_requests;
|
|
int max_client_requests;
|
|
|
|
int log_level;
|
|
char *log_filters;
|
|
char *log_outputs;
|
|
|
|
int audit_level;
|
|
int audit_logging;
|
|
|
|
int keepalive_interval;
|
|
unsigned int keepalive_count;
|
|
|
|
int admin_min_workers;
|
|
int admin_max_workers;
|
|
int admin_max_clients;
|
|
int admin_max_queued_clients;
|
|
int admin_max_client_requests;
|
|
|
|
int admin_keepalive_interval;
|
|
unsigned int admin_keepalive_count;
|
|
};
|
|
|
|
|
|
int daemonConfigFilePath(bool privileged, char **configfile);
|
|
struct daemonConfig* daemonConfigNew(bool privileged);
|
|
void daemonConfigFree(struct daemonConfig *data);
|
|
int daemonConfigLoadFile(struct daemonConfig *data,
|
|
const char *filename,
|
|
bool allow_missing);
|
|
int daemonConfigLoadData(struct daemonConfig *data,
|
|
const char *filename,
|
|
const char *filedata);
|
|
|
|
#endif /* __LIBVIRTD_CONFIG_H__ */
|