mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-22 13:45:38 +00:00
086f37e97a
We use the function to create a virDomainXMLOption object that is required for some functions. However, we don't pass the driver pointer to the object anywhere - rather than pass NULL. This causes trouble later when parsing a domain XML and calling post parse callbacks: Program received signal SIGSEGV, Segmentation fault. 0x000000000043fa3e in qemuDomainDefPostParse (def=0x7d36c0, caps=0x7caf10, opaque=0x0) at qemu/qemu_domain.c:1043 1043 qemuCaps = virQEMUCapsCacheLookup(driver->qemuCapsCache, def->emulator); (gdb) bt #0 0x000000000043fa3e in qemuDomainDefPostParse (def=0x7d36c0, caps=0x7caf10, opaque=0x0) at qemu/qemu_domain.c:1043 #1 0x00007ffff2928bf9 in virDomainDefPostParse (def=0x7d36c0, caps=0x7caf10, xmlopt=0x7c82c0) at conf/domain_conf.c:4269 #2 0x00007ffff294de04 in virDomainDefParseXML (xml=0x7da8c0, root=0x7dab80, ctxt=0x7da980, caps=0x7caf10, xmlopt=0x7c82c0, flags=0) at conf/domain_conf.c:16400 #3 0x00007ffff294e5b5 in virDomainDefParseNode (xml=0x7da8c0, root=0x7dab80, caps=0x7caf10, xmlopt=0x7c82c0, flags=0) at conf/domain_conf.c:16582 #4 0x00007ffff294e424 in virDomainDefParse (xmlStr=0x0, filename=0x7c7ef0 "/home/zippy/work/libvirt/libvirt.git/tests/securityselinuxlabeldata/disks.xml", caps=0x7caf10, xmlopt=0x7c82c0, flags=0) at conf/domain_conf.c:16529 #5 0x00007ffff294e4b2 in virDomainDefParseFile (filename=0x7c7ef0 "/home/zippy/work/libvirt/libvirt.git/tests/securityselinuxlabeldata/disks.xml", caps=0x7caf10, xmlopt=0x7c82c0, flags=0) at conf/domain_conf.c:16553 #6 0x00000000004303ca in testSELinuxLoadDef (testname=0x53c929 "disks") at securityselinuxlabeltest.c:192 #7 0x00000000004309e8 in testSELinuxLabeling (opaque=0x53c929) at securityselinuxlabeltest.c:313 #8 0x0000000000431207 in virtTestRun (title=0x53c92f "Labelling \"disks\"", body=0x430964 <testSELinuxLabeling>, data=0x53c929) at testutils.c:211 #9 0x0000000000430c5d in mymain () at securityselinuxlabeltest.c:373 #10 0x00000000004325c2 in virtTestMain (argc=1, argv=0x7fffffffd7e8, func=0x430b4a <mymain>) at testutils.c:863 #11 0x0000000000430deb in main (argc=1, argv=0x7fffffffd7e8) at securityselinuxlabeltest.c:381 Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
200 lines
5.3 KiB
C
200 lines
5.3 KiB
C
/*
|
|
* Copyright (C) 2011-2013 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include "testutils.h"
|
|
#include "testutilsqemu.h"
|
|
#include "qemumonitortestutils.h"
|
|
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_NONE
|
|
|
|
typedef struct _testQemuData testQemuData;
|
|
typedef testQemuData *testQemuDataPtr;
|
|
struct _testQemuData {
|
|
virDomainXMLOptionPtr xmlopt;
|
|
const char *base;
|
|
};
|
|
|
|
static qemuMonitorTestPtr
|
|
testQemuFeedMonitor(char *replies,
|
|
virDomainXMLOptionPtr xmlopt)
|
|
{
|
|
qemuMonitorTestPtr test = NULL;
|
|
char *tmp = replies;
|
|
char *singleReply = tmp;
|
|
|
|
/* Our JSON parser expects replies to be separated by a newline character.
|
|
* Hence we must preprocess the file a bit. */
|
|
while ((tmp = strchr(tmp, '\n'))) {
|
|
/* It is safe to touch tmp[1] since all strings ends with '\0'. */
|
|
bool eof = !tmp[1];
|
|
|
|
if (*(tmp + 1) != '\n') {
|
|
*tmp = ' ';
|
|
tmp++;
|
|
} else {
|
|
/* Cut off a single reply. */
|
|
*(tmp + 1) = '\0';
|
|
|
|
if (test) {
|
|
if (qemuMonitorTestAddItem(test, NULL, singleReply) < 0)
|
|
goto error;
|
|
} else {
|
|
/* Create new mocked monitor with our greeting */
|
|
if (!(test = qemuMonitorTestNew(true, xmlopt, NULL, NULL, singleReply)))
|
|
goto error;
|
|
}
|
|
|
|
if (!eof) {
|
|
/* Move the @tmp and @singleReply. */
|
|
tmp += 2;
|
|
singleReply = tmp;
|
|
}
|
|
}
|
|
|
|
if (eof)
|
|
break;
|
|
}
|
|
|
|
if (test && qemuMonitorTestAddItem(test, NULL, singleReply) < 0)
|
|
goto error;
|
|
|
|
return test;
|
|
|
|
error:
|
|
qemuMonitorTestFree(test);
|
|
return NULL;
|
|
}
|
|
|
|
static int
|
|
testQemuCapsCompare(virQEMUCapsPtr capsProvided,
|
|
virQEMUCapsPtr capsComputed)
|
|
{
|
|
int ret = 0;
|
|
size_t i;
|
|
|
|
for (i = 0; i < QEMU_CAPS_LAST; i++) {
|
|
if (virQEMUCapsGet(capsProvided, i) &&
|
|
!virQEMUCapsGet(capsComputed, i)) {
|
|
fprintf(stderr, "Caps mismatch: capsComputed is missing %s\n",
|
|
virQEMUCapsTypeToString(i));
|
|
ret = -1;
|
|
}
|
|
|
|
if (virQEMUCapsGet(capsComputed, i) &&
|
|
!virQEMUCapsGet(capsProvided, i)) {
|
|
fprintf(stderr, "Caps mismatch: capsProvided is missing %s\n",
|
|
virQEMUCapsTypeToString(i));
|
|
ret = -1;
|
|
}
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int
|
|
testQemuCaps(const void *opaque)
|
|
{
|
|
int ret = -1;
|
|
const testQemuData *data = opaque;
|
|
char *repliesFile = NULL, *capsFile = NULL;
|
|
char *replies = NULL;
|
|
qemuMonitorTestPtr mon = NULL;
|
|
virQEMUCapsPtr capsProvided = NULL, capsComputed = NULL;
|
|
|
|
if (virAsprintf(&repliesFile, "%s/qemucapabilitiesdata/%s.replies",
|
|
abs_srcdir, data->base) < 0 ||
|
|
virAsprintf(&capsFile, "%s/qemucapabilitiesdata/%s.caps",
|
|
abs_srcdir, data->base) < 0)
|
|
goto cleanup;
|
|
|
|
if (virtTestLoadFile(repliesFile, &replies) < 0)
|
|
goto cleanup;
|
|
|
|
if (!(mon = testQemuFeedMonitor(replies, data->xmlopt)))
|
|
goto cleanup;
|
|
|
|
if (!(capsProvided = qemuTestParseCapabilities(capsFile)))
|
|
goto cleanup;
|
|
|
|
if (!(capsComputed = virQEMUCapsNew()))
|
|
goto cleanup;
|
|
|
|
if (virQEMUCapsInitQMPMonitor(capsComputed,
|
|
qemuMonitorTestGetMonitor(mon)) < 0)
|
|
goto cleanup;
|
|
|
|
if (testQemuCapsCompare(capsProvided, capsComputed) < 0)
|
|
goto cleanup;
|
|
|
|
ret = 0;
|
|
cleanup:
|
|
VIR_FREE(repliesFile);
|
|
VIR_FREE(capsFile);
|
|
VIR_FREE(replies);
|
|
qemuMonitorTestFree(mon);
|
|
virObjectUnref(capsProvided);
|
|
virObjectUnref(capsComputed);
|
|
return ret;
|
|
}
|
|
|
|
static int
|
|
mymain(void)
|
|
{
|
|
int ret = 0;
|
|
virQEMUDriver driver;
|
|
testQemuData data;
|
|
|
|
#if !WITH_YAJL
|
|
fputs("libvirt not compiled with yajl, skipping this test\n", stderr);
|
|
return EXIT_AM_SKIP;
|
|
#endif
|
|
|
|
if (virThreadInitialize() < 0 ||
|
|
qemuTestDriverInit(&driver) < 0)
|
|
return EXIT_FAILURE;
|
|
|
|
virEventRegisterDefaultImpl();
|
|
|
|
data.xmlopt = driver.xmlopt;
|
|
|
|
#define DO_TEST(name) \
|
|
do { \
|
|
data.base = name; \
|
|
if (virtTestRun(name, testQemuCaps, &data) < 0) \
|
|
ret = -1; \
|
|
} while (0)
|
|
|
|
DO_TEST("caps_1.2.2-1");
|
|
DO_TEST("caps_1.3.1-1");
|
|
DO_TEST("caps_1.4.2-1");
|
|
DO_TEST("caps_1.5.3-1");
|
|
DO_TEST("caps_1.6.0-1");
|
|
DO_TEST("caps_1.6.50-1");
|
|
DO_TEST("caps_2.1.1-1");
|
|
|
|
qemuTestDriverFree(&driver);
|
|
|
|
return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE;
|
|
}
|
|
|
|
VIRT_TEST_MAIN(mymain)
|