mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-20 04:59:49 +00:00
ac7f3667f2
In our meson scripts, we use configure_file(copy:true) to copy
files from srcdir into builddir. However, as of meson-0.64.0,
this is deprecated [1] in favor of using:
fs = import('fs')
fs.copyfile(in, out)
Except, the submodule's new method wasn't introduced until
0.64.0. And since we can't bump the minimal meson version we
require, we have to work with both: new and old versions.
Now, the fun part: fs.copyfile() is not a drop in replacement as
it returns different type (a custom_target object). This is
incompatible with places where we store the configure_file()
retval in a variable to process it further.
While we could just replace 'copy:true' with a dummy
'configuration:...' (say 'configuration: configmake_conf') we
can't do that for binary files (like src/fonts/ or src/images/).
Therefore, places where we are not interested in the retval can
be switched to fs.copyfile() and places where we are interested
in the retval will just use a dummy 'configuration:'.
Except, src/network/meson.build. In here we not just copy the
file but also specify alternative install dir and that's not
something that fs.copyfile() can handle. Yet, using 'copy: true'
is viewed wrong [2].
1: https://mesonbuild.com/Release-notes-for-0-64-0.html#fscopyfile-to-replace-configure_filecopy-true
2: https://github.com/mesonbuild/meson/pull/10042
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
|
||
|---|---|---|
| .. | ||
| css | ||
| fonts | ||
| gitdm | ||
| go | ||
| html | ||
| images | ||
| js | ||
| kbase | ||
| logos | ||
| manpages | ||
| 404.rst | ||
| acl.html.in | ||
| aclpolkit.rst | ||
| advanced-tests.rst | ||
| android-chrome-192x192.png | ||
| android-chrome-256x256.png | ||
| api_extension.rst | ||
| api.rst | ||
| apple-touch-icon.png | ||
| apps.rst | ||
| auditlog.rst | ||
| auth.rst | ||
| best-practices.rst | ||
| bindings.rst | ||
| browserconfig.xml | ||
| bugs.rst | ||
| cgroups.rst | ||
| ci-dashboard.rst | ||
| ci-runners.rst | ||
| ci.rst | ||
| coding-style.rst | ||
| committer-guidelines.rst | ||
| compiling.rst | ||
| contact.rst | ||
| contribute.rst | ||
| csharp.rst | ||
| daemons.rst | ||
| dbus.rst | ||
| docs.rst | ||
| downloads.rst | ||
| drivers.rst | ||
| drvbhyve.rst | ||
| drvch.rst | ||
| drvesx.rst | ||
| drvhyperv.rst | ||
| drvlxc.rst | ||
| drvnodedev.rst | ||
| drvopenvz.rst | ||
| drvqemu.rst | ||
| drvsecret.rst | ||
| drvtest.rst | ||
| drvvbox.rst | ||
| drvvirtuozzo.rst | ||
| drvvmware.rst | ||
| drvxen.rst | ||
| errors.rst | ||
| favicon-16x16.png | ||
| favicon-32x32.png | ||
| favicon.ico | ||
| firewall.rst | ||
| format.rst | ||
| formatbackup.rst | ||
| formatcaps.rst | ||
| formatcheckpoint.rst | ||
| formatdomain.rst | ||
| formatdomaincaps.rst | ||
| formatnetwork.rst | ||
| formatnetworkport.rst | ||
| formatnode.rst | ||
| formatnwfilter.rst | ||
| formatsecret.rst | ||
| formatsnapshot.rst | ||
| formatstorage.rst | ||
| formatstoragecaps.rst | ||
| formatstorageencryption.rst | ||
| glib-adoption.rst | ||
| goals.rst | ||
| golang.rst | ||
| governance.rst | ||
| hacking.rst | ||
| hooks.rst | ||
| index.html.in | ||
| issue-handling.rst | ||
| java.rst | ||
| libvirt-go-xml.rst | ||
| libvirt-go.rst | ||
| logging.rst | ||
| macos.rst | ||
| manifest.json | ||
| meson.build | ||
| migration.rst | ||
| mstile-150x150.png | ||
| newapi.xsl | ||
| newreposetup.rst | ||
| nss.rst | ||
| page.xsl | ||
| pci-addresses.rst | ||
| pci-hotplug.rst | ||
| platforms.rst | ||
| programming-languages.rst | ||
| python.rst | ||
| remote.rst | ||
| securityprocess.rst | ||
| site.xsl | ||
| storage.rst | ||
| strategy.rst | ||
| styleguide.rst | ||
| submitting-patches.rst | ||
| support.rst | ||
| testapi.rst | ||
| testing.rst | ||
| testtck.rst | ||
| uri.rst | ||
| windows.rst | ||
