mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-23 14:15:28 +00:00
709 lines
25 KiB
Makefile
709 lines
25 KiB
Makefile
# This is reported not to work with make-3.79.1
|
|
# ME := $(word $(words $(MAKEFILE_LIST)),$(MAKEFILE_LIST))
|
|
ME := Makefile.maint
|
|
|
|
# Do not save the original name or timestamp in the .tar.gz file.
|
|
# Use --rsyncable if available.
|
|
gzip_rsyncable := \
|
|
$(shell gzip --help 2>/dev/null|grep rsyncable >/dev/null && echo --rsyncable)
|
|
GZIP_ENV = '--no-name --best $(gzip_rsyncable)'
|
|
|
|
VC_LIST = $(srcdir)/build-aux/vc-list-files
|
|
|
|
VC_LIST_EXCEPT = \
|
|
$(VC_LIST) | if test -f .x-$@; then grep -vEf .x-$@; else grep -v ChangeLog; fi
|
|
|
|
# Prevent programs like 'sort' from considering distinct strings to be equal.
|
|
# Doing it here saves us from having to set LC_ALL elsewhere in this file.
|
|
export LC_ALL = C
|
|
|
|
# Collect the names of rules starting with `sc_'.
|
|
syntax-check-rules := $(shell sed -n 's/^\(sc_[a-zA-Z0-9_-]*\):.*/\1/p' \
|
|
$(srcdir)/$(ME))
|
|
.PHONY: $(syntax-check-rules)
|
|
|
|
local-checks-available = \
|
|
po-check copyright-check m4-check author_mark_check \
|
|
patch-check strftime-check $(syntax-check-rules) \
|
|
makefile_path_separator_check \
|
|
makefile-check check-AUTHORS
|
|
.PHONY: $(local-checks-available)
|
|
|
|
local-check := $(filter-out $(local-checks-to-skip), $(local-checks-available))
|
|
|
|
syntax-check: $(local-check)
|
|
# @grep -nE '# *include <(limits|std(def|arg|bool))\.h>' \
|
|
# $$(find -type f -name '*.[chly]') && \
|
|
# { echo '$(ME): found conditional include' 1>&2; \
|
|
# exit 1; } || :
|
|
|
|
# grep -nE '^# *include <(string|stdlib)\.h>' \
|
|
# $(srcdir)/{lib,src}/*.[chy] && \
|
|
# { echo '$(ME): FIXME' 1>&2; \
|
|
# exit 1; } || :
|
|
# FIXME: don't allow `#include .strings\.h' anywhere
|
|
|
|
sc_avoid_if_before_free:
|
|
@$(srcdir)/build-aux/useless-if-before-free \
|
|
$(useless_free_options) \
|
|
$$($(VC_LIST_EXCEPT)) && \
|
|
{ echo '$(ME): found useless "if" before "free" above' 1>&2; \
|
|
exit 1; } || :
|
|
|
|
# Avoid uses of write(2). Either switch to streams (fwrite), or use
|
|
# the safewrite wrapper.
|
|
sc_avoid_write:
|
|
@if $(VC_LIST_EXCEPT) | grep '\.c$$' > /dev/null; then \
|
|
grep '\<write *(' $$($(VC_LIST_EXCEPT) | grep '\.c$$') && \
|
|
{ echo "$(ME): the above files use write;" \
|
|
" consider using the safewrite wrapper instead" \
|
|
1>&2; exit 1; } || :; \
|
|
else :; \
|
|
fi
|
|
|
|
sc_cast_of_argument_to_free:
|
|
@grep -nE '\<free *\( *\(' $$($(VC_LIST_EXCEPT)) && \
|
|
{ echo '$(ME): don'\''t cast free argument' 1>&2; \
|
|
exit 1; } || :
|
|
|
|
sc_cast_of_x_alloc_return_value:
|
|
@grep -nE '\*\) *x(m|c|re)alloc\>' $$($(VC_LIST_EXCEPT)) && \
|
|
{ echo '$(ME): don'\''t cast x*alloc return value' 1>&2; \
|
|
exit 1; } || :
|
|
|
|
sc_cast_of_alloca_return_value:
|
|
@grep -nE '\*\) *alloca\>' $$($(VC_LIST_EXCEPT)) && \
|
|
{ echo '$(ME): don'\''t cast alloca return value' 1>&2; \
|
|
exit 1; } || :
|
|
|
|
sc_space_tab:
|
|
@grep -n '[ ] ' $$($(VC_LIST_EXCEPT)) && \
|
|
{ echo '$(ME): found SPACE-TAB sequence; remove the SPACE' \
|
|
1>&2; exit 1; } || :
|
|
|
|
cvs_keywords = \
|
|
Author|Date|Header|Id|Name|Locker|Log|RCSfile|Revision|Source|State
|
|
|
|
sc_prohibit_cvs_keyword:
|
|
@grep -nE '\$$($(cvs_keywords))\$$' $$($(VC_LIST_EXCEPT)) && \
|
|
{ echo '$(ME): do not use CVS keyword expansion ' \
|
|
1>&2; exit 1; } || :
|
|
|
|
# Don't use *scanf or the old ato* functions in `real' code.
|
|
# They provide no error checking mechanism.
|
|
# Instead, use strto* functions.
|
|
sc_prohibit_atoi_atof:
|
|
@grep -nE '\<([fs]?scanf|ato([filq]|ll))\>' $$($(VC_LIST_EXCEPT)) && \
|
|
{ echo '$(ME): do not use *scan''f, ato''f, ato''i, ato''l, ato''ll, ato''q, or ss''canf' \
|
|
1>&2; exit 1; } || :
|
|
|
|
# Use STREQ rather than comparing strcmp == 0, or != 0.
|
|
# Similarly, use STREQLEN or STRPREFIX rather than strncmp.
|
|
sc_prohibit_strcmp:
|
|
@grep -nE '! *strn?cmp *\(|\<strn?cmp *\([^)]+\) *==' \
|
|
$$($(VC_LIST_EXCEPT)) \
|
|
| grep -vE ':# *define STREQ(LEN)?\(' && \
|
|
{ echo '$(ME): use STREQ(LEN) in place of the above uses of strcmp(strncmp)' \
|
|
1>&2; exit 1; } || :
|
|
|
|
# Use virAsprintf rather than a'sprintf since *strp is undefined on error.
|
|
sc_prohibit_asprintf:
|
|
@grep -nE '\<[a]sprintf\>' $$($(VC_LIST_EXCEPT)) && \
|
|
{ echo '$(ME): use virAsprintf, not a'sprintf 1>&2; exit 1; } || :
|
|
|
|
# Using EXIT_SUCCESS as the first argument to error is misleading,
|
|
# since when that parameter is 0, error does not exit. Use `0' instead.
|
|
sc_error_exit_success:
|
|
@grep -nF 'error (EXIT_SUCCESS,' \
|
|
$$(find -type f -name '*.[chly]') && \
|
|
{ echo '$(ME): found error (EXIT_SUCCESS' 1>&2; \
|
|
exit 1; } || :
|
|
|
|
sc_file_system:
|
|
@grep -ni 'file''system' $$($(VC_LIST_EXCEPT)) && \
|
|
{ echo '$(ME): found use of "file''system";' \
|
|
'rewrite to use "file system"' 1>&2; \
|
|
exit 1; } || :
|
|
|
|
# Don't use cpp tests of this symbol. All code assumes config.h is included.
|
|
sc_no_have_config_h:
|
|
@grep -n '^# *if.*HAVE''_CONFIG_H' $$($(VC_LIST_EXCEPT)) && \
|
|
{ echo '$(ME): found use of HAVE''_CONFIG_H; remove' \
|
|
1>&2; exit 1; } || :
|
|
|
|
# Nearly all .c files must include <config.h>.
|
|
sc_require_config_h:
|
|
@if $(VC_LIST_EXCEPT) | grep '\.c$$' > /dev/null; then \
|
|
grep -L '^# *include <config\.h>' \
|
|
$$($(VC_LIST_EXCEPT) | grep '\.c$$') \
|
|
| grep . && \
|
|
{ echo '$(ME): the above files do not include <config.h>' \
|
|
1>&2; exit 1; } || :; \
|
|
else :; \
|
|
fi
|
|
|
|
# You must include <config.h> before including any other header file.
|
|
sc_require_config_h_first:
|
|
@if $(VC_LIST_EXCEPT) | grep '\.c$$' > /dev/null; then \
|
|
fail=0; \
|
|
for i in $$($(VC_LIST_EXCEPT) | grep '\.c$$'); do \
|
|
grep '^# *include\>' $$i | sed 1q \
|
|
| grep '^# *include <config\.h>' > /dev/null \
|
|
|| { echo $$i; fail=1; }; \
|
|
done; \
|
|
test $$fail = 1 && \
|
|
{ echo '$(ME): the above files include some other header' \
|
|
'before <config.h>' 1>&2; exit 1; } || :; \
|
|
else :; \
|
|
fi
|
|
|
|
# To use this "command" macro, you must first define two shell variables:
|
|
# h: the header, enclosed in <> or ""
|
|
# re: a regular expression that matches IFF something provided by $h is used.
|
|
define _header_without_use
|
|
h_esc=`echo "$$h"|sed 's/\./\\./'`; \
|
|
if $(VC_LIST_EXCEPT) | grep '\.c$$' > /dev/null; then \
|
|
files=$$(grep -l '^# *include '"$$h_esc" \
|
|
$$($(VC_LIST_EXCEPT) | grep '\.c$$')) && \
|
|
grep -LE "$$re" $$files | grep . && \
|
|
{ echo "$(ME): the above files include $$h but don't use it" \
|
|
1>&2; exit 1; } || :; \
|
|
else :; \
|
|
fi
|
|
endef
|
|
|
|
# Prohibit the inclusion of assert.h without an actual use of assert.
|
|
sc_prohibit_assert_without_use:
|
|
@h='<assert.h>' re='\<assert *\(' $(_header_without_use)
|
|
|
|
# Prohibit the inclusion of getopt.h without an actual use.
|
|
sc_prohibit_getopt_without_use:
|
|
@h='<getopt.h>' re='\<getopt(_long)? *\(' $(_header_without_use)
|
|
|
|
# Don't include quotearg.h unless you use one of its functions.
|
|
sc_prohibit_quotearg_without_use:
|
|
@h='"quotearg.h"' re='\<quotearg(_[^ ]+)? *\(' $(_header_without_use)
|
|
|
|
# Don't include quote.h unless you use one of its functions.
|
|
sc_prohibit_quote_without_use:
|
|
@h='"quote.h"' re='\<quote(_n)? *\(' $(_header_without_use)
|
|
|
|
# Prohibit the inclusion of c-ctype.h without an actual use.
|
|
sc_prohibit_c_ctype_without_use:
|
|
@h='[<"]c-ctype.h[">]' re='\<c_($(ctype_re)) *\(' $(_header_without_use)
|
|
|
|
# Prohibit the inclusion of <ctype.h>.
|
|
sc_prohibit_ctype_h:
|
|
@grep -E '^# *include *<ctype\.h>' $$($(VC_LIST_EXCEPT)) && \
|
|
{ echo "$(ME): don't use ctype.h; instead, use c-ctype.h" \
|
|
1>&2; exit 1; } || :
|
|
|
|
sc_obsolete_symbols:
|
|
@grep -nE '\<(HAVE''_FCNTL_H|O''_NDELAY)\>' \
|
|
$$($(VC_LIST_EXCEPT)) && \
|
|
{ echo '$(ME): do not use HAVE''_FCNTL_H or O''_NDELAY' \
|
|
1>&2; exit 1; } || :
|
|
|
|
# FIXME: warn about definitions of EXIT_FAILURE, EXIT_SUCCESS, STREQ
|
|
|
|
# Each nonempty line must start with a year number, or a TAB.
|
|
# Or day-of-week+space.
|
|
changelog_entry_header_regexp = \
|
|
([12][0-9][0-9][0-9]| .|(Mon|Tue|Wed|Thu|Fri|Sat|Sun) )
|
|
sc_changelog:
|
|
@grep -Evn '(^$$|^$(changelog_entry_header_regexp))' \
|
|
$$(find . -maxdepth 2 -name ChangeLog) && \
|
|
{ echo '$(ME): found unexpected prefix in a ChangeLog' 1>&2; \
|
|
exit 1; } || :
|
|
|
|
# Ensure that dd's definition of LONGEST_SYMBOL stays in sync
|
|
# with the strings from the two affected variables.
|
|
dd_c = $(srcdir)/src/dd.c
|
|
sc_dd_max_sym_length:
|
|
ifneq ($(wildcard $(dd_c)),)
|
|
@len=$$( (sed -n '/conversions\[\] =$$/,/^};/p' $(dd_c);\
|
|
sed -n '/flags\[\] =$$/,/^};/p' $(dd_c) ) \
|
|
|sed -n '/"/s/^[^"]*"\([^"]*\)".*/\1/p' \
|
|
| wc --max-line-length); \
|
|
max=$$(sed -n '/^#define LONGEST_SYMBOL /s///p' $(dd_c) \
|
|
|tr -d '"' | wc --max-line-length); \
|
|
if test "$$len" = "$$max"; then :; else \
|
|
echo 'dd.c: LONGEST_SYMBOL is not longest' 1>&2; \
|
|
exit 1; \
|
|
fi
|
|
endif
|
|
|
|
# Many m4 macros names once began with `jm_'.
|
|
# On 2004-04-13, they were all changed to start with gl_ instead.
|
|
# Make sure that none are inadvertently reintroduced.
|
|
sc_prohibit_jm_in_m4:
|
|
@grep -nE 'jm_[A-Z]' \
|
|
$$($(VC_LIST) m4 |grep '\.m4$$'; echo /dev/null) && \
|
|
{ echo '$(ME): do not use jm_ in m4 macro names' \
|
|
1>&2; exit 1; } || :
|
|
|
|
# Ensure that each root-requiring test is run via the "check-root" rule.
|
|
sc_root_tests:
|
|
@if test -d tests \
|
|
&& grep check-root tests/Makefile.am>/dev/null 2>&1; then \
|
|
t1=sc-root.expected; t2=sc-root.actual; \
|
|
grep -nl '^require_root_$$' \
|
|
$$($(VC_LIST) tests) |sed s,tests/,, |sort > $$t1; \
|
|
sed -n '/^root_tests =[ ]*\\$$/,/[^\]$$/p' \
|
|
$(srcdir)/tests/Makefile.am \
|
|
| sed 's/^ *//;/^root_tests =/d' \
|
|
| tr -s '\012\\' ' ' | fmt -1 | sort > $$t2; \
|
|
diff -u $$t1 $$t2 || diff=1; \
|
|
rm -f $$t1 $$t2; \
|
|
test "$$diff" \
|
|
&& { echo 'tests/Makefile.am: missing check-root action'>&2; \
|
|
exit 1; } || :; \
|
|
fi
|
|
|
|
headers_with_interesting_macro_defs = \
|
|
exit.h \
|
|
fcntl_.h \
|
|
fnmatch_.h \
|
|
intprops.h \
|
|
inttypes_.h \
|
|
lchown.h \
|
|
openat.h \
|
|
stat-macros.h \
|
|
stdint_.h
|
|
|
|
# Create a list of regular expressions matching the names
|
|
# of macros that are guaranteed by parts of gnulib to be defined.
|
|
.re-defmac:
|
|
@(cd $(srcdir)/lib; \
|
|
for f in $(headers_with_interesting_macro_defs); do \
|
|
test -f $$f && \
|
|
sed -n '/^# *define \([^_ (][^ (]*\)[ (].*/s//\1/p' $$f; \
|
|
done; \
|
|
) | sort -u \
|
|
| grep -Ev 'ATTRIBUTE_NORETURN|SIZE_MAX' \
|
|
| sed 's/^/^# *define /' \
|
|
> $@-t
|
|
@mv $@-t $@
|
|
|
|
# Don't define macros that we already get from gnulib header files.
|
|
sc_always_defined_macros: .re-defmac
|
|
@if test -f $(srcdir)/src/system.h; then \
|
|
trap 'rc=$$?; rm -f .re-defmac; exit $$rc' 0 1 2 3 15; \
|
|
grep -f .re-defmac $$($(VC_LIST)) \
|
|
&& { echo '$(ME): define the above via some gnulib .h file' \
|
|
1>&2; exit 1; } || :; \
|
|
fi
|
|
|
|
# Create a list of regular expressions matching the names
|
|
# of files included from system.h. Exclude a couple.
|
|
.re-list:
|
|
@sed -n '/^# *include /s///p' $(srcdir)/src/system.h \
|
|
| grep -Ev 'sys/(param|file)\.h' \
|
|
| sed 's/ .*//;;s/^["<]/^# *include [<"]/;s/\.h[">]$$/\\.h[">]/' \
|
|
> $@-t
|
|
@mv $@-t $@
|
|
|
|
# Files in src/ should not include directly any of
|
|
# the headers already included via system.h.
|
|
sc_system_h_headers: .re-list
|
|
@if test -f $(srcdir)/src/system.h; then \
|
|
trap 'rc=$$?; rm -f .re-list; exit $$rc' 0 1 2 3 15; \
|
|
grep -nE -f .re-list \
|
|
$$($(VC_LIST) src | \
|
|
grep -Ev '((copy|system)\.h|parse-gram\.c)$$') \
|
|
&& { echo '$(ME): the above are already included via system.h'\
|
|
1>&2; exit 1; } || :; \
|
|
fi
|
|
|
|
sc_sun_os_names:
|
|
@grep -nEi \
|
|
'solaris[^[:alnum:]]*2\.(7|8|9|[1-9][0-9])|sunos[^[:alnum:]][6-9]' \
|
|
$$($(VC_LIST_EXCEPT)) && \
|
|
{ echo '$(ME): found misuse of Sun OS version numbers' 1>&2; \
|
|
exit 1; } || :
|
|
|
|
sc_the_the:
|
|
@grep -ni '\<the ''the\>' $$($(VC_LIST_EXCEPT)) && \
|
|
{ echo '$(ME): found use of "the ''the";' 1>&2; \
|
|
exit 1; } || :
|
|
|
|
sc_tight_scope:
|
|
$(MAKE) -C src $@
|
|
|
|
sc_trailing_blank:
|
|
@grep -n '[ ]$$' $$($(VC_LIST_EXCEPT)) && \
|
|
{ echo '$(ME): found trailing blank(s)' \
|
|
1>&2; exit 1; } || :
|
|
|
|
# Ensure that no C source file uses TABs for indentation.
|
|
# Also match *.h.in files, to get libvirt.h.in.
|
|
# Exclude files in gnulib, since they're imported.
|
|
sc_TAB_in_indentation:
|
|
@grep -lE '^ * ' /dev/null \
|
|
$$($(VC_LIST_EXCEPT) \
|
|
| grep -E '\.[ch](\.in)?$$' \
|
|
| grep -v '^gnulib/') && \
|
|
{ echo '$(ME): found TAB(s) used for indentation in C sources;'\
|
|
'use spaces' 1>&2; exit 1; } || :
|
|
|
|
ctype_re = isalnum|isalpha|isascii|isblank|iscntrl|isdigit|isgraph|islower\
|
|
|isprint|ispunct|isspace|isupper|isxdigit|tolower|toupper
|
|
|
|
sc_avoid_ctype_macros:
|
|
@grep -E '\b($(ctype_re)) *\(' /dev/null \
|
|
$$($(VC_LIST_EXCEPT)) && \
|
|
{ echo "$(ME): don't use ctype macros (use c-ctype.h)" \
|
|
1>&2; exit 1; } || :
|
|
|
|
# Match lines like the following, but where there is only one space
|
|
# between the options and the description:
|
|
# -D, --all-repeated[=delimit-method] print all duplicate lines\n
|
|
longopt_re = --[a-z][0-9A-Za-z-]*(\[?=[0-9A-Za-z-]*\]?)?
|
|
sc_two_space_separator_in_usage:
|
|
@grep -nE '^ *(-[A-Za-z],)? $(longopt_re) [^ ].*\\$$' \
|
|
$$($(VC_LIST_EXCEPT)) && \
|
|
{ echo "$(ME): help2man requires at least two spaces between"; \
|
|
echo "$(ME): an option and its description"; \
|
|
1>&2; exit 1; } || :
|
|
|
|
# Many of the function names below came from this filter:
|
|
# git grep -B2 '\<_('|grep -E '\.c- *[[:alpha:]_][[:alnum:]_]* ?\(.*[,;]$' \
|
|
# |sed 's/.*\.c- *//'|perl -pe 's/ ?\(.*//'|sort -u \
|
|
# |grep -vE '^(qsort|if|close|assert|fputc|free|N_|vir.*GetName|.*Unlock|virNodeListDevices|virHashRemoveEntry|freeaddrinfo|.*[fF]ree|xdrmem_create|xmlXPathFreeObject|virUUIDFormat|openvzSetProgramSentinal|polkit_action_unref)$'
|
|
|
|
msg_gen_function =
|
|
msg_gen_function += DEBUG0
|
|
msg_gen_function += DISABLE_fprintf
|
|
msg_gen_function += ERROR
|
|
msg_gen_function += ERROR0
|
|
msg_gen_function += REMOTE_DEBUG
|
|
msg_gen_function += ReportError
|
|
msg_gen_function += VIR_FREE
|
|
msg_gen_function += VIR_USE_CPU
|
|
msg_gen_function += errorf
|
|
msg_gen_function += lxcError
|
|
msg_gen_function += networkLog
|
|
msg_gen_function += networkReportError
|
|
msg_gen_function += openvzError
|
|
msg_gen_function += openvzLog
|
|
msg_gen_function += qemudDispatchClientFailure
|
|
msg_gen_function += qemudLog
|
|
msg_gen_function += qemudReportError
|
|
msg_gen_function += regerror
|
|
msg_gen_function += remoteDispatchError
|
|
msg_gen_function += remoteDispatchFormatError
|
|
msg_gen_function += umlError
|
|
msg_gen_function += umlLog
|
|
msg_gen_function += umlReportError
|
|
msg_gen_function += virConfError
|
|
msg_gen_function += virDomainReportError
|
|
msg_gen_function += virHashError
|
|
msg_gen_function += virLibConnError
|
|
msg_gen_function += virLibDomainError
|
|
msg_gen_function += virLog
|
|
msg_gen_function += virNetworkReportError
|
|
msg_gen_function += virNodeDeviceReportError
|
|
msg_gen_function += virRaiseError
|
|
msg_gen_function += virReportErrorHelper
|
|
msg_gen_function += virSexprError
|
|
msg_gen_function += virStorageLog
|
|
msg_gen_function += virStorageReportError
|
|
msg_gen_function += virTestError
|
|
msg_gen_function += virXMLError
|
|
msg_gen_function += virXenInotifyError
|
|
msg_gen_function += virXenStoreError
|
|
msg_gen_function += virXendError
|
|
msg_gen_function += virxmlRpcError
|
|
msg_gen_function += vshCloseLogFile
|
|
msg_gen_function += xenXMError
|
|
|
|
# Uncomment the following and run "make syntax-check" to see diagnostics
|
|
# that are not yet marked for translation, but that need to be rewritten
|
|
# so that they are translatable.
|
|
# msg_gen_function += error
|
|
# msg_gen_function += fprintf
|
|
# msg_gen_function += testError
|
|
# msg_gen_function += virXenError
|
|
# msg_gen_function += vshPrint
|
|
# msg_gen_function += vshError
|
|
|
|
func_or := $(shell printf '$(msg_gen_function)'|tr -s '[[:space:]]' '|')
|
|
func_re := ($(func_or))
|
|
|
|
# Look for diagnostics that aren't marked for translation.
|
|
# This won't find any for which error's format string is on a separate line.
|
|
# The sed filters eliminate false-positives like these:
|
|
# _("...: "
|
|
# "%s", _("no storage vol w..."
|
|
sc_unmarked_diagnostics:
|
|
@grep -nE \
|
|
'\<$(func_re) \([^"]*"[^"]*[a-z]{3}' $$($(VC_LIST_EXCEPT)) \
|
|
| grep -v '_''(' && \
|
|
{ echo '$(ME): found unmarked diagnostic(s)' 1>&2; \
|
|
exit 1; } || :
|
|
@{ grep -nE '\<$(func_re) *\(.*;$$' $$($(VC_LIST_EXCEPT)); \
|
|
grep -A1 -nE '\<$(func_re) *\(.*,$$' $$($(VC_LIST_EXCEPT)); } \
|
|
| sed 's/_("[^"][^"]*"//;s/[ ]"%s"//' \
|
|
| grep '[ ]"' && \
|
|
{ echo '$(ME): found unmarked diagnostic(s)' 1>&2; \
|
|
exit 1; } || :
|
|
|
|
sc_prohibit_virBufferAdd_with_string_literal:
|
|
@grep -nE '\<virBufferAdd *\([^,]+, *"[^"]' $$($(VC_LIST_EXCEPT)) && \
|
|
{ echo '$(ME): use virBufferAddLit, not virBufferAdd,' \
|
|
'with a string literal' 1>&2; exit 1; } || :
|
|
|
|
# Not only do they fail to deal well with ipv6, but the gethostby*
|
|
# functions are also not thread-safe.
|
|
sc_prohibit_gethostby:
|
|
@grep -nE '\<gethostby(addr|name2?) *\(' $$($(VC_LIST_EXCEPT)) && \
|
|
{ echo '$(ME): use getaddrinfo, not gethostby*' 1>&2; exit 1; } || :
|
|
|
|
# Avoid useless parentheses like those in this example:
|
|
# #if defined (SYMBOL) || defined (SYM2)
|
|
sc_useless_cpp_parens:
|
|
@grep -n '^# *if .*defined *(' $$($(VC_LIST_EXCEPT)) && \
|
|
{ echo '$(ME): found useless parentheses in cpp directive' \
|
|
1>&2; exit 1; } || :
|
|
|
|
# Require the latest GPL.
|
|
sc_GPL_version:
|
|
@grep -n 'either ''version [^3]' $$($(VC_LIST_EXCEPT)) && \
|
|
{ echo '$(ME): GPL vN, N!=3' 1>&2; exit 1; } || :
|
|
|
|
# Ensure that the c99-to-c89 patch applies cleanly.
|
|
patch-check:
|
|
rm -rf src-c89 $@.1 $@.2
|
|
cp -a $(srcdir)/src src-c89
|
|
if test "x$(srcdir)" != x.; then \
|
|
cp -a src/* src-c89; \
|
|
dotfiles=`ls src/.[!.]* 2>/dev/null`; \
|
|
test -z "$$dotfiles" || cp -a src/.[!.]* src-c89; \
|
|
fi
|
|
(cd src-c89; patch -p1 -V never --fuzz=0) < $(srcdir)/src/c99-to-c89.diff \
|
|
> $@.1 2>&1
|
|
if test "$(REGEN_PATCH)" = yes; then \
|
|
diff -upr $(srcdir)/src src-c89 | sed 's,$(srcdir)/src-c89/,src/,' \
|
|
| grep -vE '^(Only in|File )' \
|
|
| perl -pe 's/^((?:\+\+\+|---) \S+\t).*/$${1}$(epoch_date)/;' \
|
|
-e 's/^ $$//' \
|
|
> new-diff || : ; fi
|
|
grep -v '^patching file ' $@.1 > $@.2 || :
|
|
msg=ok; test -s $@.2 && msg='fuzzy patch' || : ; \
|
|
rm -f src-c89/*.o || msg='rm failed'; \
|
|
$(MAKE) -C src-c89 CFLAGS='-Wdeclaration-after-statement -Werror' \
|
|
|| msg='compile failure with extra options'; \
|
|
test "$$msg" = ok && rm -rf src-c89 $@.1 $@.2 || echo "$$msg" 1>&2; \
|
|
test "$$msg" = ok
|
|
|
|
# Ensure that date's --help output stays in sync with the info
|
|
# documentation for GNU strftime. The only exception is %N,
|
|
# which date accepts but GNU strftime does not.
|
|
extract_char = sed 's/^[^%][^%]*%\(.\).*/\1/'
|
|
strftime-check:
|
|
@if test -f $(srcdir)/src/date.c; then \
|
|
grep '^ %. ' $(srcdir)/src/date.c | sort \
|
|
| $(extract_char) > $@-src; \
|
|
{ echo N; \
|
|
info libc date calendar format | grep '^ `%.'\' \
|
|
| $(extract_char); } | sort > $@-info; \
|
|
diff -u $@-src $@-info || exit 1; \
|
|
rm -f $@-src $@-info; \
|
|
fi
|
|
|
|
check-AUTHORS:
|
|
$(MAKE) -C src $@
|
|
|
|
# Ensure that we use only the standard $(VAR) notation,
|
|
# not @...@ in Makefile.am, now that we can rely on automake
|
|
# to emit a definition for each substituted variable.
|
|
makefile-check:
|
|
grep -nE '@[A-Z_0-9]+@' `find . -name Makefile.am` \
|
|
&& { echo 'Makefile.maint: use $$(...), not @...@' 1>&2; exit 1; } || :
|
|
|
|
news-date-check: NEWS
|
|
today=`date +%Y-%m-%d`; \
|
|
if head NEWS | grep '^\*.* $(VERSION_REGEXP) ('$$today')' \
|
|
>/dev/null; then \
|
|
:; \
|
|
else \
|
|
echo "version or today's date is not in NEWS" 1>&2; \
|
|
exit 1; \
|
|
fi
|
|
|
|
changelog-check:
|
|
if head ChangeLog | grep 'Version $(VERSION_REGEXP)\.$$' \
|
|
>/dev/null; then \
|
|
:; \
|
|
else \
|
|
echo "$(VERSION) not in ChangeLog" 1>&2; \
|
|
exit 1; \
|
|
fi
|
|
|
|
m4-check:
|
|
@grep -n 'AC_DEFUN([^[]' $(srcdir)/m4/*.m4 \
|
|
&& { echo '$(ME): quote the first arg to AC_DEFUN' 1>&2; \
|
|
exit 1; } || :
|
|
|
|
fix_po_file_diag = \
|
|
'you have changed the set of files with translatable diagnostics;\n\
|
|
apply the above patch\n'
|
|
|
|
# Verify that all source files using _() are listed in po/POTFILES.in.
|
|
po_file = po/POTFILES.in
|
|
po-check:
|
|
@if test -f $(po_file); then \
|
|
grep -E -v '^(#|$$)' $(po_file) \
|
|
| grep -v '^src/false\.c$$' | sort > $@-1; \
|
|
files=; \
|
|
for file in $$($(VC_LIST_EXCEPT)); do \
|
|
case $$file in \
|
|
*.m4) continue;; \
|
|
*.?|*.??) ;; \
|
|
*) continue;; \
|
|
esac; \
|
|
case $$file in \
|
|
*.[ch]) \
|
|
base=`expr " $$file" : ' \(.*\)\..'`; \
|
|
{ test -f $$base.l || test -f $$base.y; } && continue;; \
|
|
esac; \
|
|
files="$$files $$file"; \
|
|
done; \
|
|
grep -E -l '\b(N?_|gettext *)\([^)"]*("|$$)' $$files \
|
|
| sort -u > $@-2; \
|
|
diff -u -L $(po_file) -L $(po_file) $@-1 $@-2 \
|
|
|| { printf '$(ME): '$(fix_po_file_diag) 1>&2; exit 1; }; \
|
|
rm -f $@-1 $@-2; \
|
|
fi
|
|
|
|
# In a definition of #define AUTHORS "... and ..." where the RHS contains
|
|
# the English word `and', the string must be marked with `N_ (...)' so that
|
|
# gettext recognizes it as a string requiring translation.
|
|
author_mark_check:
|
|
@grep -n '^# *define AUTHORS "[^"]* and ' src/*.c |grep -v ' N_ (' && \
|
|
{ echo '$(ME): enclose the above strings in N_ (...)' 1>&2; \
|
|
exit 1; } || :
|
|
|
|
# Sometimes it is useful to change the PATH environment variable
|
|
# in Makefiles. When doing so, it's better not to use the Unix-centric
|
|
# path separator of `:', but rather the automake-provided `@PATH_SEPARATOR@'.
|
|
# It'd be better to use `find -print0 ...|xargs -0 ...', but less portable,
|
|
# and there probably aren't many projects with so many Makefile.am files
|
|
# that we'd have to worry about limits on command line length.
|
|
msg = '$(ME): Do not use `:'\'' above; use @PATH_SEPARATOR@ instead'
|
|
makefile_path_separator_check:
|
|
@grep -n 'PATH=.*:' `find $(srcdir) -name Makefile.am` \
|
|
&& { echo $(msg) 1>&2; exit 1; } || :
|
|
|
|
# Check that `make alpha' will not fail at the end of the process.
|
|
writable-files:
|
|
if test -d $(release_archive_dir); then :; else \
|
|
for file in $(distdir).tar.gz \
|
|
$(release_archive_dir)/$(distdir).tar.gz; do \
|
|
test -e $$file || continue; \
|
|
test -w $$file \
|
|
|| { echo ERROR: $$file is not writable; fail=1; }; \
|
|
done; \
|
|
test "$$fail" && exit 1 || : ; \
|
|
fi
|
|
|
|
v_etc_file = lib/version-etc.c
|
|
sample-test = tests/sample-test
|
|
texi = doc/$(PACKAGE).texi
|
|
# Make sure that the copyright date in $(v_etc_file) is up to date.
|
|
# Do the same for the $(sample-test) and the main doc/.texi file.
|
|
copyright-check:
|
|
@if test -f $(v_etc_file); then \
|
|
grep 'enum { COPYRIGHT_YEAR = '$$(date +%Y)' };' $(v_etc_file) \
|
|
>/dev/null \
|
|
|| { echo 'out of date copyright in $(v_etc_file); update it' 1>&2; \
|
|
exit 1; }; \
|
|
fi
|
|
@if test -f $(sample-test); then \
|
|
grep '# Copyright (C) '$$(date +%Y)' Free' $(sample-test) \
|
|
>/dev/null \
|
|
|| { echo 'out of date copyright in $(sample-test); update it' 1>&2; \
|
|
exit 1; }; \
|
|
fi
|
|
@if test -f $(texi); then \
|
|
grep 'Copyright @copyright{} .*'$$(date +%Y)' Free' $(texi) \
|
|
>/dev/null \
|
|
|| { echo 'out of date copyright in $(texi); update it' 1>&2; \
|
|
exit 1; }; \
|
|
fi
|
|
|
|
vc-diff-check:
|
|
$(VC) diff > vc-diffs || :
|
|
if test -s vc-diffs; then \
|
|
cat vc-diffs; \
|
|
echo "Some files are locally modified:" 1>&2; \
|
|
exit 1; \
|
|
else \
|
|
rm vc-diffs; \
|
|
fi
|
|
|
|
cvs-check: vc-diff-check
|
|
|
|
maintainer-distcheck:
|
|
$(MAKE) distcheck
|
|
$(MAKE) my-distcheck
|
|
|
|
# Use -Wformat -Werror to detect format-string/arg-list mismatches.
|
|
# Also, check for shadowing problems with -Wshadow, and for pointer
|
|
# arithmetic problems with -Wpointer-arith.
|
|
# These CFLAGS are pretty strict. If you build this target, you probably
|
|
# have to have a recent version of gcc and glibc headers.
|
|
# The hard-linking for-loop below ensures that there is a bin/ directory
|
|
# full of all of the programs under test (except the ones that are required
|
|
# for basic Makefile rules), all symlinked to the just-built "false" program.
|
|
# This is to ensure that if ever a test neglects to make PATH include
|
|
# the build srcdir, these always-failing programs will run.
|
|
# Otherwise, it is too easy to test the wrong programs.
|
|
# Note that "false" itself is a symlink to true, so it too will malfunction.
|
|
TMPDIR ?= /tmp
|
|
t=$(TMPDIR)/$(PACKAGE)/test
|
|
my-distcheck: $(DIST_ARCHIVES) $(local-check)
|
|
$(MAKE) syntax-check
|
|
$(MAKE) check
|
|
-rm -rf $(t)
|
|
mkdir -p $(t)
|
|
GZIP=$(GZIP_ENV) $(AMTAR) -C $(t) -zxf $(distdir).tar.gz
|
|
cd $(t)/$(distdir) \
|
|
&& ./configure --disable-nls \
|
|
&& $(MAKE) CFLAGS='$(warn_cflags)' \
|
|
AM_MAKEFLAGS='$(null_AM_MAKEFLAGS)' \
|
|
&& $(MAKE) dvi \
|
|
&& $(MAKE) distclean
|
|
(cd $(t) && mv $(distdir) $(distdir).old \
|
|
&& $(AMTAR) -zxf - ) < $(distdir).tar.gz
|
|
diff -ur $(t)/$(distdir).old $(t)/$(distdir)
|
|
-rm -rf $(t)
|
|
@echo "========================"; \
|
|
echo "$(distdir).tar.gz is ready for distribution"; \
|
|
echo "========================"
|
|
|
|
cvs-to-git = '\#!/usr/bin/perl\n\
|
|
use warnings;\n\
|
|
use strict;\n\
|
|
use File::Find;\n\
|
|
use File::Copy;\n\
|
|
\n\
|
|
find ({wanted =>\n\
|
|
sub {$$_ eq q/.cvsignore/ or return;\n\
|
|
my $$gi = q/.gitignore/;\n\
|
|
unlink $$gi;\n\
|
|
copy($$_, $$gi) or die qq/copy failed: $$_->$$gi: $$!\\n/;\n\
|
|
chmod 0444, $$gi;\n\
|
|
}},\n\
|
|
q!.!);\n'
|
|
|
|
.PHONY: sync-vcs-ignore-files
|
|
c2g = cvs-to-git
|
|
sync-vcs-ignore-files:
|
|
rm -f $(c2g)-t $(c2g)
|
|
printf $(cvs-to-git) > $(c2g)-t
|
|
chmod a+x-w $(c2g)-t
|
|
mv $(c2g)-t $(c2g)
|
|
perl $(c2g)
|
|
rm -f $(c2g)
|