libvirt/src
Daniel P. Berrange b3fb288e52 Fix tracking of RPC messages wrt streams
Commit 2c85644b0b attempted to
fix a problem with tracking RPC messages from streams by doing

-            if (msg->header.type == VIR_NET_REPLY) {
+            if (msg->header.type == VIR_NET_REPLY ||
+                (msg->header.type == VIR_NET_STREAM &&
+                 msg->header.status != VIR_NET_CONTINUE)) {
                 client->nrequests--;

In other words any stream packet, with status NET_OK or NET_ERROR
would cause nrequests to be decremented. This is great if the
packet from from a synchronous virStreamFinish or virStreamAbort
API call, but wildly wrong if from a server initiated abort.
The latter resulted in 'nrequests' being decremented below zero.
This then causes all I/O for that client to be stopped.

Instead of trying to infer whether we need to decrement the
nrequests field, from the message type/status, introduce an
explicit 'bool tracked' field to mark whether the virNetMessagePtr
object is subject to tracking.

Also add a virNetMessageClear function to allow a message
contents to be cleared out, without adversely impacting the
'tracked' field as a naive memset() would do

* src/rpc/virnetmessage.c, src/rpc/virnetmessage.h: Add
  a 'bool tracked' field and virNetMessageClear() API
* daemon/remote.c, daemon/stream.c, src/rpc/virnetclientprogram.c,
  src/rpc/virnetclientstream.c, src/rpc/virnetserverclient.c,
  src/rpc/virnetserverprogram.c: Switch over to use
  virNetMessageClear() and pass in the 'bool tracked' value
  when creating messages.
2011-09-01 10:52:35 +01:00
..
conf conf: Substitute OPERATION_INVALID with INTERNAL_ERROR 2011-09-01 17:31:24 +08:00
cpu maint: simplify lots of libxml2 clients 2011-08-19 09:13:55 -06:00
esx esx: Refactor a repeated string in the generator 2011-08-23 23:15:21 +02:00
hyperv hyperv: Add basic driver for Microsoft Hyper-V 2011-08-26 17:52:55 +02:00
interface libvirt: do not mix internal flags into public API 2011-07-18 13:50:51 -06:00
libxl Stop libxl driver polluting logs on non-Xen hosts 2011-08-31 17:53:01 +01:00
locking Fix incorrect path length check in sanlock lockspace setup 2011-08-31 11:07:31 +01:00
lxc lxc: Fix incorrect changes on error codes. 2011-09-01 17:34:31 +08:00
network Introduce functions for checking whether a pidfile is valid 2011-08-12 20:37:00 +01:00
node_device pci: Move some pci sriov helper code out of node device driver to util/pci 2011-08-16 11:59:00 -04:00
nwfilter nwfilter: tolerate disappearing interfaces while instantiating filter 2011-08-11 06:56:50 -04:00
openvz openvz: Allow to undefine a running domain 2011-08-19 21:48:47 +08:00
phyp destroy: Implement internal API for phyp driver 2011-07-21 20:41:27 +02:00
qemu qemu: Fix a regression of domain save 2011-09-01 17:38:20 +08:00
remote remote: Fix incorrect error codes 2011-09-01 17:35:56 +08:00
rpc Fix tracking of RPC messages wrt streams 2011-09-01 10:52:35 +01:00
secret build: rename files.h to virfile.h 2011-07-21 10:34:51 -06:00
security Remove bogus virSecurityManagerSetProcessFDLabel method 2011-08-31 11:07:31 +01:00
storage Fix parted sector size assumption 2011-09-01 10:46:31 +01:00
test Revert "test: Cleanup improper VIR_ERR_NO_SUPPORT use" 2011-09-01 17:37:11 +08:00
uml uml: Allow to undefine a running domain 2011-08-19 21:51:42 +08:00
util Don't leak memory if a cgroup is mounted multiple times 2011-08-31 17:51:09 +01:00
vbox vbox, xenapi: add virDomainUndefineFlags 2011-08-12 07:44:54 -06:00
vmware vmware: Allow to undefine a running domain 2011-08-19 21:52:12 +08:00
vmx conf: add <listen> subelement to domain <graphics> element 2011-07-28 13:46:39 -04:00
xen xen: Cleanup improper VIR_ERR_NO_SUPPORT use 2011-08-23 16:53:15 +08:00
xenapi vbox, xenapi: add virDomainUndefineFlags 2011-08-12 07:44:54 -06:00
xenxs maint: fix comment typos 2011-08-23 11:31:28 -06:00
.gitignore util: add missing export 2010-10-12 09:42:18 -06:00
datatypes.c virStorageVol: avoid PATH_MAX-sized array 2011-06-22 17:13:58 -06:00
datatypes.h conf: prefer unsigned flags 2011-07-13 17:05:10 -06:00
driver.c libvirt: do not mix internal flags into public API 2011-07-18 13:50:51 -06:00
driver.h hyperv: Add driver skeleton 2011-08-26 17:52:55 +02:00
fdstream.c fdstream: drop delete argument 2011-08-02 14:53:43 -06:00
fdstream.h fdstream: drop delete argument 2011-08-02 14:53:43 -06:00
gnutls_1_0_compat.h Fix detection of GnuTLS 1.x.y 2011-08-03 19:22:29 +02:00
internal.h maint: fix typos on guaranteed 2011-07-20 16:53:31 -06:00
libvirt_bridge.syms Replace brSetInetAddress/brSetInetNetmask with brAddInetAddress 2010-12-23 15:53:26 -05:00
libvirt_daemon.syms
libvirt_driver_modules.syms
libvirt_internal.h qemu: Migration job on source daemon 2011-07-27 08:45:10 -06:00
libvirt_linux.syms
libvirt_macvtap.syms Fix undefined symbol errors when macvtap support is disabled 2010-12-01 17:08:08 +01:00
libvirt_network.syms network: provide internal API to return IP of a network 2011-07-25 13:48:55 +08:00
libvirt_nwfilter.syms
libvirt_private.syms security: fix build 2011-08-31 08:33:17 -06:00
libvirt_public.syms Add new API virDomainBlockPull* to headers 2011-07-22 13:18:06 +08:00
libvirt_qemu.syms Define a QEMU specific API to attach to a running QEMU process 2011-07-12 15:39:03 +01:00
libvirt_vmx.syms esx: Move VMX handling code out of the driver directory 2010-12-21 22:40:17 +01:00
libvirt_xenxs.syms Fix build with --with-driver-modules enabled 2011-05-27 09:51:28 +02:00
libvirt-qemu.c maint: print flags in hex during debug 2011-07-13 07:47:45 -06:00
libvirt.c snapshot: forbid snapshot on autodestroy domain 2011-08-30 11:03:54 -06:00
Makefile.am hyperv: Add basic driver for Microsoft Hyper-V 2011-08-26 17:52:55 +02:00
nodeinfo.c nodeinfo: Fix incorrect error codes 2011-09-01 17:35:23 +08:00
nodeinfo.h build: avoid ATTRIBUTE_UNUSED in headers 2011-07-14 07:51:30 -06:00
qemu_protocol-structs build: also track RPC on-wire enum values 2011-07-15 17:48:09 -06:00
README hyperv: Add basic documentation 2011-08-26 17:52:55 +02:00
remote_protocol-structs Asynchronous event for BlockJob completion 2011-07-22 13:57:42 +08:00
virnetprotocol-structs build: also track RPC on-wire enum values 2011-07-15 17:48:09 -06:00

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * phyp/         - IBM Power Hypervisor using CLI tools over SSH
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * uml/          - User Mode Linux
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore
 * xenapi/       - Xen using libxenserver


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers.
The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories