mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-08-01 06:27:16 +00:00
9a0ec36346
The public API documents that undefine may be used to transition a running persistent domain into a transient one. Many drivers still do not support this usage, but virsh shouldn't be getting in the way of those that do support it. This also drops a redundant conditional; vshCommandOptString guaranteed that name was non-NULL. * tools/virsh.c (cmdUndefine): Allow undefine on active domains; the drivers may still reject it, but it is a valid API usage. * tests/undefine (error): Fix the test to match.
61 lines
1.9 KiB
Bash
Executable File
61 lines
1.9 KiB
Bash
Executable File
#!/bin/sh
|
|
# exercise virsh's "undefine" command
|
|
|
|
# Copyright (C) 2008-2009, 2011 Red Hat, Inc.
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHEXP ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
test -z "$srcdir" && srcdir=$(pwd)
|
|
test -z "$abs_top_srcdir" && abs_top_srcdir=$(pwd)/..
|
|
test -z "$abs_top_builddir" && abs_top_builddir=$(pwd)/..
|
|
|
|
if test "$VERBOSE" = yes; then
|
|
set -x
|
|
$abs_top_builddir/tools/virsh --version
|
|
fi
|
|
|
|
. "$srcdir/test-lib.sh"
|
|
|
|
fail=0
|
|
|
|
# Attempt to undefine a running domain, by domain name.
|
|
# Although the API allows this, the test hypervisor does not.
|
|
$abs_top_builddir/tools/virsh -q -c test:///default undefine test > out 2>&1
|
|
test $? = 1 || fail=1
|
|
cat <<\EOF > exp || fail=1
|
|
error: Failed to undefine domain test
|
|
error: internal error Domain 'test' is still running
|
|
EOF
|
|
compare exp out || fail=1
|
|
|
|
# A similar diagnostic when specifying a domain ID
|
|
$abs_top_builddir/tools/virsh -q -c test:///default undefine 1 > out 2>&1
|
|
test $? = 1 || fail=1
|
|
cat <<\EOF > exp || fail=1
|
|
error: Failed to undefine domain 1
|
|
error: internal error Domain 'test' is still running
|
|
EOF
|
|
compare exp out || fail=1
|
|
|
|
# Succeed, now: first shut down, then undefine, both via name.
|
|
$abs_top_builddir/tools/virsh -q -c test:///default 'shutdown test; undefine test' > out 2>&1
|
|
test $? = 0 || fail=1
|
|
cat <<\EOF > exp || fail=1
|
|
Domain test is being shutdown
|
|
Domain test has been undefined
|
|
EOF
|
|
compare exp out || fail=1
|
|
|
|
(exit $fail); exit $fail
|