mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-03 16:42:37 +00:00
d3475e71bc
The term "permitted list" is a better choice for the filtering logic applied. Reviewed-by: Peter Krempa <pkrempa@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
126 lines
3.7 KiB
Python
Executable File
126 lines
3.7 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
#
|
|
# Copyright (C) 2016-2019 Red Hat, Inc.
|
|
#
|
|
# This library is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU Lesser General Public
|
|
# License as published by the Free Software Foundation; either
|
|
# version 2.1 of the License, or (at your option) any later version.
|
|
#
|
|
# This library is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# Lesser General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Lesser General Public
|
|
# License along with this library. If not, see
|
|
# <http://www.gnu.org/licenses/>.
|
|
#
|
|
# This script is supposed to check test_file_access.txt file and
|
|
# warn about file accesses outside our working tree.
|
|
#
|
|
#
|
|
|
|
import re
|
|
import sys
|
|
|
|
if len(sys.argv) != 3:
|
|
print("syntax: %s ACCESS-FILE PERMITTED-ACCESS-FILE")
|
|
sys.exit(1)
|
|
|
|
access_file = sys.argv[1]
|
|
permitted_file = sys.argv[2]
|
|
|
|
known_actions = ["open", "fopen", "access", "stat", "lstat", "connect"]
|
|
|
|
files = []
|
|
permitted = []
|
|
|
|
with open(access_file, "r") as fh:
|
|
for line in fh:
|
|
line = line.rstrip("\n")
|
|
|
|
m = re.search(r'''^(\S*):\s*(\S*):\s*(\S*)(\s*:\s*(.*))?$''', line)
|
|
if m is not None:
|
|
rec = {
|
|
"path": m.group(1),
|
|
"action": m.group(2),
|
|
"progname": m.group(3),
|
|
"testname": m.group(5),
|
|
}
|
|
files.append(rec)
|
|
else:
|
|
raise Exception("Malformed line %s" % line)
|
|
|
|
with open(permitted_file, "r") as fh:
|
|
for line in fh:
|
|
line = line.rstrip("\n")
|
|
|
|
if re.search(r'''^\s*#.*$''', line):
|
|
continue # comment
|
|
if line == "":
|
|
continue
|
|
|
|
m = re.search(r'''^(\S*):\s*(\S*)(:\s*(\S*)(\s*:\s*(.*))?)?$''', line)
|
|
if m is not None and m.group(2) in known_actions:
|
|
# $path: $action: $progname: $testname
|
|
rec = {
|
|
"path": m.group(1),
|
|
"action": m.group(3),
|
|
"progname": m.group(4),
|
|
"testname": m.group(6),
|
|
}
|
|
permitted.append(rec)
|
|
else:
|
|
m = re.search(r'''^(\S*)(:\s*(\S*)(\s*:\s*(.*))?)?$''', line)
|
|
if m is not None:
|
|
# $path: $progname: $testname
|
|
rec = {
|
|
"path": m.group(1),
|
|
"action": None,
|
|
"progname": m.group(3),
|
|
"testname": m.group(5),
|
|
}
|
|
permitted.append(rec)
|
|
else:
|
|
raise Exception("Malformed line %s" % line)
|
|
|
|
|
|
# Now we should check if %traces is included in $permitted. For
|
|
# now checking just keys is sufficient
|
|
err = False
|
|
for file in files:
|
|
match = False
|
|
|
|
for rule in permitted:
|
|
if not re.match("^" + rule["path"] + "$", file["path"]):
|
|
continue
|
|
|
|
if (rule["action"] is not None and
|
|
not re.match("^" + rule["action"] + "$", file["action"])):
|
|
continue
|
|
|
|
if (rule["progname"] is not None and
|
|
not re.match("^" + rule["progname"] + "$", file["progname"])):
|
|
continue
|
|
|
|
if (rule["testname"] is not None and
|
|
file["testname"] is not None and
|
|
not re.match("^" + rule["testname"] + "$", file["testname"])):
|
|
continue
|
|
|
|
match = True
|
|
|
|
if not match:
|
|
err = True
|
|
print("%s: %s: %s" %
|
|
(file["path"], file["action"], file["progname"]),
|
|
end="")
|
|
if file["testname"] is not None:
|
|
print(": %s" % file["testname"], end="")
|
|
print("")
|
|
|
|
if err:
|
|
sys.exit(1)
|
|
sys.exit(0)
|