mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-30 13:37:17 +00:00
b204941865
qemuDomainDetachDeviceLive() is called from two places in qemu_driver.c, and qemuDomainUpdateDeviceList() is called from the end of qemuDomainDetachDeviceLive(), which is now in qemu_hotplug.c This patch replaces the single call to qemuDomainUpdateDeviceList() with two calls to it immediately after return from qemuDomainDetachDeviceLive(). This is only done if the return from that function is exactly 0, in order to exactly preserve previous behavior. Removing that one call from qemuDomainDetachDeviceList() will permit us to call it from the test driver hotplug test, replacing the separate calls to qemuDomainDetachDeviceDiskLive(), qemuDomainDetachChrDevice(), qemuDomainDetachShmemDevice() and qemuDomainDetachWatchdog(). We want to do this so that part of the common functionality of those three functions (and the rest of the device-specific Detach functions) can be pulled up into qemuDomainDetachDeviceLive() without breaking the test. (This is done in the next patch). NB: Almost certainly this is "not the best place" to call qemuDomainUpdateDeviceList() (actually, it is provably the *wrong* place), since it's purpose is to retrieve an "up to date" list of aliases for all devices from qemu, and if the guest OS hasn't yet processed the detach request, the now-being-removed device may still be on that list. It would arguably be better to instead call qemuDomainUpdateDevicesList() later during the response to the DEVICE_DELETED event for the device. But removing the call from the current point in the detach could have some unforeseen ill effect due to changed timing, so the change to move it into qemuDomainRemove*Device() will be done in a separate patch (in order to make it easily revertible in case it causes a regression). Signed-off-by: Laine Stump <laine@laine.org> ACKed-by: Peter Krempa <pkrempa@redhat.com> |
||
|---|---|---|
| .. | ||
| access | ||
| admin | ||
| bhyve | ||
| conf | ||
| cpu | ||
| cpu_map | ||
| esx | ||
| hyperv | ||
| interface | ||
| keycodemapdb@16e5b07876 | ||
| libxl | ||
| locking | ||
| logging | ||
| lxc | ||
| network | ||
| node_device | ||
| nwfilter | ||
| openvz | ||
| phyp | ||
| qemu | ||
| remote | ||
| rpc | ||
| secret | ||
| security | ||
| storage | ||
| test | ||
| util | ||
| vbox | ||
| vmware | ||
| vmx | ||
| vz | ||
| xenapi | ||
| xenconfig | ||
| admin_protocol-structs | ||
| check-aclperms.pl | ||
| check-aclrules.pl | ||
| check-driverimpls.pl | ||
| check-drivername.pl | ||
| check-symfile.pl | ||
| check-symsorting.pl | ||
| datatypes.c | ||
| datatypes.h | ||
| driver-hypervisor.h | ||
| driver-interface.h | ||
| driver-network.h | ||
| driver-nodedev.h | ||
| driver-nwfilter.h | ||
| driver-secret.h | ||
| driver-state.h | ||
| driver-storage.h | ||
| driver-stream.h | ||
| driver.c | ||
| driver.h | ||
| dtrace2systemtap.pl | ||
| internal.h | ||
| libvirt_admin_private.syms | ||
| libvirt_admin_public.syms | ||
| libvirt_atomic.syms | ||
| libvirt_driver_modules.syms | ||
| libvirt_esx.syms | ||
| libvirt_internal.h | ||
| libvirt_libssh2.syms | ||
| libvirt_libssh.syms | ||
| libvirt_linux.syms | ||
| libvirt_lxc.syms | ||
| libvirt_openvz.syms | ||
| libvirt_private.syms | ||
| libvirt_probes.d | ||
| libvirt_public.syms | ||
| libvirt_qemu_probes.d | ||
| libvirt_qemu.syms | ||
| libvirt_remote.syms | ||
| libvirt_sasl.syms | ||
| libvirt_vmware.syms | ||
| libvirt_vmx.syms | ||
| libvirt_xenconfig.syms | ||
| libvirt-admin.c | ||
| libvirt-admin.conf | ||
| libvirt-domain-snapshot.c | ||
| libvirt-domain.c | ||
| libvirt-host.c | ||
| libvirt-interface.c | ||
| libvirt-lxc.c | ||
| libvirt-lxc.pc.in | ||
| libvirt-network.c | ||
| libvirt-nodedev.c | ||
| libvirt-nwfilter.c | ||
| libvirt-qemu.c | ||
| libvirt-qemu.pc.in | ||
| libvirt-secret.c | ||
| libvirt-storage.c | ||
| libvirt-stream.c | ||
| libvirt.c | ||
| libvirt.conf | ||
| libvirt.pc.in | ||
| lock_protocol-structs | ||
| lxc_monitor_protocol-structs | ||
| lxc_protocol-structs | ||
| Makefile.am | ||
| qemu_protocol-structs | ||
| README | ||
| remote_protocol-structs | ||
| virkeepaliveprotocol-structs | ||
| virnetprotocol-structs | ||
libvirt library code README
===========================
The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.
The files directly in this directory are supporting the public API
entry points & data structures.
There are two core shared modules to be aware of:
* util/ - a collection of shared APIs that can be used by any
code. This directory is always in the include path
for all things built
* conf/ - APIs for parsing / manipulating all the official XML
files used by the public API. This directory is only
in the include path for driver implementation modules
* vmx/ - VMware VMX config handling (used by esx/ and vmware/)
Then there are the hypervisor implementations:
* bhyve - bhyve - The BSD Hypervisor
* esx/ - VMware ESX and GSX support using vSphere API over SOAP
* hyperv/ - Microsoft Hyper-V support using WinRM
* lxc/ - Linux Native Containers
* openvz/ - OpenVZ containers using cli tools
* phyp/ - IBM Power Hypervisor using CLI tools over SSH
* qemu/ - QEMU / KVM using qemu CLI/monitor
* remote/ - Generic libvirt native RPC client
* test/ - A "mock" driver for testing
* vbox/ - Virtual Box using native API
* vmware/ - VMware Workstation and Player using the vmrun tool
* xen/ - Xen using hypercalls, XenD SEXPR & XenStore
* xenapi/ - Xen using libxenserver
Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU and Xen drivers.
The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly
* cpu/ - CPU feature management
* interface/ - Host network interface management
* network/ - Virtual NAT networking
* nwfilter/ - Network traffic filtering rules
* node_device/ - Host device enumeration
* secret/ - Secret management
* security/ - Mandatory access control drivers
* storage/ - Storage management drivers
Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories