mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-06 22:35:46 +00:00
407a281a8e
This reverts commit e4b980c853.
When a binary links against a .a archive (as opposed to a shared library),
any symbols which are marked as 'weak' get silently dropped. As a result
when the binary later runs, those 'weak' functions have an address of
0x0 and thus crash when run.
This happened with virtlogd and virtlockd because they don't link to
libvirt.so, but instead just libvirt_util.a and libvirt_rpc.a. The
virRandomBits symbols was weak and so left out of the virtlogd &
virtlockd binaries, despite being required by virHashTable functions.
Various other binaries like libvirt_lxc, libvirt_iohelper, etc also
link directly to .a files instead of libvirt.so, so are potentially
at risk of dropping symbols leading to a later runtime crash.
This is normal linker behaviour because a weak symbol is not treated
as undefined, so nothing forces it to be pulled in from the .a You
have to force the linker to pull in weak symbols using -u$SYMNAME
which is not a practical approach.
This risk is silent bad linkage that affects runtime behaviour is
not acceptable for a fix that was merely trying to fix the test
suite. So stop using __weak__ again.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
62 lines
2.1 KiB
C
62 lines
2.1 KiB
C
/*
|
|
* viruuid.h: helper APIs for dealing with UUIDs
|
|
*
|
|
* Copyright (C) 2007, 2011-2014 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
* Authors:
|
|
* Mark McLoughlin <markmc@redhat.com>
|
|
*/
|
|
|
|
#ifndef __VIR_UUID_H__
|
|
# define __VIR_UUID_H__
|
|
|
|
# include "internal.h"
|
|
|
|
|
|
/**
|
|
* VIR_UUID_DEBUG:
|
|
* @conn: connection
|
|
* @uuid: possibly null UUID array
|
|
*/
|
|
# define VIR_UUID_DEBUG(conn, uuid) \
|
|
do { \
|
|
if (uuid) { \
|
|
char _uuidstr[VIR_UUID_STRING_BUFLEN]; \
|
|
virUUIDFormat(uuid, _uuidstr); \
|
|
VIR_DEBUG("conn=%p, uuid=%s", conn, _uuidstr); \
|
|
} else { \
|
|
VIR_DEBUG("conn=%p, uuid=(null)", conn); \
|
|
} \
|
|
} while (0)
|
|
|
|
|
|
int virSetHostUUIDStr(const char *host_uuid);
|
|
int virGetHostUUID(unsigned char *host_uuid) ATTRIBUTE_NONNULL(1);
|
|
|
|
int virUUIDIsValid(unsigned char *uuid);
|
|
|
|
int virUUIDGenerate(unsigned char *uuid) ATTRIBUTE_NOINLINE;
|
|
|
|
int virUUIDParse(const char *uuidstr,
|
|
unsigned char *uuid)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_RETURN_CHECK;
|
|
|
|
const char *virUUIDFormat(const unsigned char *uuid,
|
|
char *uuidstr) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
|
|
|
|
#endif /* __VIR_UUID_H__ */
|