External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-30 13:37:17 +00:00
Code Issues Packages Projects Releases Wiki Activity
d400b8fb18
libvirt/src
History
Eric Blake d400b8fb18 conf: allow fuzz in XML with cur balloon > max 
Commit 1b1402b introduced a regression.  Since older libvirt versions
would silently round memory up (until the previous patch), but populated
current memory based on querying the guest, it was possible to have
dumpxml show cur > max by the amount of the rounding.  For example, if
a user requested 1048570 KiB memory (just shy of 1GiB), the qemu
driver would actually run with 1048576 KiB, and libvirt 0.9.10 would
output a current that was 6KiB larger than the maximum.  Situations
where this could have an impact include, but are not limited to,
migration from old to new libvirt, managedsave in old libvirt and
start in new libvirt, snapshot creation in old libvirt and revert in
new libvirt - without this patch, the new libvirt would reject the
VM because of the rounding discrepancy.

Fix things by adding a fuzz factor, and silently clamp current down to
maximum in that case, rather than failing to reparse XML for an existing
VM.  From a practical standpoint, this has no user impact: 'virsh
dumpxml' will continue to query the running guest rather than rely on
the incoming xml, which will see the currect current value, and even if
clamping down occurs during parsing, it will be by at most the fuzz
factor of a megabyte alignment, and rounded back up when passed back to
the hypervisor.

Meanwhile, we continue to reject cur > max if the difference is beyond
the fuzz factor of nearest megabyte.  But this is not a real change in
behavior, since with 0.9.10, even though the parser allowed it, later
in the processing stream we would reject it at the qemu layer; so
rejecting it in the parser just moves error detection to a nicer place.

* src/conf/domain_conf.c (virDomainDefParseXML): Don't reject
existing XML.
Based on a report by Zhou Peng.
2012-03-31 09:33:46 -06:00
..
conf conf: allow fuzz in XML with cur balloon > max 2012-03-31 09:33:46 -06:00
cpu Cleanup for a return statement in source files 2012-03-26 14:45:22 -06:00
esx Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
hyperv Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
interface Cleanup for a return statement in source files 2012-03-26 14:45:22 -06:00
libxl Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
locking sanlock: Use STREQ_NULLABLE instead of STREQ on strings that may be null 2012-03-08 11:49:32 +01:00
lxc Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
network Attach vm-id to Open vSwitch interfaces. 2012-03-08 14:44:15 -05:00
node_device Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
nwfilter Cleanup for a return statement in source files 2012-03-26 14:45:22 -06:00
openvz Centralize error reporting for URI parsing/formatting problems 2012-03-23 12:59:21 +00:00
phyp Lookup auth credentials in config file before prompting 2012-03-23 13:24:07 +00:00
qemu qemu: reflect any memory rounding back to xml 2012-03-31 09:17:35 -06:00
remote Fix typo in previous patch 2012-03-30 12:44:28 +01:00
rpc Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
secret secret: add Ceph secret type 2011-10-28 11:34:17 -06:00
security Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
storage Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
test Cleanup for a return statement in source files 2012-03-26 14:45:22 -06:00
uml Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
util virnetdevtap: Don't check for flags in virNetDevTapCreateFlags 2012-03-30 15:28:59 +02:00
vbox Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
vmware build: use correct type for pid and similar types 2012-03-02 06:57:43 -07:00
vmx Centralize error reporting for URI parsing/formatting problems 2012-03-23 12:59:21 +00:00
xen Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
xenapi Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
xenxs Cleanup for a return statement in source files 2012-03-26 14:45:22 -06:00
datatypes.c Cleanup for a return statement in source files 2012-03-26 14:45:22 -06:00
datatypes.h Fixed URI parsing 2012-02-24 16:49:21 -07:00
driver.c libvirt: do not mix internal flags into public API 2011-07-18 13:50:51 -06:00
driver.h xml: use long long internally, to centralize overflow checks 2012-03-07 18:24:43 -07:00
dtrace2systemtap.pl Add a systemtap script for watching QEMU monitor interactions 2011-10-27 10:42:14 +01:00
fdstream.c fdstream: Add internal callback on stream close 2012-02-27 15:05:17 +01:00
fdstream.h fdstream: Add internal callback on stream close 2012-02-27 15:05:17 +01:00
gnutls_1_0_compat.h Fix detection of GnuTLS 1.x.y 2011-08-03 19:22:29 +02:00
internal.h Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
libvirt_daemon.syms Export conditional state driver symbols only when they are defined 2010-03-23 02:05:18 +01:00
libvirt_dbus.syms Fix build on Mingw32 wrt export of virNetServerGetDBusConn 2011-11-21 11:46:52 +00:00
libvirt_driver_modules.syms Move --with-driver-modules symbols into a separate sym file 2009-01-05 14:06:41 +00:00
libvirt_internal.h Introduce virConnectSetKeepAlive 2011-11-24 11:44:08 +01:00
libvirt_linux.syms migrate linux-specific symbol names into their own sym file 2009-01-05 14:08:26 +00:00
libvirt_network.syms network: provide internal API to return IP of a network 2011-07-25 13:48:55 +08:00
libvirt_nwfilter.syms Some NWFilter symbols are conditional and have to be exported conditional 2010-04-23 19:51:00 +02:00
libvirt_private.syms private.syms: Add virNetDevMacVLanRestartWithVPortProfile 2012-03-29 17:03:37 +02:00
libvirt_public.syms Introduce virDomainPMWakeup API 2012-02-27 11:43:59 +01:00
libvirt_qemu.syms Define a QEMU specific API to attach to a running QEMU process 2011-07-12 15:39:03 +01:00
libvirt_sasl.syms build: fix mingw build without sasl 2011-10-11 16:30:25 -06:00
libvirt_vmx.syms esx: Move VMX handling code out of the driver directory 2010-12-21 22:40:17 +01:00
libvirt_xenxs.syms Fix build with --with-driver-modules enabled 2011-05-27 09:51:28 +02:00
libvirt-qemu.c build: use correct type for pid and similar types 2012-03-02 06:57:43 -07:00
libvirt.c build: fix mingw ssize_t, syntax check 2012-03-30 11:10:54 -06:00
libvirt.conf Allow overriding default URI in config file 2012-03-15 11:20:17 +00:00
Makefile.am Add helper API for finding auth file path 2012-03-23 13:24:07 +00:00
nodeinfo.c Consistent style for usage of sizeof operator 2012-03-30 11:47:24 +01:00
nodeinfo.h add nodeGetCPUmap() for getting available CPU IDs in a cpumap. 2012-03-06 21:54:48 -07:00
probes.d build: use correct type for pid and similar types 2012-03-02 06:57:43 -07:00
qemu_protocol-structs build: use correct type for pid and similar types 2012-03-02 06:57:43 -07:00
README hyperv: Add basic documentation 2011-08-26 17:52:55 +02:00
remote_protocol-structs build: fix incorrect enum declaration 2012-03-23 14:29:00 -06:00
virkeepaliveprotocol-structs build: Properly generate and check virkeepaliveprotocol-structs 2011-11-24 14:44:04 +01:00
virnetprotocol-structs Extend RPC protocol to allow FD passing 2011-10-28 10:27:15 +01:00

README 

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * phyp/         - IBM Power Hypervisor using CLI tools over SSH
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * uml/          - User Mode Linux
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore
 * xenapi/       - Xen using libxenserver


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers.
The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories