External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-31 08:55:22 +00:00
Code Issues Packages Projects Releases Wiki Activity
libvirt/src/util
History
Michal Privoznik d53ab9f54e virDevMapperGetTargetsImpl: Check for dm major properly 
In v6.4.0-rc1~143 I've introduced a check that is supposed to
return from the function early, if given path is not a dm target.
While the idea is still valid, the implementation had a flaw.
It calls stat() over given path and the uses major(sb.st_dev) to
learn the major of the device. This is then passed to
dm_is_dm_major() which returns true or false depending whether
the device is under devmapper's control or not.

The problem with this approach is in how the major of the device
is obtained - paths managed by devmapper are special files and
thus we want to be using st_rdev instead of st_dev to obtain the
major number. Well, that's what virIsDevMapperDevice() does
already so might as well us that.

Fixes: 01626c668ecfbe465d18799ac4628e6127ea1d47
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1839992

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
2020-06-15 14:50:46 +02:00
..
glibcompat.c
util: introduce compile time API version checking
2020-01-07 14:42:26 +00:00
glibcompat.h
util: add compat impl of g_canonicalize_filename
2020-01-07 14:42:26 +00:00
iohelper.c
Remove virutil.h where possible
2020-02-24 23:15:49 +01:00
Makefile.inc.am
util: introduce shared daemon startup code
2020-03-27 16:22:49 +01:00
viralloc.c
VIR_FREE: Replace internals by g_clear_pointer
2020-03-05 16:22:27 +01:00
viralloc.h
VIR_FREE: Replace internals by g_clear_pointer
2020-03-05 16:22:27 +01:00
virarch.c
util: add a virArchFromHost() impl for Windows
2020-01-29 14:51:39 +00:00
virarch.h
Add a space before ending a comment
2020-01-30 12:32:03 +01:00
virarptable.c
src: convert all code to use virsocket.h
2020-01-29 14:51:40 +00:00
virarptable.h
…
viraudit.c
Use g_strerror instead of virStrerror
2020-03-13 17:26:55 +01:00
viraudit.h
Use G_GNUC_PRINTF instead of ATTRIBUTE_FMT_PRINTF
2019-10-15 16:14:18 +02:00
virauth.c
util: Don't check the output of virGetUserConfigDirectory()
2019-12-20 09:38:43 +01:00
virauth.h
…
virauthconfig.c
util: authconfig: use g_key_file_*
2020-03-23 15:34:28 +01:00
virauthconfig.h
Remove virautoclean.h
2019-10-16 12:06:44 +02:00
virbitmap.c
virBitmapNewEmpty: Use g_new0 to allocate and remove error checking
2020-03-20 09:47:16 +01:00
virbitmap.h
Remove virautoclean.h
2019-10-16 12:06:44 +02:00
virbpf.c
virbpf: Set errno instead of reporting errors
2020-03-10 17:10:57 +01:00
virbpf.h
util: introduce virbpf helpers
2019-11-15 12:58:00 +01:00
virbuffer.c
virBufferTrim: do not accept len
2020-02-03 19:44:38 +01:00
virbuffer.h
virBufferTrim: do not accept len
2020-02-03 19:44:38 +01:00
vircgroup.c
Drop needless variable
2020-05-05 11:19:34 +02:00
vircgroup.h
util: vircgroup: include unistd.h rather than virutil.h
2020-02-24 23:15:49 +01:00
vircgroupbackend.c
…
vircgroupbackend.h
vircgroup: workaround devices in hybrid mode
2019-11-15 12:58:43 +01:00
vircgrouppriv.h
vircgroup: introduce virCgroupV2DevicesAttachProg
2019-11-15 12:58:05 +01:00
vircgroupv1.c
util: vircgroup: include unistd.h rather than virutil.h
2020-02-24 23:15:49 +01:00
vircgroupv1.h
…
vircgroupv2.c
util: vircgroup: include unistd.h rather than virutil.h
2020-02-24 23:15:49 +01:00
vircgroupv2.h
…
vircgroupv2devices.c
virCgroupV2DevicesAvailable: Print stringified errno in the debug log
2020-03-10 17:10:21 +01:00
vircgroupv2devices.h
vircgroupv2devices: Unexport virCgroupV2DevicesAttachProg()
2020-01-06 17:30:17 +01:00
vircommand.c
virCommand: Introduce virCommandGetArgList
2020-05-20 09:41:57 +02:00
vircommand.h
Fix some wrong usage of ATTRIBUTE_NONNULL()
2020-06-09 11:39:07 +02:00
vircommandpriv.h
…
virconf.c
util: Don't check the output of virGetUserConfigDirectory()
2019-12-20 09:38:43 +01:00
virconf.h
Remove virutil.h from all header files
2020-02-24 23:15:50 +01:00
vircrypto.c
src: replace verify(expr) with G_STATIC_ASSERT(expr)
2020-01-17 10:02:01 +00:00
vircrypto.h
Use G_GNUC_WARN_UNUSED_RESULT instead of ATTRIBUTE_RETURN_CHECK
2019-10-15 11:25:22 +02:00
virdaemon.c
util: Do not include sys/wait.h on Win32
2020-04-17 21:30:10 +02:00
virdaemon.h
util: introduce shared daemon startup code
2020-03-27 16:22:49 +01:00
virdbus.c
util: remove unneeded cleanup labels
2019-11-12 17:54:01 +01:00
virdbus.h
Revert "dbus: correctly build reply message"
2019-09-10 09:47:13 +02:00
virdbuspriv.h
…
virdevmapper.c
virDevMapperGetTargetsImpl: Check for dm major properly
2020-06-15 14:50:46 +02:00
virdevmapper.h
util: Move virIsDevMapperDevice() to virdevmapper.c
2020-06-15 14:50:46 +02:00
virdnsmasq.c
conf: Add <lease/> option for <dhcp/> settings
2020-04-23 10:59:23 +02:00
virdnsmasq.h
conf: Add <lease/> option for <dhcp/> settings
2020-04-23 10:59:23 +02:00
virebtables.c
util: Use g_strdup_printf() instead of virAsprintf()
2019-11-12 16:15:58 +01:00
virebtables.h
…
virendian.h
…
virenum.c
…
virenum.h
src: replace verify(expr) with G_STATIC_ASSERT(expr)
2020-01-17 10:02:01 +00:00
virerror.c
util: remove virStrerror
2020-03-13 17:26:55 +01:00
virerror.h
util: remove virStrerror
2020-03-13 17:26:55 +01:00
virerrorpriv.h
…
virevent.c
util: switch to use the GLib event loop impl
2020-02-07 15:03:53 +00:00
virevent.h
event: add API for requiring an event loop impl to be registered
2019-12-18 14:04:59 +00:00
vireventglib.c
util: import an event loop impl based on GMainContext
2020-02-07 15:03:53 +00:00
vireventglib.h
util: import an event loop impl based on GMainContext
2020-02-07 15:03:53 +00:00
vireventglibwatch.c
util: vireventglibwatch: watch for G_IO_HUP and G_IO_ERR
2020-02-24 03:19:25 +01:00
vireventglibwatch.h
src: introduce helper API for creating GSource for socket
2020-02-07 15:03:53 +00:00
vireventthread.c
src: introduce an abstraction for running event loops
2020-03-11 14:44:04 +00:00
vireventthread.h
src: introduce an abstraction for running event loops
2020-03-11 14:44:04 +00:00
virfcp.c
util: use g_strdup instead of VIR_STRDUP
2019-10-21 12:51:59 +02:00
virfcp.h
…
virfdstream.c
src: make virObjectUnref return void
2020-06-03 10:20:17 +01:00
virfdstream.h
…
virfile.c
virfile: Handle directories in virFileBindMountDevice()
2020-03-20 14:34:32 +01:00
virfile.h
util: Define g_autoptr callback for FILE
2020-05-25 16:09:41 +02:00
virfilecache.c
util: buffer: Remove virBufferCheckError
2019-10-24 19:35:34 +02:00
virfilecache.h
…
virfirewall.c
Remove virutil.h where possible
2020-02-24 23:15:49 +01:00
virfirewall.h
Remove virautoclean.h
2019-10-16 12:06:44 +02:00
virfirewalld.c
Use g_autofree instead of VIR_AUTOFREE
2019-10-16 12:06:43 +02:00
virfirewalld.h
…
virfirewalldpriv.h
…
virfirewallpriv.h
…
virfirmware.c
util: use g_strdup instead of VIR_STRDUP
2019-10-21 12:51:59 +02:00
virfirmware.h
Use G_DEFINE_AUTOPTR_CLEANUP_FUNC instead of VIR_DEFINE_AUTOPTR_FUNC
2019-10-16 12:06:43 +02:00
virgettext.c
src: optionally include xlocale.h header
2020-02-04 14:00:45 +00:00
virgettext.h
…
virgic.c
Remove virutil.h where possible
2020-02-24 23:15:49 +01:00
virgic.h
Remove virutil.h from all header files
2020-02-24 23:15:50 +01:00
virhash.c
virHashAddOrUpdateEntry: Simplify allocation of new entry
2020-02-04 13:45:33 +01:00
virhash.h
virhash: Fix the expectations of virHashKeyEqual implementations
2020-02-04 13:45:33 +01:00
virhashcode.c
Use G_GNUC_FALLTHROUGH instead of ATTRIBUTE_FALLTHROUGH
2019-10-15 16:14:19 +02:00
virhashcode.h
Use G_GNUC_NO_INLINE instead of ATTRIBUTE_NOINLINE
2019-10-15 16:14:18 +02:00
virhook.c
bhyve: add hooks
2020-02-24 17:25:07 +00:00
virhook.h
bhyve: add hooks
2020-02-24 17:25:07 +00:00
virhostcpu.c
hostcpu: Implement virHostCPUGetSignature for s390
2020-05-25 16:09:58 +02:00
virhostcpu.h
hostcpu: Introduce virHostCPUGetSignature
2020-05-25 16:09:41 +02:00
virhostcpupriv.h
hostcpu: Introduce virHostCPUGetSignature
2020-05-25 16:09:41 +02:00
virhostmem.c
src: remove unused sys/utsname.h includes
2020-01-29 14:51:39 +00:00
virhostmem.h
…
virhostuptime.c
virhostuptime: Introduce virHostBootTimeInit()
2020-01-07 17:00:10 +01:00
virhostuptime.h
virhostuptime: Introduce virHostBootTimeInit()
2020-01-07 17:00:10 +01:00
viridentity.c
util: convert virIdentity class to use GObject
2019-10-14 10:54:42 +01:00
viridentity.h
util: convert virIdentity class to use GObject
2019-10-14 10:54:42 +01:00
virinitctl.c
src: replace verify(expr) with G_STATIC_ASSERT(expr)
2020-01-17 10:02:01 +00:00
virinitctl.h
…
viriptables.c
src: remove sys/wait.h from many files
2020-02-04 14:00:44 +00:00
viriptables.h
network: allow DHCP/DNS/TFTP explicitly in OUTPUT rules
2019-10-18 18:49:54 +01:00
viriscsi.c
Remove all the uses that use subtraction in their length argument
2019-12-12 14:24:35 +01:00
viriscsi.h
Use G_GNUC_WARN_UNUSED_RESULT instead of ATTRIBUTE_RETURN_CHECK
2019-10-15 11:25:22 +02:00
virjson.c
util: json: Introduce virJSONValueObjectAppendStringPrintf
2020-05-20 09:41:57 +02:00
virjson.h
util: json: Introduce virJSONValueObjectAppendStringPrintf
2020-05-20 09:41:57 +02:00
virkeycode.c
src: replace verify(expr) with G_STATIC_ASSERT(expr)
2020-01-17 10:02:01 +00:00
virkeycode.h
Remove virutil.h from all header files
2020-02-24 23:15:50 +01:00
virkmod.c
util: Use g_strdup_printf() instead of virAsprintf()
2019-11-12 16:15:58 +01:00
virkmod.h
…
virlease.c
util: json: Convert virJSONValueNewObject() to g_new0
2020-03-05 11:31:38 +01:00
virlease.h
…
virlockspace.c
Use g_strerror instead of virStrerror
2020-03-13 17:26:55 +01:00
virlockspace.h
…
virlog.c
src: convert all code to use virsocket.h
2020-01-29 14:51:40 +00:00
virlog.h
util: Use g_strdup_printf() instead of virAsprintf()
2019-11-12 16:15:58 +01:00
virmacaddr.c
Remove all use of virHexToBin
2020-02-24 20:25:48 +01:00
virmacaddr.h
src: replace verify(expr) with G_STATIC_ASSERT(expr)
2020-01-17 10:02:01 +00:00
virmacmap.c
virmacmap: Use g_autofree in virMacMapWriteFileLocked
2020-03-05 18:06:21 +01:00
virmacmap.h
…
virmdev.c
Drop needless variable
2020-05-05 11:19:34 +02:00
virmdev.h
Remove virutil.h from all header files
2020-02-24 23:15:50 +01:00
virmodule.c
virsh: include virutil.h where used
2020-02-24 23:15:50 +01:00
virmodule.h
…
virnetdev.c
Remove all usage of virRun
2020-04-23 12:49:30 +02:00
virnetdev.h
src: conditionalize use of net/if.h
2020-01-29 14:51:40 +00:00
virnetdevbandwidth.c
src: add virutil.h to more source files for geteuid() compat
2020-02-25 10:02:15 +00:00
virnetdevbandwidth.h
conf: make virDomainNetGetActualBandwidth arg/return value const
2019-11-25 15:29:51 -05:00
virnetdevbridge.c
Remove virutil.h where possible
2020-02-24 23:15:49 +01:00
virnetdevbridge.h
util: query/set BR_ISOLATED flag on netdevs attached to bridge
2020-02-20 23:07:53 -05:00
virnetdevip.c
Remove virutil.h where possible
2020-02-24 23:15:49 +01:00
virnetdevip.h
Remove virautoclean.h
2019-10-16 12:06:44 +02:00
virnetdevmacvlan.c
src: convert all code to use virsocket.h
2020-01-29 14:51:40 +00:00
virnetdevmacvlan.h
conf: return a const from virDomainNetGetActualVirtPortProfile
2019-11-25 15:29:56 -05:00
virnetdevmidonet.c
conf: return a const from virDomainNetGetActualVirtPortProfile
2019-11-25 15:29:56 -05:00
virnetdevmidonet.h
conf: return a const from virDomainNetGetActualVirtPortProfile
2019-11-25 15:29:56 -05:00
virnetdevopenvswitch.c
virNetDevOpenvswitchGetVhostuserIfname: Drop cleanup label
2020-05-13 13:14:29 +02:00
virnetdevopenvswitch.h
conf: return a const from virDomainNetGetActualVirtPortProfile
2019-11-25 15:29:56 -05:00
virnetdevtap.c
qemu/lxc: plumb isolatedPort from config down through bridge attachment
2020-02-20 23:13:15 -05:00
virnetdevtap.h
qemu/lxc: plumb isolatedPort from config down through bridge attachment
2020-02-20 23:13:15 -05:00
virnetdevveth.c
Remove virutil.h where possible
2020-02-24 23:15:49 +01:00
virnetdevveth.h
Use G_GNUC_WARN_UNUSED_RESULT instead of ATTRIBUTE_RETURN_CHECK
2019-10-15 11:25:22 +02:00
virnetdevvlan.c
…
virnetdevvlan.h
Remove virutil.h from all header files
2020-02-24 23:15:50 +01:00
virnetdevvportprofile.c
Add a space before ending a comment
2020-01-30 12:32:03 +01:00
virnetdevvportprofile.h
Remove virutil.h from all header files
2020-02-24 23:15:50 +01:00
virnetlink.c
src: Fix boolean assignment
2020-05-05 13:08:57 +02:00
virnetlink.h
m4: virt-libnl: drop libnl-1.0 support
2019-10-23 14:30:47 +02:00
virnodesuspend.c
src: improve thread naming with human targetted names
2020-03-05 12:23:04 +00:00
virnodesuspend.h
…
virnuma.c
virsh: include virutil.h where used
2020-02-24 23:15:50 +01:00
virnuma.h
Remove virutil.h from all header files
2020-02-24 23:15:50 +01:00
virnvme.c
util: Introduce virNVMeDevice module
2019-12-17 10:04:43 +01:00
virnvme.h
virhostdev: Include virNVMeDevice module
2019-12-17 10:04:43 +01:00
virobject.c
src: make virObject inherit from GObject
2020-06-03 10:20:17 +01:00
virobject.h
src: make virObject inherit from GObject
2020-06-03 10:20:17 +01:00
virpci.c
Use g_strerror instead of virStrerror
2020-03-13 17:26:55 +01:00
virpci.h
Remove virutil.h from all header files
2020-02-24 23:15:50 +01:00
virperf.c
Include unistd.h where used
2020-02-24 23:15:50 +01:00
virperf.h
Remove virutil.h from all header files
2020-02-24 23:15:50 +01:00
virpidfile.c
Use g_strerror instead of virStrerror
2020-03-13 17:26:55 +01:00
virpidfile.h
Use G_GNUC_WARN_UNUSED_RESULT instead of ATTRIBUTE_RETURN_CHECK
2019-10-15 11:25:22 +02:00
virpolkit.c
virsh: include virutil.h where used
2020-02-24 23:15:50 +01:00
virpolkit.h
…
virportallocator.c
util: virportallocator: add includes
2020-02-24 23:15:49 +01:00
virportallocator.h
…
virprobe.h
…
virprocess.c
util: remove references to virRun/virExec
2020-04-23 12:49:30 +02:00
virprocess.h
Remove virutil.h from all header files
2020-02-24 23:15:50 +01:00
virqemu.c
qemu: Prepare for testing of 'netdev_add' props via qemuxml2argvtest
2020-05-20 09:41:58 +02:00
virqemu.h
qemu: Prepare for testing of 'netdev_add' props via qemuxml2argvtest
2020-05-20 09:41:58 +02:00
virrandom.c
Remove virutil.h where possible
2020-02-24 23:15:49 +01:00
virrandom.h
Use G_GNUC_NO_INLINE instead of ATTRIBUTE_NOINLINE
2019-10-15 16:14:18 +02:00
virresctrl.c
Drop needless variable
2020-05-05 11:19:34 +02:00
virresctrl.h
Remove virutil.h from all header files
2020-02-24 23:15:50 +01:00
virresctrlpriv.h
…
virrotatingfile.c
util: Use g_strdup_printf() instead of virAsprintf()
2019-11-12 16:15:58 +01:00
virrotatingfile.h
…
virscsi.c
Remove virutil.h where possible
2020-02-24 23:15:49 +01:00
virscsi.h
Remove virautoclean.h
2019-10-16 12:06:44 +02:00
virscsihost.c
util: Use g_strdup_printf() instead of virAsprintf()
2019-11-12 16:15:58 +01:00
virscsihost.h
…
virscsivhost.c
util: Use g_strdup_printf() instead of virAsprintf()
2019-11-12 16:15:58 +01:00
virscsivhost.h
Remove virutil.h from all header files
2020-02-24 23:15:50 +01:00
virseclabel.c
virSecurityDeviceLabelDefNew: Avoid NULL dereference
2020-03-30 16:14:23 +02:00
virseclabel.h
…
virsecret.c
virSecretLookupDefCopy: Remove return value
2020-03-20 09:47:16 +01:00
virsecret.h
virSecretLookupDefCopy: Remove return value
2020-03-20 09:47:16 +01:00
virsocket.c
src: implement APIs for passing FDs over UNIX sockets
2020-01-29 14:51:39 +00:00
virsocket.h
gnulib: delete all gnulib integration
2020-02-07 15:03:54 +00:00
virsocketaddr.c
Drop needless variable
2020-05-05 11:19:34 +02:00
virsocketaddr.h
src: convert all code to use virsocket.h
2020-01-29 14:51:40 +00:00
virstorageencryption.c
Remove use of variables passed only to 'VIR_FREE'
2020-06-15 10:27:37 +02:00
virstorageencryption.h
Remove virutil.h from all header files
2020-02-24 23:15:50 +01:00
virstoragefile.c
Use more of VIR_XPATH_NODE_AUTORESTORE
2020-06-03 21:06:02 +02:00
virstoragefile.h
conf: Sanitize handling of <auth> and <encryption> placement for disks
2020-05-12 06:55:00 +02:00
virstoragefilebackend.c
…
virstoragefilebackend.h
…
virstring.c
src: optionally include xlocale.h header
2020-02-04 14:00:45 +00:00
virstring.h
src: replace use of INT_BUFSIZE_BOUND macros
2020-01-17 09:58:43 +00:00
virsysinfo.c
Remove use of variables passed only to 'VIR_FREE'
2020-06-15 10:27:37 +02:00
virsysinfo.h
conf: Add firmware blob configuration
2020-06-10 14:00:38 +02:00
virsysinfopriv.h
virsysinfo: Drop global @sysinfoDmidecode
2020-06-10 14:00:38 +02:00
virsystemd.c
Drop virAtomic module
2020-02-02 16:36:58 +01:00
virsystemd.h
Remove virautoclean.h
2019-10-16 12:06:44 +02:00
virsystemdpriv.h
…
virthread.c
virthread: Free thread name only after worker has finished
2020-03-06 16:47:20 +01:00
virthread.h
src: set the OS level thread name
2020-03-05 12:23:02 +00:00
virthreadjob.c
…
virthreadjob.h
…
virthreadpool.c
src: improve thread naming with human targetted names
2020-03-05 12:23:04 +00:00
virthreadpool.h
src: improve thread naming with human targetted names
2020-03-05 12:23:04 +00:00
virtime.c
src: Fix boolean assignment
2020-05-05 13:08:57 +02:00
virtime.h
Use G_GNUC_WARN_UNUSED_RESULT instead of ATTRIBUTE_RETURN_CHECK
2019-10-15 11:25:22 +02:00
virtpm.c
virTPMEmulatorInit: Don't use temporary variable to free path
2020-06-15 10:27:37 +02:00
virtpm.h
Use G_GNUC_NO_INLINE instead of ATTRIBUTE_NOINLINE
2019-10-15 16:14:18 +02:00
virtypedparam-public.c
util: use g_strdup instead of VIR_STRDUP
2019-10-21 12:51:59 +02:00
virtypedparam.c
Remove virutil.h where possible
2020-02-24 23:15:49 +01:00
virtypedparam.h
Remove virutil.h from all header files
2020-02-24 23:15:50 +01:00
viruri.c
src: Fix boolean assignment
2020-05-05 13:08:57 +02:00
viruri.h
util: add helper API for getting URI parameters
2020-01-27 11:02:03 +00:00
virusb.c
Remove virutil.h where possible
2020-02-24 23:15:49 +01:00
virusb.h
Remove virautoclean.h
2019-10-16 12:06:44 +02:00
virutil.c
util: Move virIsDevMapperDevice() to virdevmapper.c
2020-06-15 14:50:46 +02:00
virutil.h
util: Move virIsDevMapperDevice() to virdevmapper.c
2020-06-15 14:50:46 +02:00
viruuid.c
util: uuid: remove use of virHexToBin
2020-02-24 20:25:48 +01:00
viruuid.h
Use G_GNUC_NO_INLINE instead of ATTRIBUTE_NOINLINE
2019-10-15 16:14:18 +02:00
virvhba.c
util: Use g_strdup_printf() instead of virAsprintf()
2019-11-12 16:15:58 +01:00
virvhba.h
…
virvsock.c
src: conditionalize / remove use of sys/ioctl.h
2020-01-17 13:16:58 +00:00
virvsock.h
…
virxdrdefs.h
src: remove all traces of Cygwin support
2020-01-29 14:51:40 +00:00
virxml.c
virxml: Don't overwrite ctxt->node
2020-06-03 21:06:02 +02:00
virxml.h
util: xml: Make virXMLFormatElement void
2019-10-24 19:35:34 +02:00