mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-28 08:35:22 +00:00
07497fc6da
When running on systemd host the cgroup itself is removed by machined
so when we reach this code the directory no longer exist. If libvirtd
was running the whole time between starting and destroying VM the
detection is skipped because we still have both FD in memory. But if
libvirtd was restarted and no operation requiring cgroup devices
executed the FDs would be 0 and libvirt would try to detect them using
the cgroup directory. This results in reporting following errors:
libvirtd[955]: unable to open '/sys/fs/cgroup/machine.slice/machine-qemu\x2d1\x2dguest.scope/': No such file or directory
libvirtd[955]: Failed to remove cgroup for guest
When running on non-systemd host where we handle cgroups manually this
would not happen.
When destroying VM it is not necessary to detect the BPF prog and map
because the following code only closes the FDs without doing anything
else. We could run code that would try to detach the BPF prog from the
cgroup but that is not necessary as well. If the cgroup is removed and
there is no other FD open to the prog kernel will cleanup the prog and
map eventually.
Reported-by: Eric Farman <farman@linux.ibm.com>
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Tested-by: Eric Farman <farman@linux.ibm.com>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
50 lines
1.3 KiB
C
50 lines
1.3 KiB
C
/*
|
|
* vircgroupv2devices.h: methods for cgroups v2 BPF devices
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <sys/types.h>
|
|
|
|
#include "internal.h"
|
|
|
|
#include "vircgroup.h"
|
|
|
|
bool
|
|
virCgroupV2DevicesAvailable(virCgroup *group)
|
|
G_GNUC_NO_INLINE;
|
|
|
|
int
|
|
virCgroupV2DevicesDetectProg(virCgroup *group);
|
|
|
|
int
|
|
virCgroupV2DevicesCreateProg(virCgroup *group);
|
|
|
|
int
|
|
virCgroupV2DevicesPrepareProg(virCgroup *group);
|
|
|
|
int
|
|
virCgroupV2DevicesCloseProg(virCgroup *group);
|
|
|
|
uint32_t
|
|
virCgroupV2DevicesGetPerms(int perms,
|
|
char type);
|
|
|
|
uint64_t
|
|
virCgroupV2DevicesGetKey(int major,
|
|
int minor);
|