mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-11-02 11:21:12 +00:00
e95de74d4c
The virNetlinkCommand() method takes an 'unsigned char **'
parameter to be filled with the received netlink message.
The callers then immediately cast this to 'struct nlmsghdr',
triggering (bogus) warnings about increasing alignment
requirements
util/virnetdev.c: In function 'virNetDevLinkDump':
util/virnetdev.c:1300:12: warning: cast increases required alignment of target type [-Wcast-align]
resp = (struct nlmsghdr *)*recvbuf;
^
util/virnetdev.c: In function 'virNetDevSetVfConfig':
util/virnetdev.c:1429:12: warning: cast increases required alignment of target type [-Wcast-align]
resp = (struct nlmsghdr *)recvbuf;
Since all callers cast to 'struct nlmsghdr' we can avoid
the warning problem entirely by simply changing the
signature of virNetlinkCommand to return a 'struct nlmsghdr **'
instead of 'unsigned char **'. The way we do the cast inside
virNetlinkCommand does not have any alignment issues.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
104 lines
3.3 KiB
C
104 lines
3.3 KiB
C
/*
|
|
* Copyright (C) 2010-2012 Red Hat, Inc.
|
|
* Copyright (C) 2010-2012 IBM Corporation
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef __VIR_NETLINK_H__
|
|
# define __VIR_NETLINK_H__
|
|
|
|
# include "config.h"
|
|
# include "internal.h"
|
|
# include "virmacaddr.h"
|
|
|
|
# if defined(__linux__) && defined(HAVE_LIBNL)
|
|
|
|
/* Work around a bug where older libnl-1 headers expected older gcc
|
|
* semantics of 'extern inline' that conflict with C99 semantics. */
|
|
# ifdef HAVE_LIBNL1
|
|
# define inline
|
|
# endif
|
|
# include <netlink/msg.h>
|
|
# ifdef HAVE_LIBNL1
|
|
# undef inline
|
|
# endif
|
|
|
|
# else
|
|
|
|
struct nl_msg;
|
|
struct sockaddr_nl;
|
|
struct nlattr;
|
|
struct nlmsghdr;
|
|
|
|
# endif /* __linux__ */
|
|
|
|
int virNetlinkStartup(void);
|
|
void virNetlinkShutdown(void);
|
|
|
|
int virNetlinkCommand(struct nl_msg *nl_msg,
|
|
struct nlmsghdr **resp, unsigned int *respbuflen,
|
|
uint32_t src_pid, uint32_t dst_pid,
|
|
unsigned int protocol, unsigned int groups);
|
|
|
|
typedef void (*virNetlinkEventHandleCallback)(struct nlmsghdr *,
|
|
unsigned int length,
|
|
struct sockaddr_nl *peer,
|
|
bool *handled,
|
|
void *opaque);
|
|
|
|
typedef void (*virNetlinkEventRemoveCallback)(int watch, const virMacAddrPtr macaddr, void *opaque);
|
|
|
|
/**
|
|
* stopNetlinkEventServer: stop the monitor to receive netlink messages for libvirtd
|
|
*/
|
|
int virNetlinkEventServiceStop(unsigned int protocol);
|
|
|
|
/**
|
|
* stopNetlinkEventServerAll: stop all the monitors to receive netlink messages for libvirtd
|
|
*/
|
|
int virNetlinkEventServiceStopAll(void);
|
|
|
|
/**
|
|
* startNetlinkEventServer: start a monitor to receive netlink messages for libvirtd
|
|
*/
|
|
int virNetlinkEventServiceStart(unsigned int protocol, unsigned int groups);
|
|
|
|
/**
|
|
* virNetlinkEventServiceIsRunning: returns if the netlink event service is running.
|
|
*/
|
|
bool virNetlinkEventServiceIsRunning(unsigned int protocol);
|
|
|
|
/**
|
|
* virNetlinkEventServiceLocalPid: returns nl_pid used to bind() netlink socket
|
|
*/
|
|
int virNetlinkEventServiceLocalPid(unsigned int protocol);
|
|
|
|
/**
|
|
* virNetlinkEventAddClient: register a callback for handling of netlink messages
|
|
*/
|
|
int virNetlinkEventAddClient(virNetlinkEventHandleCallback handleCB,
|
|
virNetlinkEventRemoveCallback removeCB,
|
|
void *opaque, const virMacAddrPtr macaddr,
|
|
unsigned int protocol);
|
|
|
|
/**
|
|
* virNetlinkEventRemoveClient: unregister a callback from a netlink monitor
|
|
*/
|
|
int virNetlinkEventRemoveClient(int watch, const virMacAddrPtr macaddr,
|
|
unsigned int protocol);
|
|
|
|
#endif /* __VIR_NETLINK_H__ */
|