mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-08-27 11:01:19 +00:00
In many files there are header comments that contain an Author: statement, supposedly reflecting who originally wrote the code. In a large collaborative project like libvirt, any non-trivial file will have been modified by a large number of different contributors. IOW, the Author: comments are quickly out of date, omitting people who have made significant contribitions. In some places Author: lines have been added despite the person merely being responsible for creating the file by moving existing code out of another file. IOW, the Author: lines give an incorrect record of authorship. With this all in mind, the comments are useless as a means to identify who to talk to about code in a particular file. Contributors will always be better off using 'git log' and 'git blame' if they need to find the author of a particular bit of code. This commit thus deletes all Author: comments from the source and adds a rule to prevent them reappearing. The Copyright headers are similarly misleading and inaccurate, however, we cannot delete these as they have legal meaning, despite being largely inaccurate. In addition only the copyright holder is permitted to change their respective copyright statement. Reviewed-by: Erik Skultety <eskultet@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
247 lines
6.4 KiB
C
247 lines
6.4 KiB
C
/*
|
|
* Copyright (C) 2013, 2014 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
|
|
#if WITH_SELINUX
|
|
# include <selinux/selinux.h>
|
|
#endif
|
|
|
|
#include "testutils.h"
|
|
|
|
#include "viridentity.h"
|
|
#include "virerror.h"
|
|
#include "viralloc.h"
|
|
#include "virlog.h"
|
|
|
|
#include "virlockspace.h"
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_NONE
|
|
|
|
VIR_LOG_INIT("tests.identitytest");
|
|
|
|
static int testIdentityAttrs(const void *data ATTRIBUTE_UNUSED)
|
|
{
|
|
int ret = -1;
|
|
virIdentityPtr ident;
|
|
const char *val;
|
|
|
|
if (!(ident = virIdentityNew()))
|
|
goto cleanup;
|
|
|
|
if (virIdentitySetAttr(ident,
|
|
VIR_IDENTITY_ATTR_UNIX_USER_NAME,
|
|
"fred") < 0)
|
|
goto cleanup;
|
|
|
|
if (virIdentityGetAttr(ident,
|
|
VIR_IDENTITY_ATTR_UNIX_USER_NAME,
|
|
&val) < 0)
|
|
goto cleanup;
|
|
|
|
if (STRNEQ_NULLABLE(val, "fred")) {
|
|
VIR_DEBUG("Expected 'fred' got '%s'", NULLSTR(val));
|
|
goto cleanup;
|
|
}
|
|
|
|
if (virIdentityGetAttr(ident,
|
|
VIR_IDENTITY_ATTR_UNIX_GROUP_NAME,
|
|
&val) < 0)
|
|
goto cleanup;
|
|
|
|
if (val != NULL) {
|
|
VIR_DEBUG("Unexpected groupname attribute");
|
|
goto cleanup;
|
|
}
|
|
|
|
if (virIdentitySetAttr(ident,
|
|
VIR_IDENTITY_ATTR_UNIX_USER_NAME,
|
|
"joe") != -1) {
|
|
VIR_DEBUG("Unexpectedly overwrote attribute");
|
|
goto cleanup;
|
|
}
|
|
|
|
if (virIdentityGetAttr(ident,
|
|
VIR_IDENTITY_ATTR_UNIX_USER_NAME,
|
|
&val) < 0)
|
|
goto cleanup;
|
|
|
|
if (STRNEQ_NULLABLE(val, "fred")) {
|
|
VIR_DEBUG("Expected 'fred' got '%s'", NULLSTR(val));
|
|
goto cleanup;
|
|
}
|
|
|
|
ret = 0;
|
|
cleanup:
|
|
virObjectUnref(ident);
|
|
return ret;
|
|
}
|
|
|
|
|
|
static int testIdentityEqual(const void *data ATTRIBUTE_UNUSED)
|
|
{
|
|
int ret = -1;
|
|
virIdentityPtr identa = NULL;
|
|
virIdentityPtr identb = NULL;
|
|
|
|
if (!(identa = virIdentityNew()))
|
|
goto cleanup;
|
|
if (!(identb = virIdentityNew()))
|
|
goto cleanup;
|
|
|
|
if (!virIdentityIsEqual(identa, identb)) {
|
|
VIR_DEBUG("Empty identities were not equal");
|
|
goto cleanup;
|
|
}
|
|
|
|
if (virIdentitySetAttr(identa,
|
|
VIR_IDENTITY_ATTR_UNIX_USER_NAME,
|
|
"fred") < 0)
|
|
goto cleanup;
|
|
|
|
if (virIdentityIsEqual(identa, identb)) {
|
|
VIR_DEBUG("Mis-matched identities should not be equal");
|
|
goto cleanup;
|
|
}
|
|
|
|
if (virIdentitySetAttr(identb,
|
|
VIR_IDENTITY_ATTR_UNIX_USER_NAME,
|
|
"fred") < 0)
|
|
goto cleanup;
|
|
|
|
if (!virIdentityIsEqual(identa, identb)) {
|
|
VIR_DEBUG("Matched identities were not equal");
|
|
goto cleanup;
|
|
}
|
|
|
|
if (virIdentitySetAttr(identa,
|
|
VIR_IDENTITY_ATTR_UNIX_GROUP_NAME,
|
|
"flintstone") < 0)
|
|
goto cleanup;
|
|
if (virIdentitySetAttr(identb,
|
|
VIR_IDENTITY_ATTR_UNIX_GROUP_NAME,
|
|
"flintstone") < 0)
|
|
goto cleanup;
|
|
|
|
if (!virIdentityIsEqual(identa, identb)) {
|
|
VIR_DEBUG("Matched identities were not equal");
|
|
goto cleanup;
|
|
}
|
|
|
|
if (virIdentitySetAttr(identb,
|
|
VIR_IDENTITY_ATTR_SASL_USER_NAME,
|
|
"fred@FLINTSTONE.COM") < 0)
|
|
goto cleanup;
|
|
|
|
if (virIdentityIsEqual(identa, identb)) {
|
|
VIR_DEBUG("Mis-matched identities should not be equal");
|
|
goto cleanup;
|
|
}
|
|
|
|
ret = 0;
|
|
cleanup:
|
|
virObjectUnref(identa);
|
|
virObjectUnref(identb);
|
|
return ret;
|
|
}
|
|
|
|
static int testIdentityGetSystem(const void *data)
|
|
{
|
|
const char *context = data;
|
|
int ret = -1;
|
|
virIdentityPtr ident = NULL;
|
|
const char *val;
|
|
|
|
#if !WITH_SELINUX
|
|
if (context) {
|
|
VIR_DEBUG("libvirt not compiled with SELinux, skipping this test");
|
|
ret = EXIT_AM_SKIP;
|
|
goto cleanup;
|
|
}
|
|
#endif
|
|
|
|
if (!(ident = virIdentityGetSystem())) {
|
|
VIR_DEBUG("Unable to get system identity");
|
|
goto cleanup;
|
|
}
|
|
|
|
if (virIdentityGetAttr(ident,
|
|
VIR_IDENTITY_ATTR_SELINUX_CONTEXT,
|
|
&val) < 0)
|
|
goto cleanup;
|
|
|
|
if (STRNEQ_NULLABLE(val, context)) {
|
|
VIR_DEBUG("Unexpected SELinux context attribute");
|
|
goto cleanup;
|
|
}
|
|
|
|
ret = 0;
|
|
cleanup:
|
|
virObjectUnref(ident);
|
|
return ret;
|
|
}
|
|
|
|
static int testSetFakeSELinuxContext(const void *data ATTRIBUTE_UNUSED)
|
|
{
|
|
#if WITH_SELINUX
|
|
return setcon_raw((security_context_t)data);
|
|
#else
|
|
VIR_DEBUG("libvirt not compiled with SELinux, skipping this test");
|
|
return EXIT_AM_SKIP;
|
|
#endif
|
|
}
|
|
|
|
static int testDisableFakeSELinux(const void *data ATTRIBUTE_UNUSED)
|
|
{
|
|
#if WITH_SELINUX
|
|
return security_disable();
|
|
#else
|
|
VIR_DEBUG("libvirt not compiled with SELinux, skipping this test");
|
|
return EXIT_AM_SKIP;
|
|
#endif
|
|
}
|
|
|
|
static int
|
|
mymain(void)
|
|
{
|
|
const char *context = "unconfined_u:unconfined_r:unconfined_t:s0";
|
|
int ret = 0;
|
|
|
|
if (virTestRun("Identity attributes ", testIdentityAttrs, NULL) < 0)
|
|
ret = -1;
|
|
if (virTestRun("Identity equality ", testIdentityEqual, NULL) < 0)
|
|
ret = -1;
|
|
if (virTestRun("Setting fake SELinux context ", testSetFakeSELinuxContext, context) < 0)
|
|
ret = -1;
|
|
if (virTestRun("System identity (fake SELinux enabled) ", testIdentityGetSystem, context) < 0)
|
|
ret = -1;
|
|
if (virTestRun("Disabling fake SELinux ", testDisableFakeSELinux, NULL) < 0)
|
|
ret = -1;
|
|
if (virTestRun("System identity (fake SELinux disabled) ", testIdentityGetSystem, NULL) < 0)
|
|
ret = -1;
|
|
|
|
return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
|
|
}
|
|
|
|
#if WITH_SELINUX
|
|
VIR_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/libsecurityselinuxhelper.so")
|
|
#else
|
|
VIR_TEST_MAIN(mymain)
|
|
#endif
|