The bridge reattach functionality in this function should be called for interface types other than just type='network', so make it callable for any type - it just becomes a NOP for types where no action is needed. In the case of <interface type='network'> we need to create a port in the network driver, and for both type='network and type='bridge' we need to reattach the bridge device (note that virDomainNetGetActualBridgeName() gets the bridge name from the appropriate (and different!) location for either type of interface). All other interfaces currently require no action. modifying callers of this function to actually call it for all interface types is in the next patch. For now the behavior should be identical pre and post-patch. (NB: the conn argument can now legitimately be NULL, so we need to change the ATTRIBUTE_NONNULL() directive for the function's declaration - I noticed when making this change that argument 3 (the NetDefPtr) could never be NULL, so I added ATTRIBUTE_NONNULL(3) while removing ATTRIBUTE_NONNULL(1) (conn)). Signed-off-by: Laine Stump <laine@redhat.com> Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>Reviewed-by: Michal Privoznik <mprivozn@redhat.com>#Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Libvirt API for virtualization
Libvirt provides a portable, long term stable C API for managing the virtualization technologies provided by many operating systems. It includes support for QEMU, KVM, Xen, LXC, bhyve, Virtuozzo, VMware vCenter and ESX, VMware Desktop, Hyper-V, VirtualBox and the POWER Hypervisor.
For some of these hypervisors, it provides a stateful management daemon which runs on the virtualization host allowing access to the API both by non-privileged local users and remote users.
Layered packages provide bindings of the libvirt C API into other languages including Python, Perl, PHP, Go, Java, OCaml, as well as mappings into object systems such as GObject, CIM and SNMP.
Further information about the libvirt project can be found on the website:
License
The libvirt C API is distributed under the terms of GNU Lesser
General Public License, version 2.1 (or later). Some parts of the code
that are not part of the C library may have the more restrictive GNU
General Public License, version 2.0 (or later). See the files
COPYING.LESSER
and COPYING
for full license
terms & conditions.
Installation
Instructions on building and installing libvirt can be found on the website:
https://libvirt.org/compiling.html
Contributing
The libvirt project welcomes contributions in many ways. For most components the best way to contribute is to send patches to the primary development mailing list. Further guidance on this can be found on the website:
https://libvirt.org/contribute.html
Contact
The libvirt project has two primary mailing lists:
- libvirt-users@redhat.com (for user discussions)
- libvir-list@redhat.com (for development only)
Further details on contacting the project are available on the website: