mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-04 21:35:45 +00:00
55ea7be7d9
For stateless, client side drivers, it is never correct to
probe for secondary drivers. It is only ever appropriate to
use the secondary driver that is associated with the
hypervisor in question. As a result the ESX & HyperV drivers
have both been forced to do hacks where they register no-op
drivers for the ones they don't implement.
For stateful, server side drivers, we always just want to
use the same built-in shared driver. The exception is
virtualbox which is really a stateless driver and so wants
to use its own server side secondary drivers. To deal with
this virtualbox has to be built as 3 separate loadable
modules to allow registration to work in the right order.
This can all be simplified by introducing a new struct
recording the precise set of secondary drivers each
hypervisor driver wants
struct _virConnectDriver {
virHypervisorDriverPtr hypervisorDriver;
virInterfaceDriverPtr interfaceDriver;
virNetworkDriverPtr networkDriver;
virNodeDeviceDriverPtr nodeDeviceDriver;
virNWFilterDriverPtr nwfilterDriver;
virSecretDriverPtr secretDriver;
virStorageDriverPtr storageDriver;
};
Instead of registering the hypervisor driver, we now
just register a virConnectDriver instead. This allows
us to remove all probing of secondary drivers. Once we
have chosen the primary driver, we immediately know the
correct secondary drivers to use.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
105 lines
3.3 KiB
C
105 lines
3.3 KiB
C
/*
|
|
* driver-secret.h: entry points for secret drivers
|
|
*
|
|
* Copyright (C) 2006-2014 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef __VIR_DRIVER_SECRET_H__
|
|
# define __VIR_DRIVER_SECRET_H__
|
|
|
|
# ifndef __VIR_DRIVER_H_INCLUDES___
|
|
# error "Don't include this file directly, only use driver.h"
|
|
# endif
|
|
|
|
enum {
|
|
/* This getValue call is inside libvirt, override the "private" flag.
|
|
This flag cannot be set by outside callers. */
|
|
VIR_SECRET_GET_VALUE_INTERNAL_CALL = 1 << 0,
|
|
};
|
|
|
|
typedef virSecretPtr
|
|
(*virDrvSecretLookupByUUID)(virConnectPtr conn,
|
|
const unsigned char *uuid);
|
|
|
|
typedef virSecretPtr
|
|
(*virDrvSecretLookupByUsage)(virConnectPtr conn,
|
|
int usageType,
|
|
const char *usageID);
|
|
|
|
typedef virSecretPtr
|
|
(*virDrvSecretDefineXML)(virConnectPtr conn,
|
|
const char *xml,
|
|
unsigned int flags);
|
|
|
|
typedef char *
|
|
(*virDrvSecretGetXMLDesc)(virSecretPtr secret,
|
|
unsigned int flags);
|
|
|
|
typedef int
|
|
(*virDrvSecretSetValue)(virSecretPtr secret,
|
|
const unsigned char *value,
|
|
size_t value_size,
|
|
unsigned int flags);
|
|
|
|
typedef unsigned char *
|
|
(*virDrvSecretGetValue)(virSecretPtr secret,
|
|
size_t *value_size,
|
|
unsigned int flags,
|
|
unsigned int internalFlags);
|
|
|
|
typedef int
|
|
(*virDrvSecretUndefine)(virSecretPtr secret);
|
|
|
|
typedef int
|
|
(*virDrvConnectNumOfSecrets)(virConnectPtr conn);
|
|
|
|
typedef int
|
|
(*virDrvConnectListSecrets)(virConnectPtr conn,
|
|
char **uuids,
|
|
int maxuuids);
|
|
|
|
typedef int
|
|
(*virDrvConnectListAllSecrets)(virConnectPtr conn,
|
|
virSecretPtr **secrets,
|
|
unsigned int flags);
|
|
|
|
typedef struct _virSecretDriver virSecretDriver;
|
|
typedef virSecretDriver *virSecretDriverPtr;
|
|
|
|
/**
|
|
* _virSecretDriver:
|
|
*
|
|
* Structure associated to a driver for storing secrets, defining the various
|
|
* entry points for it.
|
|
*/
|
|
struct _virSecretDriver {
|
|
const char *name; /* the name of the driver */
|
|
virDrvConnectNumOfSecrets connectNumOfSecrets;
|
|
virDrvConnectListSecrets connectListSecrets;
|
|
virDrvConnectListAllSecrets connectListAllSecrets;
|
|
virDrvSecretLookupByUUID secretLookupByUUID;
|
|
virDrvSecretLookupByUsage secretLookupByUsage;
|
|
virDrvSecretDefineXML secretDefineXML;
|
|
virDrvSecretGetXMLDesc secretGetXMLDesc;
|
|
virDrvSecretSetValue secretSetValue;
|
|
virDrvSecretGetValue secretGetValue;
|
|
virDrvSecretUndefine secretUndefine;
|
|
};
|
|
|
|
|
|
#endif /* __VIR_DRIVER_SECRET_H__ */
|