libvirt/src
Michal Privoznik dd7bfb2cdc networkStateInitialize: Don't lock network driver
There's no need to lock the network driver, as network driver
initialization is done prior accepting any client. There's nobody
to hop in and do something over partially initialized driver. Nor
qemu driver is doing that.

==30532== Observed (incorrect) order is: acquisition of lock at 0x1439EF50
==30532==    at 0x4C31A26: pthread_mutex_lock (in /usr/lib64/valgrind/vgpreload_helgrind-amd64-linux.so)
==30532==    by 0x5324895: virMutexLock (virthread.c:88)
==30532==    by 0x5307E86: virObjectLock (virobject.c:323)
==30532==    by 0x5396440: virNetworkObjListForEach (network_conf.c:4511)
==30532==    by 0x19B29308: networkStateInitialize (bridge_driver.c:686)
==30532==    by 0x53E1CCC: virStateInitialize (libvirt.c:777)
==30532==    by 0x11DEB7: daemonRunStateInit (libvirtd.c:906)
==30532==    by 0x5324B6A: virThreadHelper (virthread.c:197)
==30532==    by 0x4C30456: ??? (in /usr/lib64/valgrind/vgpreload_helgrind-amd64-linux.so)
==30532==    by 0xA1EC1F2: start_thread (in /lib64/libpthread-2.19.so)
==30532==    by 0xA4EDC8C: clone (in /lib64/libc-2.19.so)
==30532==
==30532==  followed by a later acquisition of lock at 0x1439CD60
==30532==    at 0x4C31A26: pthread_mutex_lock (in /usr/lib64/valgrind/vgpreload_helgrind-amd64-linux.so)
==30532==    by 0x5324895: virMutexLock (virthread.c:88)
==30532==    by 0x19B27B2C: networkDriverLock (bridge_driver.c:102)
==30532==    by 0x19B27B60: networkGetDnsmasqCaps (bridge_driver.c:113)
==30532==    by 0x19B2856A: networkUpdateState (bridge_driver.c:389)
==30532==    by 0x53963E9: virNetworkObjListForEachHelper (network_conf.c:4488)
==30532==    by 0x52E2224: virHashForEach (virhash.c:521)
==30532==    by 0x539645B: virNetworkObjListForEach (network_conf.c:4512)
==30532==    by 0x19B29308: networkStateInitialize (bridge_driver.c:686)
==30532==    by 0x53E1CCC: virStateInitialize (libvirt.c:777)
==30532==    by 0x11DEB7: daemonRunStateInit (libvirtd.c:906)
==30532==    by 0x5324B6A: virThreadHelper (virthread.c:197)
==30532==
==30532== Required order was established by acquisition of lock at 0x1439CD60
==30532==    at 0x4C31A26: pthread_mutex_lock (in /usr/lib64/valgrind/vgpreload_helgrind-amd64-linux.so)
==30532==    by 0x5324895: virMutexLock (virthread.c:88)
==30532==    by 0x19B27B2C: networkDriverLock (bridge_driver.c:102)
==30532==    by 0x19B28DF9: networkStateInitialize (bridge_driver.c:609)
==30532==    by 0x53E1CCC: virStateInitialize (libvirt.c:777)
==30532==    by 0x11DEB7: daemonRunStateInit (libvirtd.c:906)
==30532==    by 0x5324B6A: virThreadHelper (virthread.c:197)
==30532==    by 0x4C30456: ??? (in /usr/lib64/valgrind/vgpreload_helgrind-amd64-linux.so)
==30532==    by 0xA1EC1F2: start_thread (in /lib64/libpthread-2.19.so)
==30532==    by 0xA4EDC8C: clone (in /lib64/libc-2.19.so)
==30532==
==30532==  followed by a later acquisition of lock at 0x1439EF50
==30532==    at 0x4C31A26: pthread_mutex_lock (in /usr/lib64/valgrind/vgpreload_helgrind-amd64-linux.so)
==30532==    by 0x5324895: virMutexLock (virthread.c:88)
==30532==    by 0x5307E86: virObjectLock (virobject.c:323)
==30532==    by 0x538A09C: virNetworkAssignDef (network_conf.c:527)
==30532==    by 0x5391EB2: virNetworkLoadState (network_conf.c:3008)
==30532==    by 0x53922D4: virNetworkLoadAllState (network_conf.c:3128)
==30532==    by 0x19B2929A: networkStateInitialize (bridge_driver.c:671)
==30532==    by 0x53E1CCC: virStateInitialize (libvirt.c:777)
==30532==    by 0x11DEB7: daemonRunStateInit (libvirtd.c:906)
==30532==    by 0x5324B6A: virThreadHelper (virthread.c:197)
==30532==    by 0x4C30456: ??? (in /usr/lib64/valgrind/vgpreload_helgrind-amd64-linux.so)
==30532==    by 0xA1EC1F2: start_thread (in /lib64/libpthread-2.19.so)

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2015-03-23 09:56:15 +01:00
..
access build: fix mingw printing of pid 2014-12-08 15:01:24 -07:00
bhyve Fix common misspellings 2015-03-23 09:01:30 +01:00
conf util: clean up #includes of virnetdevopenvswitch.h 2015-03-18 14:43:47 -04:00
cpu Fix common misspellings 2015-03-23 09:01:30 +01:00
esx Add flags argument to virStorageVolDefParse* 2015-03-02 08:07:11 +01:00
hyperv conf: Replace access to def->mem.max_balloon with accessor functions 2015-03-16 14:26:51 +01:00
interface Removing probing of secondary drivers 2015-01-27 12:02:04 +00:00
libxl libxl: use xenlight pkgconfig file if present 2015-03-19 16:13:26 -06:00
locking sanlock: Don't spam logs with "target pid not found" 2015-03-09 13:36:40 +01:00
lxc util: clean up #includes of virnetdevopenvswitch.h 2015-03-18 14:43:47 -04:00
network networkStateInitialize: Don't lock network driver 2015-03-23 09:56:15 +01:00
node_device SRIOV NIC offload feature discovery 2015-03-05 11:31:05 +01:00
nwfilter Removing probing of secondary drivers 2015-01-27 12:02:04 +00:00
openvz conf: Replace access to def->mem.max_balloon with accessor functions 2015-03-16 14:26:51 +01:00
parallels parallels: fix libvirt crash if parallelsNetworkOpen fails 2015-03-19 16:28:40 +01:00
phyp conf: Replace access to def->mem.max_balloon with accessor functions 2015-03-16 14:26:51 +01:00
qemu Fix common misspellings 2015-03-23 09:01:30 +01:00
remote RPC: Allow HW address in remote_domain_interface struct to be NULL 2015-03-18 09:12:36 +01:00
rpc remote: Implement the plumbing for virDomainPinIOThread 2015-03-11 12:23:33 -04:00
secret Removing probing of secondary drivers 2015-01-27 12:02:04 +00:00
security security: Resolve Coverity RESOURCE_LEAK 2015-02-14 07:31:36 -05:00
storage Introduce virBitmapIsBitSet 2015-03-13 15:31:33 +01:00
test conf: Replace access to def->mem.max_balloon with accessor functions 2015-03-16 14:26:51 +01:00
uml conf: Replace access to def->mem.max_balloon with accessor functions 2015-03-16 14:26:51 +01:00
util Fix common misspellings 2015-03-23 09:01:30 +01:00
vbox Fix common misspellings 2015-03-23 09:01:30 +01:00
vmware conf: Replace access to def->mem.max_balloon with accessor functions 2015-03-16 14:26:51 +01:00
vmx conf: Replace access to def->mem.max_balloon with accessor functions 2015-03-16 14:26:51 +01:00
xen Fix common misspellings 2015-03-23 09:01:30 +01:00
xenapi conf: Replace access to def->mem.max_balloon with accessor functions 2015-03-16 14:26:51 +01:00
xenconfig Fix common misspellings 2015-03-23 09:01:30 +01:00
check-aclperms.pl
check-aclrules.pl
check-driverimpls.pl Removing probing of secondary drivers 2015-01-27 12:02:04 +00:00
check-drivername.pl
check-symfile.pl
check-symsorting.pl
datatypes.c Fix common misspellings 2015-03-23 09:01:30 +01:00
datatypes.h Remove all secondary driver private data fields 2015-01-27 12:02:04 +00:00
driver-hypervisor.h domifaddr: Implement the public APIs 2015-03-17 15:15:38 +00:00
driver-interface.h Removing probing of secondary drivers 2015-01-27 12:02:04 +00:00
driver-network.h Removing probing of secondary drivers 2015-01-27 12:02:04 +00:00
driver-nodedev.h Removing probing of secondary drivers 2015-01-27 12:02:04 +00:00
driver-nwfilter.h Removing probing of secondary drivers 2015-01-27 12:02:04 +00:00
driver-secret.h Removing probing of secondary drivers 2015-01-27 12:02:04 +00:00
driver-state.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver-storage.h Removing probing of secondary drivers 2015-01-27 12:02:04 +00:00
driver-stream.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver.c Search for schemas and cpu_map.xml in source tree 2015-02-19 15:25:04 +01:00
driver.h Removing probing of secondary drivers 2015-01-27 12:02:04 +00:00
dtrace2systemtap.pl
fdstream.c storage: tweak condition to properly test lseek 2015-03-04 14:51:44 +01:00
fdstream.h fdstream: introduce virFDStreamOpenBlockDevice 2014-08-25 10:46:13 +04:00
gnutls_1_0_compat.h
internal.h Conditionalize use of -Wno-suggest-attribute=format pragma 2015-01-16 17:12:27 +00:00
libvirt_atomic.syms
libvirt_driver_modules.syms Use virFileFindResource to locate driver plugins 2014-04-25 11:59:46 +01:00
libvirt_esx.syms
libvirt_gnutls.syms
libvirt_internal.h don't disable state driver when libvirtd is not built 2015-01-27 12:02:04 +00:00
libvirt_libssh2.syms
libvirt_linux.syms util: virstatslinux: make more generic 2014-07-15 22:00:59 +04:00
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms cgroup: Add accessors for cpuset.memory_migrate 2015-03-20 13:40:02 +01:00
libvirt_probes.d Add systemd/dtrace probes for DBus APIs 2015-01-15 11:07:13 +00:00
libvirt_public.syms domifaddr: Implement the public APIs 2015-03-17 15:15:38 +00:00
libvirt_qemu_probes.d
libvirt_qemu.syms qemu: new API for tracking arbitrary monitor events 2014-03-20 11:25:37 -06:00
libvirt_remote.syms remote: create virNetServerServiceNewFDOrUNIX() wrapper 2014-08-22 09:12:13 +02:00
libvirt_sasl.syms
libvirt_vmware.syms
libvirt_vmx.syms
libvirt_xenconfig.syms Revert "src/xenconfig: Xen-xl parser" 2015-01-12 10:15:13 -07:00
libvirt_xenxlconfig.syms Introduce support for parsing/formatting Xen xl config format 2015-01-14 08:28:50 -07:00
libvirt-domain-snapshot.c Move virDomainSnapshot related APIs out of libvirt.c 2014-10-24 15:59:22 +01:00
libvirt-domain.c RPC: Allow HW address in remote_domain_interface struct to be NULL 2015-03-18 09:12:36 +01:00
libvirt-host.c Add VIR_CONNECT_BASELINE_CPU_MIGRATABLE flag 2015-03-02 07:59:12 +01:00
libvirt-interface.c iface-define: update and unify documentation 2015-03-09 14:47:07 +01:00
libvirt-lxc.c Remove unnecessary curly brackets in rest of src/[a-n]*/ 2014-11-14 17:13:36 +01:00
libvirt-lxc.pc.in Fix build-time pkg-config files in VPATH 2014-11-06 15:59:28 +01:00
libvirt-network.c net-define: update or unify documentation 2015-03-09 14:48:38 +01:00
libvirt-nodedev.c Remove unnecessary curly brackets in rest of src/[a-n]*/ 2014-11-14 17:13:36 +01:00
libvirt-nwfilter.c Move virNWFilter related APIs out of libvirt.c 2014-10-24 16:15:46 +01:00
libvirt-qemu.c Indent top-level labels by one space in the rest of src/ 2014-03-25 14:58:40 +01:00
libvirt-qemu.pc.in Fix build-time pkg-config files in VPATH 2014-11-06 15:59:28 +01:00
libvirt-secret.c Move virSecret related APIs out of libvirt.c 2014-10-24 16:39:05 +01:00
libvirt-storage.c pool-define: update and unify documentation 2015-03-09 14:47:53 +01:00
libvirt-stream.c Move virStream related APIs out of libvirt.c 2014-10-24 16:42:49 +01:00
libvirt.c Removing probing of secondary drivers 2015-01-27 12:02:04 +00:00
libvirt.conf
libvirt.pc.in Fix build-time pkg-config files in VPATH 2014-11-06 15:59:28 +01:00
lock_protocol-structs
lxc_monitor_protocol-structs
lxc_protocol-structs
Makefile.am util: functions to support binding/unbinding midonet virtualports 2015-03-17 12:56:37 -04:00
nodeinfo.c Introduce virBitmapIsBitSet 2015-03-13 15:31:33 +01:00
nodeinfo.h Fix virCgroupGetPercpuStats with non-continuous present CPUs 2015-01-22 17:01:11 +01:00
nodeinfopriv.h nodeinfo: Introduce @arch to linuxNodeInfoCPUPopulate 2014-06-20 15:46:52 +02:00
qemu_protocol-structs qemu: wire up RPC for qemu monitor events 2014-03-20 11:25:37 -06:00
README bhyve: add basic documentation 2014-03-01 23:44:58 +04:00
remote_protocol-structs RPC: Allow HW address in remote_domain_interface struct to be NULL 2015-03-18 09:12:36 +01:00
virkeepaliveprotocol-structs
virnetprotocol-structs

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * bhyve         - bhyve - The BSD Hypervisor
 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * phyp/         - IBM Power Hypervisor using CLI tools over SSH
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * uml/          - User Mode Linux
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore
 * xenapi/       - Xen using libxenserver


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers.
The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories