libvirt/src/util/virfcp.c
Sukrit Bhatnagar 10f888e64e util: fcp: use VIR_AUTOFREE instead of VIR_FREE for scalar types
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOFREE macro for declaring scalar variables, majority
of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.

Signed-off-by: Sukrit Bhatnagar <skrtbhtngr@gmail.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
2018-07-14 17:01:30 +02:00

92 lines
2.2 KiB
C

/*
* virfcp.c: Utility functions for the Fibre Channel Protocol
*
* Copyright (C) 2017 IBM Corporation
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library. If not, see
* <http://www.gnu.org/licenses/>.
*
* Author: Bjoern Walk <bwalk@linux.vnet.ibm.com>
*/
#include <config.h>
#include "internal.h"
#include "viralloc.h"
#include "virfile.h"
#include "virerror.h"
#include "virstring.h"
#include "virfcp.h"
#define VIR_FROM_THIS VIR_FROM_NONE
#ifdef __linux__
# define SYSFS_FC_RPORT_PATH "/sys/class/fc_remote_ports"
bool
virFCIsCapableRport(const char *rport)
{
VIR_AUTOFREE(char *) path = NULL;
if (virBuildPath(&path, SYSFS_FC_RPORT_PATH, rport) < 0)
return false;
return virFileExists(path);
}
int
virFCReadRportValue(const char *rport,
const char *entry,
char **result)
{
VIR_AUTOFREE(char *) buf = NULL;
char *p = NULL;
if (virFileReadValueString(&buf, "%s/%s/%s",
SYSFS_FC_RPORT_PATH, rport, entry) < 0) {
return -1;
}
if ((p = strchr(buf, '\n')))
*p = '\0';
if (VIR_STRDUP(*result, buf) < 0)
return -1;
return 0;
}
#else
bool
virFCIsCapableRport(const char *rport ATTRIBUTE_UNUSED)
{
virReportSystemError(ENOSYS, "%s", _("Not supported on this platform"));
return false;
}
int
virFCReadRportValue(const char *rport ATTRIBUTE_UNUSED,
const char *entry ATTRIBUTE_UNUSED,
char **result ATTRIBUTE_UNUSED)
{
virReportSystemError(ENOSYS, "%s", _("Not supported on this platform"));
return -1;
}
#endif