mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-06 22:35:46 +00:00
407a281a8e
This reverts commit e4b980c853.
When a binary links against a .a archive (as opposed to a shared library),
any symbols which are marked as 'weak' get silently dropped. As a result
when the binary later runs, those 'weak' functions have an address of
0x0 and thus crash when run.
This happened with virtlogd and virtlockd because they don't link to
libvirt.so, but instead just libvirt_util.a and libvirt_rpc.a. The
virRandomBits symbols was weak and so left out of the virtlogd &
virtlockd binaries, despite being required by virHashTable functions.
Various other binaries like libvirt_lxc, libvirt_iohelper, etc also
link directly to .a files instead of libvirt.so, so are potentially
at risk of dropping symbols leading to a later runtime crash.
This is normal linker behaviour because a weak symbol is not treated
as undefined, so nothing forces it to be pulled in from the .a You
have to force the linker to pull in weak symbols using -u$SYMNAME
which is not a practical approach.
This risk is silent bad linkage that affects runtime behaviour is
not acceptable for a fix that was merely trying to fix the test
suite. So stop using __weak__ again.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
356 lines
13 KiB
C
356 lines
13 KiB
C
/*
|
|
* virfile.h: safer file handling
|
|
*
|
|
* Copyright (C) 2010-2014 Red Hat, Inc.
|
|
* Copyright (C) 2010 IBM Corporation
|
|
* Copyright (C) 2010 Stefan Berger
|
|
* Copyright (C) 2010 Eric Blake
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
|
|
#ifndef __VIR_FILE_H_
|
|
# define __VIR_FILE_H_
|
|
|
|
# include <stdio.h>
|
|
# include <dirent.h>
|
|
|
|
# include "internal.h"
|
|
# include "virbitmap.h"
|
|
# include "virstoragefile.h"
|
|
|
|
typedef enum {
|
|
VIR_FILE_CLOSE_PRESERVE_ERRNO = 1 << 0,
|
|
VIR_FILE_CLOSE_IGNORE_EBADF = 1 << 1,
|
|
VIR_FILE_CLOSE_DONT_LOG = 1 << 2,
|
|
} virFileCloseFlags;
|
|
|
|
ssize_t saferead(int fd, void *buf, size_t count) ATTRIBUTE_RETURN_CHECK;
|
|
ssize_t safewrite(int fd, const void *buf, size_t count)
|
|
ATTRIBUTE_RETURN_CHECK;
|
|
int safezero(int fd, off_t offset, off_t len)
|
|
ATTRIBUTE_RETURN_CHECK;
|
|
|
|
/* Don't call these directly - use the macros below */
|
|
int virFileClose(int *fdptr, virFileCloseFlags flags)
|
|
ATTRIBUTE_RETURN_CHECK;
|
|
int virFileFclose(FILE **file, bool preserve_errno) ATTRIBUTE_RETURN_CHECK;
|
|
FILE *virFileFdopen(int *fdptr, const char *mode) ATTRIBUTE_RETURN_CHECK;
|
|
|
|
/* For use on normal paths; caller must check return value,
|
|
and failure sets errno per close. */
|
|
# define VIR_CLOSE(FD) virFileClose(&(FD), 0)
|
|
# define VIR_FCLOSE(FILE) virFileFclose(&(FILE), false)
|
|
|
|
/* Wrapper around fdopen that consumes fd on success. */
|
|
# define VIR_FDOPEN(FD, MODE) virFileFdopen(&(FD), MODE)
|
|
|
|
/* For use on cleanup paths; errno is unaffected by close,
|
|
and no return value to worry about. */
|
|
# define VIR_FORCE_CLOSE(FD) \
|
|
ignore_value(virFileClose(&(FD), VIR_FILE_CLOSE_PRESERVE_ERRNO))
|
|
# define VIR_FORCE_FCLOSE(FILE) ignore_value(virFileFclose(&(FILE), true))
|
|
|
|
/* Similar VIR_FORCE_CLOSE() but ignores EBADF errors since they are expected
|
|
* during mass close after fork(). */
|
|
# define VIR_MASS_CLOSE(FD) \
|
|
ignore_value(virFileClose(&(FD), \
|
|
VIR_FILE_CLOSE_PRESERVE_ERRNO | \
|
|
VIR_FILE_CLOSE_IGNORE_EBADF))
|
|
|
|
# define VIR_LOG_CLOSE(FD) \
|
|
ignore_value(virFileClose(&(FD), \
|
|
VIR_FILE_CLOSE_PRESERVE_ERRNO | \
|
|
VIR_FILE_CLOSE_DONT_LOG))
|
|
|
|
/* Opaque type for managing a wrapper around a fd. */
|
|
struct _virFileWrapperFd;
|
|
|
|
typedef struct _virFileWrapperFd virFileWrapperFd;
|
|
typedef virFileWrapperFd *virFileWrapperFdPtr;
|
|
|
|
int virFileDirectFdFlag(void);
|
|
|
|
typedef enum {
|
|
VIR_FILE_WRAPPER_BYPASS_CACHE = (1 << 0),
|
|
VIR_FILE_WRAPPER_NON_BLOCKING = (1 << 1),
|
|
} virFileWrapperFdFlags;
|
|
|
|
virFileWrapperFdPtr virFileWrapperFdNew(int *fd,
|
|
const char *name,
|
|
unsigned int flags)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_RETURN_CHECK;
|
|
|
|
int virFileWrapperFdClose(virFileWrapperFdPtr dfd);
|
|
|
|
void virFileWrapperFdFree(virFileWrapperFdPtr dfd);
|
|
|
|
int virFileLock(int fd, bool shared, off_t start, off_t len, bool waitForLock);
|
|
int virFileUnlock(int fd, off_t start, off_t len);
|
|
|
|
typedef int (*virFileRewriteFunc)(int fd, const void *opaque);
|
|
int virFileRewrite(const char *path,
|
|
mode_t mode,
|
|
virFileRewriteFunc rewrite,
|
|
const void *opaque);
|
|
int virFileRewriteStr(const char *path,
|
|
mode_t mode,
|
|
const char *str);
|
|
|
|
int virFileTouch(const char *path, mode_t mode);
|
|
|
|
int virFileUpdatePerm(const char *path,
|
|
mode_t mode_remove,
|
|
mode_t mode_add);
|
|
|
|
int virFileLoopDeviceAssociate(const char *file,
|
|
char **dev);
|
|
|
|
int virFileNBDDeviceAssociate(const char *file,
|
|
virStorageFileFormat fmt,
|
|
bool readonly,
|
|
char **dev);
|
|
|
|
int virFileDeleteTree(const char *dir);
|
|
|
|
int virFileReadHeaderFD(int fd, int maxlen, char **buf)
|
|
ATTRIBUTE_RETURN_CHECK ATTRIBUTE_NONNULL(3);
|
|
int virFileReadLimFD(int fd, int maxlen, char **buf)
|
|
ATTRIBUTE_RETURN_CHECK ATTRIBUTE_NONNULL(3);
|
|
int virFileReadAll(const char *path, int maxlen, char **buf)
|
|
ATTRIBUTE_RETURN_CHECK ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(3);
|
|
int virFileReadAllQuiet(const char *path, int maxlen, char **buf)
|
|
ATTRIBUTE_RETURN_CHECK ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(3);
|
|
int virFileReadBufQuiet(const char *file, char *buf, int len)
|
|
ATTRIBUTE_RETURN_CHECK ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
|
|
|
|
int virFileWriteStr(const char *path, const char *str, mode_t mode)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_RETURN_CHECK;
|
|
|
|
int virFileMatchesNameSuffix(const char *file,
|
|
const char *name,
|
|
const char *suffix);
|
|
|
|
int virFileHasSuffix(const char *str,
|
|
const char *suffix);
|
|
|
|
int virFileStripSuffix(char *str,
|
|
const char *suffix) ATTRIBUTE_RETURN_CHECK;
|
|
|
|
int virFileLinkPointsTo(const char *checkLink,
|
|
const char *checkDest)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
|
|
int virFileRelLinkPointsTo(const char *directory,
|
|
const char *checkLink,
|
|
const char *checkDest)
|
|
ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3);
|
|
|
|
int virFileResolveLink(const char *linkpath,
|
|
char **resultpath) ATTRIBUTE_RETURN_CHECK;
|
|
int virFileResolveAllLinks(const char *linkpath,
|
|
char **resultpath) ATTRIBUTE_RETURN_CHECK;
|
|
|
|
int virFileIsLink(const char *linkpath)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_RETURN_CHECK;
|
|
|
|
int virFileReadLink(const char *linkpath, char **resultpath)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_RETURN_CHECK;
|
|
|
|
char *virFindFileInPath(const char *file);
|
|
|
|
char *virFileFindResource(const char *filename,
|
|
const char *builddir,
|
|
const char *installdir)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3);
|
|
char *virFileFindResourceFull(const char *filename,
|
|
const char *prefix,
|
|
const char *suffix,
|
|
const char *builddir,
|
|
const char *installdir,
|
|
const char *envname)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(4) ATTRIBUTE_NONNULL(5);
|
|
void virFileActivateDirOverride(const char *argv0)
|
|
ATTRIBUTE_NONNULL(1);
|
|
|
|
off_t virFileLength(const char *path, int fd) ATTRIBUTE_NONNULL(1);
|
|
bool virFileIsDir (const char *file) ATTRIBUTE_NONNULL(1);
|
|
bool virFileExists(const char *file) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NOINLINE;
|
|
bool virFileIsExecutable(const char *file) ATTRIBUTE_NONNULL(1);
|
|
|
|
enum {
|
|
VIR_FILE_SHFS_NFS = (1 << 0),
|
|
VIR_FILE_SHFS_GFS2 = (1 << 1),
|
|
VIR_FILE_SHFS_OCFS = (1 << 2),
|
|
VIR_FILE_SHFS_AFS = (1 << 3),
|
|
VIR_FILE_SHFS_SMB = (1 << 4),
|
|
VIR_FILE_SHFS_CIFS = (1 << 5),
|
|
};
|
|
|
|
int virFileIsSharedFSType(const char *path, int fstypes) ATTRIBUTE_NONNULL(1);
|
|
int virFileIsSharedFS(const char *path) ATTRIBUTE_NONNULL(1);
|
|
int virFileIsMountPoint(const char *file) ATTRIBUTE_NONNULL(1);
|
|
|
|
int virFileGetMountSubtree(const char *mtabpath,
|
|
const char *prefix,
|
|
char ***mountsret,
|
|
size_t *nmountsret) ATTRIBUTE_RETURN_CHECK;
|
|
int virFileGetMountReverseSubtree(const char *mtabpath,
|
|
const char *prefix,
|
|
char ***mountsret,
|
|
size_t *nmountsret) ATTRIBUTE_RETURN_CHECK;
|
|
|
|
char *virFileSanitizePath(const char *path);
|
|
|
|
enum {
|
|
VIR_FILE_OPEN_NONE = 0,
|
|
VIR_FILE_OPEN_NOFORK = (1 << 0),
|
|
VIR_FILE_OPEN_FORK = (1 << 1),
|
|
VIR_FILE_OPEN_FORCE_MODE = (1 << 2),
|
|
VIR_FILE_OPEN_FORCE_OWNER = (1 << 3),
|
|
};
|
|
int virFileAccessibleAs(const char *path, int mode,
|
|
uid_t uid, gid_t gid)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_RETURN_CHECK;
|
|
int virFileOpenAs(const char *path, int openflags, mode_t mode,
|
|
uid_t uid, gid_t gid,
|
|
unsigned int flags)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_RETURN_CHECK;
|
|
int virFileRemove(const char *path, uid_t uid, gid_t gid);
|
|
|
|
enum {
|
|
VIR_DIR_CREATE_NONE = 0,
|
|
VIR_DIR_CREATE_AS_UID = (1 << 0),
|
|
VIR_DIR_CREATE_ALLOW_EXIST = (1 << 1),
|
|
};
|
|
int virDirCreate(const char *path, mode_t mode, uid_t uid, gid_t gid,
|
|
unsigned int flags) ATTRIBUTE_RETURN_CHECK;
|
|
int virDirOpen(DIR **dirp, const char *dirname)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_RETURN_CHECK;
|
|
int virDirOpenIfExists(DIR **dirp, const char *dirname)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_RETURN_CHECK;
|
|
int virDirOpenQuiet(DIR **dirp, const char *dirname)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_RETURN_CHECK;
|
|
int virDirRead(DIR *dirp, struct dirent **ent, const char *dirname)
|
|
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_RETURN_CHECK;
|
|
void virDirClose(DIR **dirp)
|
|
ATTRIBUTE_NONNULL(1);
|
|
# define VIR_DIR_CLOSE(dir) virDirClose(&(dir))
|
|
|
|
int virFileMakePath(const char *path) ATTRIBUTE_RETURN_CHECK;
|
|
int virFileMakePathWithMode(const char *path,
|
|
mode_t mode) ATTRIBUTE_RETURN_CHECK;
|
|
int virFileMakeParentPath(const char *path) ATTRIBUTE_RETURN_CHECK;
|
|
|
|
char *virFileBuildPath(const char *dir,
|
|
const char *name,
|
|
const char *ext) ATTRIBUTE_RETURN_CHECK;
|
|
|
|
|
|
# ifdef WIN32
|
|
/* On Win32, the canonical directory separator is the backslash, and
|
|
* the search path separator is the semicolon. Note that also the
|
|
* (forward) slash works as directory separator.
|
|
*/
|
|
# define VIR_FILE_DIR_SEPARATOR '\\'
|
|
# define VIR_FILE_DIR_SEPARATOR_S "\\"
|
|
# define VIR_FILE_IS_DIR_SEPARATOR(c) ((c) == VIR_FILE_DIR_SEPARATOR || (c) == '/')
|
|
# define VIR_FILE_PATH_SEPARATOR ';'
|
|
# define VIR_FILE_PATH_SEPARATOR_S ";"
|
|
|
|
# else /* !WIN32 */
|
|
|
|
# define VIR_FILE_DIR_SEPARATOR '/'
|
|
# define VIR_FILE_DIR_SEPARATOR_S "/"
|
|
# define VIR_FILE_IS_DIR_SEPARATOR(c) ((c) == VIR_FILE_DIR_SEPARATOR)
|
|
# define VIR_FILE_PATH_SEPARATOR ':'
|
|
# define VIR_FILE_PATH_SEPARATOR_S ":"
|
|
|
|
# endif /* !WIN32 */
|
|
|
|
bool virFileIsAbsPath(const char *path);
|
|
int virFileAbsPath(const char *path,
|
|
char **abspath) ATTRIBUTE_RETURN_CHECK;
|
|
const char *virFileSkipRoot(const char *path);
|
|
void virFileRemoveLastComponent(char *path);
|
|
|
|
int virFileOpenTty(int *ttymaster,
|
|
char **ttyName,
|
|
int rawmode);
|
|
|
|
char *virFileFindMountPoint(const char *type);
|
|
|
|
/* NB: this should be combined with virFileBuildPath */
|
|
# define virBuildPath(path, ...) \
|
|
virBuildPathInternal(path, __VA_ARGS__, NULL)
|
|
int virBuildPathInternal(char **path, ...) ATTRIBUTE_SENTINEL;
|
|
|
|
int virFilePrintf(FILE *fp, const char *msg, ...)
|
|
ATTRIBUTE_FMT_PRINTF(2, 3);
|
|
|
|
typedef struct _virHugeTLBFS virHugeTLBFS;
|
|
typedef virHugeTLBFS *virHugeTLBFSPtr;
|
|
struct _virHugeTLBFS {
|
|
char *mnt_dir; /* Where the FS is mount to */
|
|
unsigned long long size; /* page size in kibibytes */
|
|
bool deflt; /* is this the default huge page size */
|
|
};
|
|
|
|
int virFileGetHugepageSize(const char *path,
|
|
unsigned long long *size);
|
|
int virFileFindHugeTLBFS(virHugeTLBFSPtr *ret_fs,
|
|
size_t *ret_nfs);
|
|
|
|
int virFileSetupDev(const char *path,
|
|
const char *mount_options);
|
|
|
|
int virFileBindMountDevice(const char *src,
|
|
const char *dst);
|
|
|
|
int virFileMoveMount(const char *src,
|
|
const char *dst);
|
|
|
|
int virFileGetACLs(const char *file,
|
|
void **acl);
|
|
|
|
int virFileSetACLs(const char *file,
|
|
void *acl);
|
|
|
|
void virFileFreeACLs(void **acl);
|
|
|
|
int virFileCopyACLs(const char *src,
|
|
const char *dst);
|
|
|
|
int virFileComparePaths(const char *p1, const char *p2);
|
|
|
|
int virFileReadValueInt(int *value, const char *format, ...)
|
|
ATTRIBUTE_FMT_PRINTF(2, 3);
|
|
int virFileReadValueUint(unsigned int *value, const char *format, ...)
|
|
ATTRIBUTE_FMT_PRINTF(2, 3);
|
|
int virFileReadValueBitmap(virBitmapPtr *value, const char *format, ...)
|
|
ATTRIBUTE_FMT_PRINTF(2, 3);
|
|
int virFileReadValueScaledInt(unsigned long long *value, const char *format, ...)
|
|
ATTRIBUTE_FMT_PRINTF(2, 3);
|
|
int virFileReadValueString(char **value, const char *format, ...)
|
|
ATTRIBUTE_FMT_PRINTF(2, 3);
|
|
|
|
|
|
int virFileInData(int fd,
|
|
int *inData,
|
|
long long *length);
|
|
|
|
#endif /* __VIR_FILE_H */
|