External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-18 10:35:20 +00:00
Code Issues Packages Projects Releases Wiki Activity
libvirt/tests
History
Martin Kletzander 9f6749dea0 util: Check for errors in virLogSetFromEnv 
And make callers check the return value as well.  This helps error out early for
invalid environment variables.

That is desirable because it could lead to deadlocks.  This can happen when
resetting logging after fork() reports translated errors because gettext
functions are not reentrant.  Well, it is not limited to resetting logging after
fork(), it can be any translation at that phase, but parsing environment
variables is easy to make fail on purpose to show the result, it can also happen
just due to a typo.

Before this commit it is possible to deadlock the daemon on startup
with something like:

LIBVIRT_LOG_FILTERS='1:*' LIBVIRT_LOG_OUTPUTS=1:stdout libvirtd

where filters are used to enable more logging and hence make the race less rare
and outputs are set to invalid

Combined with the previous patches this changes
the following from:

...
<deadlock>

to:

...
libvirtd: initialisation failed

The error message is improved in future commits and is also possible thanks to
this patch.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
2022-01-05 14:08:40 +01:00
..
bhyveargv2xmldata
…
bhyvefirmwaredata
…
bhyvexml2argvdata
…
bhyvexml2xmloutdata
…
capabilityschemadata
…
commanddata
…
cputestdata
cpu-data.py: Automatically adjust command line for kcpuid
2021-05-07 18:02:48 +02:00
domainbackupxml2xmlin
…
domainbackupxml2xmlout
…
domaincapsdata
qemu: report max number of SEV guests
2021-12-14 16:04:17 +00:00
domainconfdata
…
domainschemadata
…
fchostdata/fc_host
…
genericxml2xmlindata
conf: introduce support for Fibre Channel VMID
2021-08-17 13:50:38 +02:00
genericxml2xmloutdata
genericxml2xmltest: Modify cachetune test to include id
2021-07-20 16:43:46 +02:00
interfaceschemadata
…
libxlxml2domconfigdata
…
lxcconf2xmldata
…
lxcxml2xmldata
…
lxcxml2xmloutdata
…
networkxml2confdata
tests: do not test dnsmasq older than 2.67
2021-12-15 15:28:17 +01:00
networkxml2firewalldata
…
networkxml2xmlin
network: Allow adding DNS entries sharing hostname for multiple addreses
2021-07-16 14:50:57 +02:00
networkxml2xmlout
network: Allow adding DNS entries sharing hostname for multiple addreses
2021-07-16 14:50:57 +02:00
networkxml2xmlupdatein
…
networkxml2xmlupdateout
network: Allow adding DNS entries sharing hostname for multiple addreses
2021-07-16 14:50:57 +02:00
nodedevmdevctldata
nodedev: Add tests for mdevctl autostart command
2021-09-14 14:24:07 -05:00
nodedevschemadata
Add PCI VPD Capability Support
2021-10-21 17:34:04 +01:00
nodedevxml2xmlout
Add PCI VPD Capability Support
2021-10-21 17:34:04 +01:00
nssdata
…
nwfilterxml2firewalldata
…
nwfilterxml2xmlin
…
nwfilterxml2xmlout
…
qemuagentdata
…
qemublocktestdata
qemublocktest: Add test for creating a qcow2 on top of an luks-encrypted qcow2
2021-08-20 15:43:17 +02:00
qemucapabilitiesdata
qemu_capabilities: Introduce QEMU_CAPS_SEV_INJECT_LAUNCH_SECRET
2022-01-04 10:56:00 -07:00
qemucaps2xmloutdata
…
qemudomaincheckpointxml2xmlin
backup: Document new XML for checkpoints
2019-07-26 16:48:58 -05:00
qemudomaincheckpointxml2xmlout
…
qemudomainsnapshotxml2xmlin
…
qemudomainsnapshotxml2xmlout
…
qemufirmwaredata
…
qemuhotplugtestcpus
qemuhotplugtest: Remove tests for legacy cpu hotplug on x86
2021-11-01 16:14:53 +01:00
qemuhotplugtestdevices
qemuhotplugtest: Add also always-present capabilities
2021-05-03 12:14:44 +02:00
qemuhotplugtestdomains
tests: qemu: Remove 's390-ccw' machine type from fake capabilities
2021-09-23 14:48:51 +02:00
qemumemlockdata
…
qemumigparamsdata
qemumigparamstest: Drop "unsupported" test case
2021-10-22 07:00:44 +02:00
qemumigrationcookiexmldata
qemu: migration: Don't transfer 'allowReboot' flag
2021-08-25 15:32:44 +02:00
qemumonitorjsondata
…
qemusecuritydata
…
qemustatusxml2xmldata
qemustatusxml2xmldata: backup-pull: Add private data for scratch image
2021-11-04 10:55:28 +01:00
qemuvhostuserdata
…
qemuxml2argvdata
qemuxml2xmloutdata: Turn kvm-features*.xml into symlinks
2022-01-04 16:40:10 +01:00
qemuxml2xmloutdata
qemuxml2xmloutdata: Turn kvm-features*.xml into symlinks
2022-01-04 16:40:10 +01:00
secretxml2xmlin
…
securityselinuxhelperdata
…
securityselinuxlabeldata
…
storagepoolcapsschemadata
…
storagepoolschemadata
…
storagepoolxml2argvdata
…
storagepoolxml2xmlin
…
storagepoolxml2xmlout
…
storagevolschemadata
…
storagevolxml2argvdata
storage: Introduce 'extended_l2' feature for storage volume
2021-12-21 13:23:09 +01:00
storagevolxml2xmlin
storage: Introduce 'extended_l2' feature for storage volume
2021-12-21 13:23:09 +01:00
storagevolxml2xmlout
storage: Introduce 'extended_l2' feature for storage volume
2021-12-21 13:23:09 +01:00
sysinfodata
…
vboxsnapshotxmldata
…
vircaps2xmldata
whitespace clean-ups
2021-07-15 14:50:48 +02:00
vircgroupdata
…
virconfdata
Add suggestions for virt-pki-query-dn usage
2021-11-12 12:37:29 +01:00
virfilecachedata
…
virfiledata
…
virhostcpudata
…
virjsondata
…
virmacmaptestdata
…
virnetdaemondata
…
virnetdevopenvswitchdata
…
virnetdevtestdata/sys/class/net
…
virnetworkportxml2xmldata
…
virnwfilterbindingxml2xmldata
…
virpcitestdata
…
virprocessstatdata
util: Add virProcessGetStat
2021-11-23 16:43:08 +01:00
virresctrldata
…
virscsidata
…
virstoragetestdata
virstoragetest: Reinstate testing of images without 'backing_fmt'
2021-09-09 15:29:00 +02:00
virstorageutildata
…
virusbtestdata/sys_bus_usb/devices
…
vmwareverdata
…
vmx2xmldata
tests: Add missing test cases to vmx2xmltest
2021-08-19 13:32:10 +02:00
xlconfigdata
…
xmconfigdata
…
xml2vmxdata
…
.valgrind.supp
…
bhyveargv2xmlmock.c
…
bhyveargv2xmltest.c
tests: bhyve: use bitwise shift when defining flags
2021-09-08 15:13:12 +02:00
bhyvexml2argvmock.c
lib: Drop intermediary return variables
2021-10-25 12:48:46 +02:00
bhyvexml2argvtest.c
…
bhyvexml2xmltest.c
…
commandhelper.c
…
commandtest.c
Remove static analysis assertions
2021-05-24 20:26:20 +02:00
cputest.c
tests: remove pointless labels
2021-09-09 18:06:13 +02:00
domaincapsmock.c
virhostmem: Introduce virHostMemGetTHPSize()
2021-10-01 10:58:27 +02:00
domaincapstest.c
tests: Remove 'qemucapsfixreplies'
2022-01-03 13:14:43 +01:00
domainconftest.c
lib: Drop needless one line labels
2021-11-22 12:39:59 +01:00
esxutilstest.c
tests: esxutils: reduce variable scope in testConvertWindows1252ToUTF8
2021-09-08 15:31:01 +02:00
eventtest.c
tests: use g_autofree
2021-09-09 18:06:13 +02:00
fchosttest.c
tests: remove pointless labels
2021-09-09 18:06:13 +02:00
fdstreamtest.c
tests: use VIR_AUTOCLOSE
2021-09-09 18:06:13 +02:00
genericxml2xmltest.c
virDomainBackupDefFormat: Propagate private data callbacks
2021-11-04 10:55:28 +01:00
interfacexml2xmltest.c
lib: Introduce and use g_autoptr() for virInterfaceDef
2021-11-02 10:52:18 +01:00
libvirtd-fail
…
libvirtd-pool
…
libxlmock.c
tests: libxl: Mock xs_open and xs_close
2021-05-18 09:09:37 -06:00
libxlxml2domconfigtest.c
tests: use g_auto instead of virDomainFree
2021-09-09 18:06:13 +02:00
lxcconf2xmltest.c
tests: remove pointless labels
2021-09-09 18:06:13 +02:00
lxcxml2xmltest.c
tests: use g_autofree
2021-09-09 18:06:13 +02:00
meson.build
tests: Tool for programatic modification of qemucapabilitiesdata/*.replies
2022-01-03 13:14:43 +01:00
metadatatest.c
tests: remove pointless labels
2021-09-09 18:06:13 +02:00
networkxml2conftest.c
tests: do not test dnsmasq older than 2.67
2021-12-15 15:28:17 +01:00
networkxml2firewalltest.c
util: remove currentBackend from virfirewall.c
2021-12-13 13:37:31 -05:00
networkxml2xmltest.c
tests: network: use g_autofree
2021-09-09 18:06:13 +02:00
networkxml2xmlupdatetest.c
tests: network: use g_autofree
2021-09-09 18:06:13 +02:00
nodedevmdevctltest.c
nodedev: Add tests for mdevctl autostart command
2021-09-14 14:24:07 -05:00
nodedevxml2xmltest.c
Add PCI VPD Capability Support
2021-10-21 17:34:04 +01:00
nsslinktest.c
…
nssmock.c
…
nsstest.c
tests: use g_autofree
2021-09-09 18:06:13 +02:00
nwfilterebiptablestest.c
util: remove currentBackend from virfirewall.c
2021-12-13 13:37:31 -05:00
nwfilterxml2firewalltest.c
util: remove currentBackend from virfirewall.c
2021-12-13 13:37:31 -05:00
nwfilterxml2xmltest.c
tests: nwfilter: use g_autofree
2021-09-09 18:06:13 +02:00
objecteventtest.c
objecteventtest: Don't overwrite @ret on failure
2021-10-18 12:09:33 +02:00
openvzutilstest.c
tests: remove pointless labels
2021-09-09 18:06:13 +02:00
openvzutilstest.conf
…
permitted_file_access.txt
…
pkix_asn1_tab.c
tests: Replace deprecated ASN1 code
2021-05-18 10:02:24 +02:00
qemuagenttest.c
tests: Drop cleanup/error labels
2021-11-11 16:16:30 +01:00
qemublocktest.c
qemublocktest: Replace virJSONValueObjectCreate by virJSONValueObjectAdd
2021-11-17 12:04:11 +01:00
qemucapabilitiesnumbering.c
tests: Tool for programatic modification of qemucapabilitiesdata/*.replies
2022-01-03 13:14:43 +01:00
qemucapabilitiestest.c
tests: Remove 'qemucapsfixreplies'
2022-01-03 13:14:43 +01:00
qemucaps2xmlmock.c
…
qemucaps2xmltest.c
Remove empty cleanup sections
2021-12-13 14:44:01 +01:00
qemucapsprobe.c
qemu: Invalidate capabilities cache on host cpuid mismatch
2021-11-05 17:12:25 +01:00
qemucapsprobemock.c
tests: qemu: remove pointless labels
2021-09-09 18:06:13 +02:00
qemucommandutiltest.c
tests: qemu: remove pointless labels
2021-09-09 18:06:13 +02:00
qemucpumock.c
…
qemudomaincheckpointxml2xmltest.c
…
qemudomainsnapshotxml2xmltest.c
…
qemufirmwaretest.c
…
qemuhotplugmock.c
virDevMapperGetTargets: Use a linked list as return type
2021-09-21 12:25:42 +02:00
qemuhotplugtest.c
tests: Use g_autoptr(qemuMonitorTest)
2021-11-11 16:16:26 +01:00
qemumemlocktest.c
…
qemumigparamstest.c
tests: Drop cleanup/error labels
2021-11-11 16:16:30 +01:00
qemumigrationcookiexmltest.c
testQEMUSchemaValidateCommand: Add possibility for partial QMP validation
2021-10-18 14:00:58 +02:00
qemumonitorjsontest.c
qemu: Implement the virDomainSetLaunchSecurityState API
2022-01-04 10:56:00 -07:00
qemumonitortestutils.c
qemumonitortestutils: Extract parser for the monitor conversation dump file
2022-01-03 13:14:43 +01:00
qemumonitortestutils.h
qemumonitortestutils: Extract parser for the monitor conversation dump file
2022-01-03 13:14:43 +01:00
qemusecuritymock.c
Switch away from virHashFree
2021-12-01 13:53:12 +01:00
qemusecuritytest.c
qemusecuritytest: Honour EXIT_AM_SKIP
2021-05-18 13:18:05 +02:00
qemusecuritytest.h
…
qemustatusxml2xmltest.c
test: Drop unused @cfg from qemu*test
2021-08-26 09:16:44 +02:00
qemuvhostusertest.c
…
qemuxml2argvmock.c
lib: Drop intermediary return variables
2021-10-25 12:48:46 +02:00
qemuxml2argvtest.c
qemu: format sev-guest.kernel-hashes property
2021-12-16 18:10:33 +00:00
qemuxml2xmltest.c
qemuxml2xmltest: Introduce tpm-emulator-spapr test
2022-01-04 09:43:35 +01:00
scsihosttest.c
tests: remove pointless labels
2021-09-09 18:06:13 +02:00
seclabeltest.c
tests: Return EXIT_FAILURE/EXIT_SUCCESS instead of -1/0
2021-05-17 09:25:32 +02:00
secretxml2xmltest.c
tests: use g_autofree
2021-09-09 18:06:13 +02:00
securityselinuxhelper.c
securityselinuxhelper: Fix retval of setcon_raw() and security_disable()
2021-05-10 13:32:43 +02:00
securityselinuxlabeltest.c
tests: remove pointless labels
2021-09-09 18:06:13 +02:00
securityselinuxtest.c
lib: Use g_autoptr() for virDomainDef
2021-12-03 17:18:26 +01:00
shunloadhelper.c
…
shunloadtest.c
…
sockettest.c
tests: use g_autofree
2021-09-09 18:06:13 +02:00
ssh.c
…
storagebackendsheepdogtest.c
…
storagepoolcapstest.c
tests: Return EXIT_FAILURE/EXIT_SUCCESS instead of -1/0
2021-05-17 09:25:32 +02:00
storagepoolxml2argvtest.c
…
storagepoolxml2xmltest.c
…
storagevolxml2argvtest.c
tests: storagevolxml2argvtest: do not reuse cmd
2021-12-14 16:41:06 +01:00
storagevolxml2xmltest.c
storage: add support for QCOW2 cluster_size option
2021-05-21 14:00:43 +02:00
sysinfotest.c
…
test-lib.sh
…
testutils.c
util: Check for errors in virLogSetFromEnv
2022-01-05 14:08:40 +01:00
testutils.h
Add a PCI/PCIe device VPD Parser
2021-10-21 17:34:04 +01:00
testutilshostcpus.h
…
testutilslxc.c
testLXCCapsInit: Cleanup
2021-11-08 14:32:32 +01:00
testutilslxc.h
…
testutilsqemu.c
tests: allow setting extra capabilities on top of versioned caps
2021-12-16 18:10:33 +00:00
testutilsqemu.h
tests: qemuxml2*test: switch to virTestRunLog
2021-08-23 14:43:57 +02:00
testutilsqemuschema.c
testQEMUSchemaValidateEnum: Validate deprecated members
2021-11-01 17:37:15 +01:00
testutilsqemuschema.h
testQEMUSchemaValidateCommand: Add possibility for partial QMP validation
2021-10-18 14:00:58 +02:00
testutilsxen.c
Use g_auto for stealing virCaps
2021-12-13 14:44:01 +01:00
testutilsxen.h
…
utiltest.c
…
vboxsnapshotxmltest.c
Remove empty cleanup sections
2021-12-13 14:44:01 +01:00
viralloctest.c
…
virauthconfigtest.c
…
virbitmaptest.c
virBitmapSetBitExpand: Remove return value
2021-12-10 16:36:25 +01:00
virbuftest.c
…
vircaps2xmltest.c
vircaps2xmltest: Introduce HMAT test case
2021-06-15 11:03:56 +02:00
vircapstest.c
test_virCapabilitiesGetCpusForNodemask: Refactor cleanup
2021-12-10 16:36:24 +01:00
vircgroupmock.c
…
vircgrouptest.c
tests: vir: use g_autofree
2021-09-09 18:06:13 +02:00
virconftest.c
Remove empty cleanup sections
2021-12-13 14:44:01 +01:00
vircryptotest.c
util: Remove use of virCryptoHaveCipher(VIR_CRYPTO_CIPHER_AES256CBC)
2021-09-22 14:53:55 +02:00
virdriverconnvalidatetest.c
…
virdrivermoduletest.c
Drop magic comments for coverity
2021-05-24 20:26:20 +02:00
virendiantest.c
tests: Return EXIT_FAILURE/EXIT_SUCCESS instead of -1/0
2021-05-17 09:25:32 +02:00
virerrortest.c
…
virfilecachemock.c
…
virfilecachetest.c
tests: vir: use g_autofree
2021-09-09 18:06:13 +02:00
virfilemock.c
tests: vir: use g_autofree
2021-09-09 18:06:13 +02:00
virfiletest.c
Remove empty cleanup sections
2021-12-13 14:44:01 +01:00
virfilewrapper.c
util: alloc: Completely replace VIR_APPEND_ELEMENT_QUIET by VIR_APPEND_ELEMENT
2021-08-06 08:53:25 +02:00
virfilewrapper.h
…
virfirewallmock.c
…
virfirewalltest.c
util: remove currentBackend from virfirewall.c
2021-12-13 13:37:31 -05:00
virgdbusmock.c
…
virhostcpumock.c
…
virhostcputest.c
tests: vir: remove pointless labels
2021-09-09 18:06:13 +02:00
virhostdevmock.c
…
virhostdevtest.c
…
virhostidmock.c
…
viridentitytest.c
util: generate a persistent system token
2021-05-13 11:07:16 +01:00
viriscsitest.c
tests: vir: remove pointless labels
2021-09-09 18:06:13 +02:00
virjsontest.c
util: json: Don't copy string in virJSONValueNewString
2021-12-22 13:48:35 +01:00
virkeycodetest.c
…
virkmodtest.c
tests: vir: remove pointless labels
2021-09-09 18:06:13 +02:00
virlockspacetest.c
…
virlogtest.c
tests: Return EXIT_FAILURE/EXIT_SUCCESS instead of -1/0
2021-05-17 09:25:32 +02:00
virmacmaptest.c
tests: vir: remove pointless labels
2021-09-09 18:06:13 +02:00
virmigtest.c
…
virmock.h
…
virmockstathelpers.c
…
virnetdaemonmock.c
…
virnetdaemontest.c
tests/virnetdaemontest.c: testExecRestart: Automatically free virJSONValue-s
2021-12-07 09:00:39 +01:00
virnetdevbandwidthmock.c
…
virnetdevbandwidthtest.c
tests: virnetdev*: remove unnecessary labels
2021-08-20 16:43:20 +02:00
virnetdevmock.c
…
virnetdevopenvswitchtest.c
virnetdevopenvswitch: unify calculation of ovs and tc
2021-11-01 15:56:47 +01:00
virnetdevtest.c
…
virnetmessagetest.c
…
virnetserverclientmock.c
…
virnetserverclienttest.c
lib: Drop intermediary return variables
2021-10-25 12:48:46 +02:00
virnetsockettest.c
virnetsocket: Don't free virCommand in virNetSocketNewConnectCommand()
2021-10-15 16:03:22 +02:00
virnettlscontexttest.c
…
virnettlshelpers.c
tests: use VIR_AUTOCLOSE
2021-09-09 18:06:13 +02:00
virnettlshelpers.h
…
virnettlssessiontest.c
…
virnetworkportxml2xmltest.c
tests: vir: remove pointless labels
2021-09-09 18:06:13 +02:00
virnumamock.c
virnumamock: Use automatic memory freeing for virBitmap
2021-12-10 16:36:24 +01:00
virnwfilterbindingxml2xmltest.c
tests: vir: use g_autofree
2021-09-09 18:06:13 +02:00
virpcimock.c
lib: Use G_N_ELEMENTS instead of sizeof()/sizeof()
2021-11-03 14:46:54 +01:00
virpcitest.c
Add PCI VPD-related helper functions to virpci
2021-10-21 17:34:04 +01:00
virpcivpdtest.c
tests: pcivpdtest: check return value of virCreateAnonymousFile
2021-11-23 16:59:36 +01:00
virpolkittest.c
…
virportallocatormock.c
…
virportallocatortest.c
…
virprocessmock.c
…
virprocessstattest.c
util: Add virProcessGetStat
2021-11-23 16:43:08 +01:00
virrandommock.c
…
virresctrltest.c
tests: vir: remove pointless labels
2021-09-09 18:06:13 +02:00
virrotatingfiletest.c
tests: use VIR_AUTOCLOSE
2021-09-09 18:06:13 +02:00
virschematest.c
…
virscsitest.c
tests: vir: remove pointless labels
2021-09-09 18:06:13 +02:00
virsh-auth
…
virsh-auth.xml
…
virsh-checkpoint
…
virsh-cpuset
…
virsh-define-dev-segfault
…
virsh-int-overflow
…
virsh-optparse
tests: Update expected output of virsh-optparse
2021-06-02 16:43:57 +02:00
virsh-output
…
virsh-output-commands
…
virsh-output.out
…
virsh-read-bufsiz
…
virsh-read-non-seekable
…
virsh-schedinfo
…
virsh-self-test
…
virsh-snapshot
test: snapshot revert: properly emulate starting CPUs
2021-11-23 11:41:55 +01:00
virsh-start
…
virsh-undefine
…
virsh-uriprecedence
…
virsh-vcpupin
…
virshtest.c
tests: Test IOThread related functions for test driver
2021-09-23 13:41:39 +02:00
virstoragetest.c
Fix typos
2021-09-17 14:28:00 +02:00
virstorageutiltest.c
…
virstringtest.c
Remove empty cleanup sections
2021-12-13 14:44:01 +01:00
virsystemdtest.c
tests: vir: remove pointless labels
2021-09-09 18:06:13 +02:00
virt-aa-helper-test
…
virt-admin-self-test
…
virtestmock.c
tests: vir: use g_autofree
2021-09-09 18:06:13 +02:00
virtimetest.c
tests: virtimetest: Mention GLib version containing fix
2022-01-03 09:39:35 +01:00
virtypedparamtest.c
…
viruritest.c
tests: vir: use g_autofree
2021-09-09 18:06:13 +02:00
virusbmock.c
lib: Drop intermediary return variables
2021-10-25 12:48:46 +02:00
virusbtest.c
tests: vir: use g_autofree
2021-09-09 18:06:13 +02:00
vmwarevertest.c
tests: remove pointless labels
2021-09-09 18:06:13 +02:00
vmx2xmltest.c
lib: Don't check for virCapabilitiesAddGuestDomain() retval
2021-11-01 16:08:26 +01:00
vshtabletest.c
vsh-table: Ensure NULL terminated arguments to vshTable*()
2021-12-17 15:05:58 +01:00
xlconfigtest.c
tests: libxl: remove pointless labels
2021-09-09 18:06:13 +02:00
xmconfigtest.c
tests: libxl: remove pointless labels
2021-09-09 18:06:13 +02:00
xml2vmxtest.c
lib: Don't check for virCapabilitiesAddGuestDomain() retval
2021-11-01 16:08:26 +01:00