mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-03 16:42:37 +00:00
e86390c9b4
We already use templating to generate sockets, which are all based off libvirtd's. Push the idea further, and extend it to cover services as well. This is more challenging, as the various modular daemons each have their own needs in terms of what system services needs to be available before they can be started, which other components of libvirt they depend on, and so on. In order to make this sort of per-service tweaks possible, we introduce a Python script that can merge two systemd units together. The script is aware of the semantics of systemd's unit definition format, so it can intelligently merge sections together. This generic systemd unit merging mechanism will also supersede the extremely ad-hoc @deps@ variable, which is currently used in a single scenario. Signed-off-by: Andrea Bolognani <abologna@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
95 lines
1.8 KiB
Python
Executable File
95 lines
1.8 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
|
|
# Copyright (C) 2023 Red Hat, Inc.
|
|
# SPDX-License-Identifier: LGPL-2.1-or-later
|
|
|
|
import sys
|
|
|
|
SECTIONS = [
|
|
"[Unit]",
|
|
"[Service]",
|
|
"[Socket]",
|
|
"[Install]",
|
|
]
|
|
|
|
|
|
def parse_unit(unit_path):
|
|
unit = {}
|
|
current_section = "[Invalid]"
|
|
|
|
with open(unit_path) as f:
|
|
for line in f:
|
|
line = line.strip()
|
|
|
|
if line == "":
|
|
continue
|
|
|
|
if line[0] == "[" and line[-1] == "]":
|
|
if line not in SECTIONS:
|
|
print("Unknown section {}".format(line))
|
|
sys.exit(1)
|
|
|
|
current_section = line
|
|
continue
|
|
|
|
if current_section not in unit:
|
|
unit[current_section] = []
|
|
|
|
unit[current_section].append(line)
|
|
|
|
if "[Invalid]" in unit:
|
|
print("Contents found outside of any section")
|
|
sys.exit(1)
|
|
|
|
return unit
|
|
|
|
|
|
def format_unit(unit):
|
|
lines = []
|
|
|
|
for section in SECTIONS:
|
|
if section not in unit:
|
|
continue
|
|
|
|
lines.append(section)
|
|
|
|
for line in unit[section]:
|
|
lines.append(line)
|
|
|
|
lines.append("")
|
|
|
|
return "\n".join(lines)
|
|
|
|
|
|
def merge_units(base, extra):
|
|
merged = {}
|
|
|
|
for section in SECTIONS:
|
|
if section in extra and section not in base:
|
|
print("Section {} in extra but not in base".format(section))
|
|
sys.exit(1)
|
|
|
|
if section not in base:
|
|
continue
|
|
|
|
merged[section] = base[section]
|
|
|
|
if section not in extra:
|
|
continue
|
|
|
|
merged[section].extend(extra[section])
|
|
|
|
return merged
|
|
|
|
|
|
if len(sys.argv) < 2:
|
|
print("usage: {} BASE EXTRA".format(sys.argv[0]))
|
|
sys.exit(1)
|
|
|
|
base = parse_unit(sys.argv[1])
|
|
extra = parse_unit(sys.argv[2])
|
|
|
|
merged = merge_units(base, extra)
|
|
|
|
sys.stdout.write(format_unit(merged))
|