Alex Jia ea964658af virsh: plug mem leaks in domxml-*-native ... Detected by valgrind. Leaks introduced in commit 4d5383f. * tools/virsh.c: fix memory leaks on cmdDomXMLFromNative and cmdDomXMLToNative. * how to reproduce? % virsh dumpxml ${guest} > foo.xml % valgrind -v --leak-check=full virsh domxml-from-native qemu-argv foo.xml % valgrind -v --leak-check=full virsh domxml-to-native qemu-argv foo.xml * actual valgrind results: ==9724== 8,193 bytes in 1 blocks are definitely lost in loss record 31 of 33 ==9724== at 0x4A05FDE: malloc (vg_replace_malloc.c:236) ==9724== by 0x4A06167: realloc (vg_replace_malloc.c:525) ==9724== by 0x4C7510B: virReallocN (memory.c:161) ==9724== by 0x4C84679: virFileReadLimFD (util.c:394) ==9724== by 0x4C84815: virFileReadAll (util.c:455) ==9724== by 0x41A89F: cmdDomXMLFromNative (virsh.c:5532) ==9724== by 0x414872: vshCommandRun (virsh.c:16464) ==9724== by 0x425623: main (virsh.c:17971) ==9724== ==9724== LEAK SUMMARY: ==9724== definitely lost: 8,193 bytes in 1 blocks ==9724== indirectly lost: 0 bytes in 0 blocks ==9724== possibly lost: 0 bytes in 0 blocks ==9724== still reachable: 127,128 bytes in 1,347 blocks ==7409== 8,193 bytes in 1 blocks are definitely lost in loss record 31 of 33 ==7409== at 0x4A05FDE: malloc (vg_replace_malloc.c:236) ==7409== by 0x4A06167: realloc (vg_replace_malloc.c:525) ==7409== by 0x4C7510B: virReallocN (memory.c:161) ==7409== by 0x4C84679: virFileReadLimFD (util.c:394) ==7409== by 0x4C84815: virFileReadAll (util.c:455) ==7409== by 0x41A7AF: cmdDomXMLToNative (virsh.c:5578) ==7409== by 0x414892: vshCommandRun (virsh.c:16463) ==7409== by 0x425633: main (virsh.c:17970) ==7409== ==7409== LEAK SUMMARY: ==7409== definitely lost: 8,193 bytes in 1 blocks ==7409== indirectly lost: 0 bytes in 0 blocks ==7409== possibly lost: 0 bytes in 0 blocks ==7409== still reachable: 127,128 bytes in 1,347 blocks Signed-off-by: Alex Jia <ajia@redhat.com>		2011-12-20 14:01:25 -07:00
..
.gitignore	Support automatic creation of leases for disks in sanlock	2011-06-28 18:18:06 +01:00
console.c	console: plug memory leaks	2011-12-20 13:36:45 -07:00
console.h	virsh: Allow other escape characters for console	2011-12-01 09:51:25 +01:00
libvirt_win_icon_16x16.ico
libvirt_win_icon_32x32.ico
libvirt_win_icon_48x48.ico
libvirt_win_icon_64x64.ico
libvirt-guests.init.sh	save: support bypass-cache flag in libvirt-guests init script	2011-07-21 16:24:09 -06:00
libvirt-guests.service.in	Add support for systemd init service	2011-11-18 16:16:02 +00:00
libvirt-guests.sysconf	save: support bypass-cache flag in libvirt-guests init script	2011-07-21 16:24:09 -06:00
Makefile.am	build: follow directory install conventions	2011-12-12 10:26:57 -07:00
virsh_win_icon.rc
virsh.c	virsh: plug mem leaks in domxml-*-native	2011-12-20 14:01:25 -07:00
virsh.pod	add new command numatune to virsh	2011-12-20 11:23:46 -07:00
virt-pki-validate.in	virt-*-validate.in: quote all variable references	2011-02-21 10:32:34 -07:00
virt-sanlock-cleanup.in	Fix virt-sanlock-cleanup documentation	2011-10-17 10:57:36 -06:00
virt-xml-validate.in	virt-*-validate.in: quote all variable references	2011-02-21 10:32:34 -07:00