mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-09-21 15:11:18 +00:00
4932ef4502
There is some controversy[1] on the qemu list on whether qemu should have ever allowed arbitrary file name passthrough, or whether it should be restricted to JUST /dev/random and /dev/hwrng. It is always easier to add support for additional filenames than it is to remove support for something once released, so this patch restricts libvirt 1.0.3 (where the virtio-random backend was first supported) to just the two uncontroversial names, letting us defer to a later date any decision on whether supporting arbitrary files makes sense. Additionally, since qemu 1.4 does NOT support /dev/fdset/nnn fd passthrough for the backend, limiting to just two known names means that we don't get tempted to try fd passthrough where it won't work. [1]https://lists.gnu.org/archive/html/qemu-devel/2013-03/threads.html#00023 * src/conf/domain_conf.c (virDomainRNGDefParseXML): Only allow /dev/random and /dev/hwrng. * docs/schemas/domaincommon.rng: Flag invalid files. * docs/formatdomain.html.in (elementsRng): Document this. * tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-random.args: Update test to match. * tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-random.xml: Likewise.
7 lines
352 B
Plaintext
7 lines
352 B
Plaintext
LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test /usr/bin/qemu \
|
|
-S -M pc -m 214 -smp 1 -nographic -nodefaults \
|
|
-monitor unix:/tmp/test-monitor,server,nowait -no-acpi -boot c -usb \
|
|
-device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3 \
|
|
-object rng-random,id=rng0,filename=/dev/hwrng \
|
|
-device virtio-rng-pci,rng=rng0,bus=pci.0,addr=0x4
|