mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-07 14:55:46 +00:00
eb9093763f
I noticed this while working on qemuDomainGetBlockInfo. Assigning a bool value to an int variable compiles fine, but raises red flags on the maintenance front as it becomes too easy to assign -1 or 2 or any other non-bool value to the same variable. * cfg.mk (sc_prohibit_int_assign_bool): New rule. * src/conf/snapshot_conf.c (virDomainSnapshotRedefinePrep): Fix offenders. * src/qemu/qemu_driver.c (qemuDomainGetBlockInfo) (qemuDomainSnapshotCreateXML): Likewise. * src/test/test_driver.c (testDomainSnapshotAlignDisks): Likewise. * src/util/vircgroup.c (virCgroupSupportsCpuBW): Likewise. * src/util/virpci.c (virPCIDeviceBindToStub): Likewise. * src/util/virutil.c (virIsCapableVport): Likewise. * tools/virsh-domain-monitor.c (cmdDomMemStat): Likewise. * tools/virsh-domain.c (cmdBlockResize, cmdScreenshot) (cmdInjectNMI, cmdSendKey, cmdSendProcessSignal) (cmdDetachInterface): Likewise. Signed-off-by: Eric Blake <eblake@redhat.com> |
||
---|---|---|
.. | ||
capabilities.c | ||
capabilities.h | ||
cpu_conf.c | ||
cpu_conf.h | ||
device_conf.c | ||
device_conf.h | ||
domain_addr.c | ||
domain_addr.h | ||
domain_audit.c | ||
domain_audit.h | ||
domain_capabilities.c | ||
domain_capabilities.h | ||
domain_conf.c | ||
domain_conf.h | ||
domain_event.c | ||
domain_event.h | ||
domain_nwfilter.c | ||
domain_nwfilter.h | ||
interface_conf.c | ||
interface_conf.h | ||
netdev_bandwidth_conf.c | ||
netdev_bandwidth_conf.h | ||
netdev_vlan_conf.c | ||
netdev_vlan_conf.h | ||
netdev_vport_profile_conf.c | ||
netdev_vport_profile_conf.h | ||
network_conf.c | ||
network_conf.h | ||
network_event.c | ||
network_event.h | ||
node_device_conf.c | ||
node_device_conf.h | ||
numatune_conf.c | ||
numatune_conf.h | ||
nwfilter_conf.c | ||
nwfilter_conf.h | ||
nwfilter_ipaddrmap.c | ||
nwfilter_ipaddrmap.h | ||
nwfilter_params.c | ||
nwfilter_params.h | ||
object_event_private.h | ||
object_event.c | ||
object_event.h | ||
secret_conf.c | ||
secret_conf.h | ||
snapshot_conf.c | ||
snapshot_conf.h | ||
storage_conf.c | ||
storage_conf.h | ||
virchrdev.c | ||
virchrdev.h |