mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-11 04:15:49 +00:00
4bca6192f2
Now that the size of guest's memory can be inferred from the NUMA configuration (if present) make it optional to specify <memory> explicitly. To make sure that memory is specified add a check that some form of memory size was specified. One side effect of this change is that it is no longer possible to specify 0KiB as memory size for the VM, but I don't think it would be any useful to do so. (I can imagine embedded systems without memory, just registers, but that's far from what libvirt is usually doing). Forbidding 0 memory for guests also fixes a few corner cases where 0 was not interpreted correctly and caused failures. (Arguments for numad when using automatic placement, size of the balloon). This fixes problems described in https://bugzilla.redhat.com/show_bug.cgi?id=1161461 Test case changes are added to verify that the schema change and code behave correctly.
8 lines
348 B
Plaintext
8 lines
348 B
Plaintext
LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none \
|
|
/usr/bin/qemu -S -M pc \
|
|
-m 214 -smp 16,sockets=2,cores=4,threads=2 \
|
|
-numa node,nodeid=0,cpus=0-7,mem=107 \
|
|
-numa node,nodeid=1,cpus=8-15,mem=107 -nographic -monitor \
|
|
unix:/tmp/test-monitor,server,nowait -no-acpi -boot n -usb -net none -serial none \
|
|
-parallel none
|