John Ferlan f29b13f830 util: Alter return value of virReadFCHost and fix mem leak
https://bugzilla.redhat.com/show_bug.cgi?id=1357416

Rather than return a 0 or -1 and the *result string, return just the result
string to the caller.  Alter all the callers to handle the different return.

As a side effect or result of this, it's much clearer that we cannot just
assign the returned string into the scsi_host wwnn, wwpn, and fabric_wwn
fields - rather we should fetch a temporary string, then as long as our
fetch was good, VIR_FREE what may have been there, and STEAL what we just got.
This fixes a memory leak in the virNodeDeviceCreateXML code path through
find_new_device and nodeDeviceLookupSCSIHostByWWN which will continually
call nodeDeviceSysfsGetSCSIHostCaps until the expected wwnn/wwpn is found
in the device object capabilities.

Signed-off-by: John Ferlan <jferlan@redhat.com>
2016-10-14 06:47:36 -04:00
..
2016-09-22 15:40:09 +02:00
2016-03-18 17:29:53 +01:00
2015-05-21 18:13:18 +02:00
2016-09-22 15:40:09 +02:00
2016-09-14 13:18:07 +02:00
2016-03-18 17:29:53 +01:00
2016-05-14 09:19:51 +02:00
2016-05-02 07:18:25 +02:00
2016-06-14 08:25:25 +02:00
2016-05-20 17:16:21 +02:00
2016-05-20 17:16:21 +02:00
2015-04-14 19:33:02 +02:00
2016-05-20 17:16:21 +02:00
2016-09-14 13:18:07 +02:00
2016-08-24 17:43:29 +02:00
2016-05-02 07:18:25 +02:00