libvirt/src/vbox
Matthias Bolte f66636e3ca vbox: Fix segfault on empty device source
<source file=''/> results in def->disks[i]->src == NULL. But
vboxDomainDefineXML and vboxDomainAttachDevice didn't check
def->disks[i]->src for NULL and expected it to be a valid string.

Add checks for def->disks[i]->src != NULL to fix the segfault.
2010-03-24 21:00:53 +01:00
..
README integration of the VirtualBox support 2009-04-17 16:09:07 +00:00
vbox_CAPI_v2_2.h build: consistently indent preprocessor directives 2010-03-09 19:22:28 +01:00
vbox_CAPI_v3_0.h build: consistently indent preprocessor directives 2010-03-09 19:22:28 +01:00
vbox_CAPI_v3_1.h build: consistently indent preprocessor directives 2010-03-09 19:22:28 +01:00
vbox_driver.c build: consistently use C99 varargs macros 2010-03-08 13:32:27 +01:00
vbox_driver.h build: consistently indent preprocessor directives 2010-03-09 19:22:28 +01:00
vbox_tmpl.c vbox: Fix segfault on empty device source 2010-03-24 21:00:53 +01:00
vbox_V2_2.c integration of the VirtualBox support 2009-04-17 16:09:07 +00:00
vbox_V3_0.c Add support for VBox 3 and event callbacks on vbox 2009-07-24 18:12:16 +02:00
vbox_V3_1.c vbox: Add support for version 3.1 2009-12-04 14:49:45 +01:00
vbox_XPCOMCGlue.c remove all trailing blank lines 2009-07-16 15:06:42 +02:00
vbox_XPCOMCGlue.h build: consistently indent preprocessor directives 2010-03-09 19:22:28 +01:00

    Explanation about the how multi-version support
    for VirtualBox libvirt driver is implemented.

Since VirtualBox adds multiple new features for each release, it is but
natural that the C API which VirtualBox exposes is volatile across
versions and thus needs a good mechanism to handle multiple versions
during runtime. The solution was something like this:

Firstly the file structure is as below:

vbox_CAPI_v2_2.h
vbox_XPCOMCGlue.h
vbox_XPCOMCGlue.c
These files are C API/glue code files directly taken from the
VirtualBox OSE source and is needed for C API to work as expected.

vbox_driver.h
vbox_driver.c
These files have the main logic for registering the virtualbox driver
with libvirt.

vbox_V2_2.c
The file which has version dependent changes and includes the template
file for given below for all of its functionality.

vbox_tmpl.c
The file where all the real driver implementation code exists.

Now there would be a vbox_V*.c file (for eg: vbox_V2_2.c for V2.2) for
each major virtualbox version which would do some preprocessor magic
and include the template file (vbox_tmpl.c) in it for the functionality
it offers.