mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-22 13:45:38 +00:00
94ded36b3f
There are some platforms where 'char' is unsigned, by default
(RPi, s390x to name a few). And because of how test_demo is
written we are experiencing some test cases failing there. For
instance: /xdr/struct-scalar is failing. This is because in the
test (test_struct_scalar()), we have a struct with two chars. One
is initialized to 0xca, the other 0xfe (note that both have the
MSB set). The XDR encoder (xdr_TestStructScalar()) then calls
xdr_char() on both of them. But XDR itself has no notion of
char type, so under the hood, it expands it to int [1] and calls
xdr_int(). And this is where the problem lies. On platforms where
char is signed, the integer expansion results in 0xffffffca, but
on platforms where char is unsigned it results in 0x000000ca. Two
distinct results.
The test then goes and compares the encoded buffer with an
expected one (memcmp(), read from the disk earlier).
This poses no problem for real life use, because when decoding
those chars back, the padding is thrown away.
To avoid tickling this issue, use values that don't have the MSB
set.
1: https://git.linux-nfs.org/?p=steved/libtirpc.git;a=blob;f=src/xdr.c;h=28d1382cc4853ecf1238d792af5016160435d1e0;hb=HEAD#l487
Fixes:
|
||
|---|---|---|
| .. | ||
| rpcgen | ||
| apibuild.py | ||
| augeas-gentest.py | ||
| check-aclperms.py | ||
| check-aclrules.py | ||
| check-driverimpls.py | ||
| check-drivername.py | ||
| check-file-access.py | ||
| check-html-references.py | ||
| check-pot.py | ||
| check-remote-protocol.py | ||
| check-symfile.py | ||
| check-symsorting.py | ||
| cocci-macro-file.h | ||
| dtrace2systemtap.py | ||
| esx_vi_generator.py | ||
| genaclperms.py | ||
| genpolkit.py | ||
| gensystemtap.py | ||
| group-qemu-caps.py | ||
| header-ifdef.py | ||
| hvsupport.py | ||
| hyperv_wmi_generator.py | ||
| merge-systemd-units.py | ||
| meson-dist.py | ||
| meson-gen-authors.py | ||
| meson-gen-def.py | ||
| meson-gen-sym.py | ||
| meson-install-dirs.py | ||
| meson-install-symlink.py | ||
| meson-install-web.py | ||
| meson-python.sh | ||
| meson-timestamp.py | ||
| meson.build | ||
| mock-noinline.py | ||
| prohibit-duplicate-header.py | ||